Skip to content

Commit d4cbfa9

Browse files
authored
[v8] Drop support for non-CppGC v8::MicrotaskQueue (#260)
... as this support is already removed from V8.
1 parent e23a4d6 commit d4cbfa9

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

‎src/node_contextify.h‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,7 @@ struct ContextOptions {
1818
v8::Local<v8::String> origin;
1919
v8::Local<v8::Boolean> allow_code_gen_strings;
2020
v8::Local<v8::Boolean> allow_code_gen_wasm;
21-
#ifdef V8_CPPGC_MICROTASK_QUEUE
2221
v8::MicrotaskQueue* own_microtask_queue = nullptr;
23-
#else
24-
std::unique_ptr<v8::MicrotaskQueue> own_microtask_queue;
25-
#endif
2622
v8::Local<v8::Symbol> host_defined_options_id;
2723
bool vanilla = false;
2824
};
@@ -126,11 +122,7 @@ class ContextifyContext final : CPPGC_MIXIN(ContextifyContext) {
126122
}
127123

128124
inline v8::MicrotaskQueue* microtask_queue() const {
129-
#ifdef V8_CPPGC_MICROTASK_QUEUE
130125
return microtask_queue_;
131-
#else
132-
return microtask_queue_.get();
133-
#endif
134126
}
135127

136128
template <typename T>
@@ -194,11 +186,7 @@ class ContextifyContext final : CPPGC_MIXIN(ContextifyContext) {
194186
const v8::PropertyCallbackInfo<v8::Array>& args);
195187

196188
v8::TracedReference<v8::Context> context_;
197-
#ifdef V8_CPPGC_MICROTASK_QUEUE
198189
cppgc::Persistent<v8::MicrotaskQueue> microtask_queue_;
199-
#else
200-
std::unique_ptr<v8::MicrotaskQueue> microtask_queue_;
201-
#endif
202190
};
203191

204192
class ContextifyScript final : CPPGC_MIXIN(ContextifyScript) {

0 commit comments

Comments
 (0)