Skip to content

Commit ec20041

Browse files
authored
[v8] Drop support for non-CppGC v8::MicrotaskQueue (#261)
... as this support is already removed from V8.
1 parent d4cbfa9 commit ec20041

3 files changed

Lines changed: 0 additions & 21 deletions

File tree

‎common.gypi‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -547,9 +547,6 @@
547547
['tsan == 1', {
548548
'defines': ['V8_IS_TSAN',],
549549
}],
550-
['v8_cppgc_microtask_queue == 1', {
551-
'defines': ['V8_CPPGC_MICROTASK_QUEUE',],
552-
}],
553550
['OS == "win"', {
554551
'defines': [
555552
'WIN32',

‎src/node_contextify.cc‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,7 @@ ContextifyContext* ContextifyContext::New(Environment* env,
155155

156156
MicrotaskQueue* queue =
157157
options->own_microtask_queue
158-
#ifdef V8_CPPGC_MICROTASK_QUEUE
159158
? options->own_microtask_queue
160-
#else
161-
? options->own_microtask_queue.get()
162-
#endif
163159
: env->isolate()->GetCurrentContext()->GetMicrotaskQueue();
164160

165161
Local<Context> v8_context;
@@ -180,13 +176,7 @@ ContextifyContext::ContextifyContext(Environment* env,
180176
Local<Object> wrapper,
181177
Local<Context> v8_context,
182178
ContextOptions* options)
183-
#ifdef V8_CPPGC_MICROTASK_QUEUE
184179
: microtask_queue_(options->own_microtask_queue)
185-
#else
186-
: microtask_queue_(options->own_microtask_queue
187-
? options->own_microtask_queue.release()
188-
: nullptr)
189-
#endif
190180
{
191181
CppgcMixin::Wrap(this, env, wrapper);
192182

‎test/cctest/test_environment.cc‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -750,11 +750,7 @@ TEST_F(EnvironmentTest, NestedMicrotaskQueue) {
750750
const v8::HandleScope handle_scope(isolate_);
751751
const Argv argv;
752752

753-
#ifdef V8_CPPGC_MICROTASK_QUEUE
754753
v8::MicrotaskQueue*
755-
#else
756-
std::unique_ptr<v8::MicrotaskQueue>
757-
#endif
758754
queue =
759755
v8::MicrotaskQueue::New(isolate_, v8::MicrotasksPolicy::kExplicit);
760756

@@ -764,11 +760,7 @@ TEST_F(EnvironmentTest, NestedMicrotaskQueue) {
764760
{},
765761
{},
766762
v8::DeserializeInternalFieldsCallback(),
767-
#ifdef V8_CPPGC_MICROTASK_QUEUE
768763
queue
769-
#else
770-
queue.get()
771-
#endif
772764
);
773765
node::InitializeContext(context);
774766
v8::Context::Scope context_scope(context);

0 commit comments

Comments
 (0)