Repository navigation
Make robot discovery tolerate scope destruction - #301
Merged
Merged
Conversation
vRallev
commented
Oct 16, 2026
vRallev
marked this pull request as ready for review
October 16, 2026 19:44
Robot lookup can overlap scope cleanup after navigation and fail while reading services or children. Skip those failures when the scope has been destroyed, and discard destroyed candidates before checking for ambiguity. Preserve ancestor robot lookup and propagate failures from live scopes, robot getters, and robot factories unchanged. Keep the fix in `:robot:public` without changing `:scope` or its synchronization. Lookup does not extend a scope's lifetime.
vRallev
force-pushed
the
ralf/robot-discovery-destruction-race
branch
from
October 16, 2026 19:45
e913ac8 to
efb595a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robot lookup can overlap scope cleanup after navigation and fail while reading services or children. Skip those failures when the scope has been destroyed, and discard destroyed candidates before checking for ambiguity.
Preserve ancestor robot lookup and propagate failures from live scopes, robot getters, and robot factories unchanged. Keep the fix in
:robot:publicwithout changing:scopeor its synchronization. Lookup does not extend a scope's lifetime.