Add utils_string and rename pixel constants

Add common/utils/utils_string.h providing common::ConstStrLen and update usages to use it. Replace manual ConstStrLen and sizeof hacks with common::ConstStrLen and common::ArraySize. Rename pixel max and single LED count constants from RGB/RGBW to kRgb/kRgbw and update references in PixelConfiguration and RDM parameter definitions. Update file header/copyright in utils_port.h. Changes consolidate string/array helpers and standardize naming without changing runtime behavior.

Author: vanvught

common/include/common/utils/utils_port.h

@@ -1,8 +1,8 @@
 /**
- * @file dmxnode_utils.h
+ * @file utils_port.h
  *
  */
-/* Copyright (C) 2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2025-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal

common/include/common/utils/utils_string.h

@@ -0,0 +1,44 @@
+/**
+ * @file utils_string.h
+ *
+ */
+/* Copyright (C) 2026 by Arjan van Vught mailto:info@gd32-dmx.org
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+#ifndef COMMON_UTILS_UTILS_STRING_H_
+#define COMMON_UTILS_UTILS_STRING_H_
+
+#include <cstdint>
+
+namespace common
+{
+constexpr uint32_t ConstStrLen(const char* s)
+{
+    uint32_t len = 0;
+    while (s[len] != '\0')
+    {
+        ++len;
+    }
+    return len;
+}
+} // namespace common
+
+#endif // COMMON_UTILS_UTILS_STRING_H_

lib-pixel/include/pixelconfiguration.h

@@ -141,11 +141,11 @@ class PixelConfiguration
 
         if (leds_per_pixel_ == 4)
         {
-            count_ = count_ <= pixel::max::ledcount::RGBW ? count_ : pixel::max::ledcount::RGBW;
+            count_ = count_ <= pixel::max::ledcount::kRgbw ? count_ : pixel::max::ledcount::kRgbw;
         }
         else
         {
-            count_ = count_ <= pixel::max::ledcount::RGB ? count_ : pixel::max::ledcount::RGB;
+            count_ = count_ <= pixel::max::ledcount::kRgb ? count_ : pixel::max::ledcount::kRgb;
         }
 
         if (is_rtz_protocol_)

lib-pixel/include/pixeltype.h

@@ -30,6 +30,8 @@
 #include <cassert>
 
 #include "common/utils/utils_enum.h"
+#include "common/utils/utils_string.h"
+#include "common/utils/utils_array.h"
 
 namespace pixel
 {
@@ -157,26 +159,16 @@ inline constexpr TypeInfo kTypeInfo[] = {
     MakeSpiTypeInfo("P9813", LedCount::k3, 4000000, 25000000),
 };
 
-constexpr uint32_t kTypeInfoCount = static_cast<uint32_t>(sizeof(kTypeInfo) / sizeof(kTypeInfo[0]));
+constexpr uint32_t kTypeInfoCount = common::ArraySize(kTypeInfo);
 static_assert(kTypeInfoCount == static_cast<uint32_t>(LedType::kUndefined), "kTypeInfo must match LedType");
 
-constexpr uint32_t ConstStrLen(const char* s)
-{
-    uint32_t len = 0;
-    while (s[len] != '\0')
-    {
-        ++len;
-    }
-    return len;
-}
-
 constexpr uint32_t GetMaxTypeNameLength()
 {
     uint32_t max_len = 0;
 
     for (uint32_t i = 0; i < kTypeInfoCount; ++i)
     {
-        const uint32_t kLen = ConstStrLen(kTypeInfo[i].name);
+        const uint32_t kLen = common::ConstStrLen(kTypeInfo[i].name);
         if (kLen > max_len)
         {
             max_len = kLen;
@@ -194,7 +186,7 @@ constexpr uint32_t GetMaxLedMapNameLength()
 
     for (uint32_t i = 0; i < kMapsCount; ++i)
     {
-        const uint32_t kLen = ConstStrLen(kMaps[i]);
+        const uint32_t kLen = common::ConstStrLen(kMaps[i]);
         if (kLen > max_len)
         {
             max_len = kLen;
@@ -277,14 +269,14 @@ inline LedMap GetMapByName(const char* string)
 
 namespace max::ledcount
 {
-inline constexpr uint32_t RGB = (4 * 170);
-inline constexpr uint32_t RGBW = (4 * 128);
+inline constexpr uint32_t kRgb = (4 * 170);
+inline constexpr uint32_t kRgbw = (4 * 128);
 } // namespace max::ledcount
 
 namespace single
 {
-inline constexpr uint32_t RGB = 24;
-inline constexpr uint32_t RGBW = 32;
+inline constexpr uint32_t kRgb = 24;
+inline constexpr uint32_t kRgbw = 32;
 } // namespace single
 
 namespace defaults

lib-pixeldmx/src/pixeldmxrdm/rdm_manufacturer_pid.cpp

@@ -88,15 +88,15 @@ const rdmhandler::ParameterDescription RDMHandler::PARAMETER_DESCRIPTIONS[] = {
 #else
      E120_CC_GET,
 #endif
-     0, E120_UNITS_NONE, E120_PREFIX_NONE, 0, __builtin_bswap32(pixel::defaults::kCount), __builtin_bswap32(pixel::max::ledcount::RGB),
+     0, E120_UNITS_NONE, E120_PREFIX_NONE, 0, __builtin_bswap32(pixel::defaults::kCount), __builtin_bswap32(pixel::max::ledcount::kRgb),
      rdmhandler::Description<PixelCount, sizeof(PixelCount::kDescription)>::kValue, RDMHandler::PdlParameterDescription(sizeof(PixelCount::kDescription))},
     {E120_MANUFACTURER_PIXEL_GROUPING_COUNT::kCode, 2, E120_DS_UNSIGNED_WORD,
 #if defined(CONFIG_RDM_MANUFACTURER_PIDS_SET)
      E120_CC_GET_SET,
 #else
      E120_CC_GET,
 #endif
-     0, E120_UNITS_NONE, E120_PREFIX_NONE, 0, __builtin_bswap32(pixel::defaults::kCount), __builtin_bswap32(pixel::max::ledcount::RGB),
+     0, E120_UNITS_NONE, E120_PREFIX_NONE, 0, __builtin_bswap32(pixel::defaults::kCount), __builtin_bswap32(pixel::max::ledcount::kRgb),
      rdmhandler::Description<PixelGroupingCount, sizeof(PixelGroupingCount::kDescription)>::kValue,
      RDMHandler::PdlParameterDescription(sizeof(PixelGroupingCount::kDescription))},
     {E120_MANUFACTURER_PIXEL_MAP::kCode, rdmhandler::kDeviceDescriptionMaxLength, E120_DS_ASCII,