Unify undefined labels and JSON guards

Adds a shared `common::kUndefined` string and replaces scattered literal "Undefined" fallbacks across DMX, RDM, LTC, and MIDI-related code. The remote config JSON endpoints now enforce non-null/non-zero output buffers with assertions, and several small consistency cleanups were applied (macro style `#ifdef`, Art-Net node ID print usage, and minor formatting/log message tidy-ups).

Author: vanvught

common/include/common/utils/utils_string.h

@@ -33,6 +33,7 @@ inline constexpr char kWarning[] = "Warning";
 inline constexpr char kError[] = "Error";
 inline constexpr char kSuccess[] = "Success";
 inline constexpr char kUnknown[] = "Unknown"; 
+inline constexpr char kUndefined[] = "Undefined";
 
 constexpr const char* IsSuccess(bool is_success) {
   return is_success ? kSuccess : kError;

gd32_rdm_responder/lib/rdmslotinfo.cpp

@@ -26,14 +26,13 @@
 #include <cstdint>
 
 #include "rdmslotinfo.h"
+#include "common/utils/utils_string.h"
 #include "pixeldmxparamsrdm.h"
 
 using pixeldmx::paramsdmx::SlotsInfo;
 
-const char* RDMSlotInfo::GetCategoryTextUndefined(uint16_t slotoffset, uint32_t& length)
-{
-    switch (static_cast<pixeldmx::paramsdmx::SlotsInfo>(slotoffset))
-    {
+const char* RDMSlotInfo::GetCategoryTextUndefined(uint16_t slotoffset, uint32_t& length) {
+    switch (static_cast<pixeldmx::paramsdmx::SlotsInfo>(slotoffset)) {
         case SlotsInfo::TYPE:
             length = 4;
             return "Type";
@@ -63,5 +62,5 @@ const char* RDMSlotInfo::GetCategoryTextUndefined(uint16_t slotoffset, uint32_t&
     }
 
     length = 9;
-    return "Undefined";
+    return common::kUndefined;
 }

lib-dmxnode/include/dmxnode_nodetype.h

@@ -26,6 +26,7 @@
 #define DMXNODE_NODETYPE_H_
 
 #include <cstdint>
+#include "common/utils/utils_string.h"
 
 namespace dmxnode {
 enum class NodeType { 
@@ -60,7 +61,7 @@ inline const char* GetNodeType(NodeType type) {
         return kNodeTypeNames[static_cast<uint32_t>(type)];
     }
 
-    return "Undefined";
+    return common::kUndefined;
 }
 } // namespace dmxnode
 

lib-dmxnode/include/dmxnode_outputtype.h

@@ -26,24 +26,25 @@
 #define DMXNODE_OUTPUTTYPE_H_
 
 #include <cstdint>
+#include "common/utils/utils_string.h"
 
 namespace dmxnode {
 enum class OutputType {
-    kDmx,      //
-    kDmxRdm,   //
-    kPixel,    //
-    kPixelDmx, //
-    kPwm,      //
-    kRgbPanel, //
-    kSerial,   //
-    kOsc,      //
-    kMonitor,  //
-    kStepper,  //
-    kPlayer,   //
-    kArtNet,   //
-    kTimeCode, //
-    kNone,     //
-    kUndefined //
+    kDmx,       //
+    kDmxRdm,    //
+    kPixel,     //
+    kPixelDmx,  //
+    kPwm,       //
+    kRgbPanel,  //
+    kSerial,    //
+    kOsc,       //
+    kMonitor,   //
+    kStepper,   //
+    kPlayer,    //
+    kArtNet,    //
+    kTimeCode,  //
+    kNone,      //
+    kUndefined, //
 };
 
 inline constexpr const char* kOutputTypeNames[static_cast<uint32_t>(OutputType::kUndefined)] = {
@@ -60,15 +61,15 @@ inline constexpr const char* kOutputTypeNames[static_cast<uint32_t>(OutputType::
     "Player",    //
     "Art-Net",   //
     "Timecode",  //
-    "None"       //
+    "None",      //
 };
 
 inline const char* GetOutputType(OutputType type) {
     if (type < OutputType::kUndefined) {
         return kOutputTypeNames[static_cast<uint32_t>(type)];
     }
 
-    return "Undefined";
+    return common::kUndefined;
 }
 } // namespace dmxnode