Modernize device headers and SPI/I2C APIs

Refactor many lib-device headers to modern C++ conventions and adapt to the new SPI/I2C abstractions. Key changes:
- Replace HAL_SPI/HAL_I2C usage with Spi (and remove direct hal_i2c includes where relevant).
- Convert many compile-time constants to inline constexpr and adopt k-prefix naming for clarity.
- Normalize identifier names (camel/snake adjustments), rename members (e.g. m_bIsInitialized -> initialized_, address_ usage), and fix class name (BH170 -> BH1750).
- Update BW driver classes to use Spi::Write / spi::Transfern and new bw::port::write constants (k-prefixed), simplify constructors and connection checks.
- Update MAX7219, MCP and other device drivers to use new SPI API, constant names and tighten initialization logic.
- Clean up EMA template naming/behaviour and remove duplicate header guards; use clearer member names and constexpr kHalf.
- Update copyright years to 2026 and apply minor formatting/guard comment style changes.

Overall this commit prepares device drivers for the new hardware abstraction layer and improves naming consistency and safety across the codebase.

Author: vanvught

lib-device/include/bh1750.h

@@ -28,30 +28,25 @@
 
 #include <cstdint>
 
-#include "hal_i2c.h"
-
-namespace sensor
-{
-namespace bh1750
-{
-static constexpr char DESCRIPTION[] = "Ambient Light";
-static constexpr auto RANGE_MIN = 0;
-static constexpr auto RANGE_MAX = 65535;
+namespace sensor {
+namespace bh1750 {
+inline constexpr char kDescription[] = "Ambient Light";
+inline constexpr auto kRangeMin = 0;
+inline constexpr auto kRangeMax = 65535;
 } // namespace bh1750
 
-class BH170 : HAL_I2C
-{
+class BH1750 {
    public:
-    explicit BH170(uint8_t address = 0);
+    explicit BH1750(uint8_t address = 0);
 
-    bool Initialize() { return m_bIsInitialized; }
+    bool Initialize() { return initialized_; }
 
     uint16_t Get();
 
    private:
-    bool m_bIsInitialized = false;
+    uint8_t address_{0};
+    bool initialized_{false};
 };
-
 } // namespace sensor
 
-#endif  // BH1750_H_
+#endif // BH1750_H_

lib-device/include/bw.h

@@ -2,7 +2,7 @@
  * @file bw.h
  *
  */
-/* Copyright (C) 2020 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2020-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -30,104 +30,89 @@
 #include <string.h>
 #include <algorithm>
 
-#include "hal_spi.h"
+#include "spi.h"
 
 /*
  * http://www.bitwizard.nl/wiki/index.php/Default_addresses
  */
 
-namespace bw
-{
-namespace id_string
-{
-static constexpr size_t length = 0;
+namespace bw {
+namespace id_string {
+inline constexpr size_t kLength = 0;
 } // namespace id_string
 
-namespace spi::speed
-{
-static constexpr uint32_t max_hz = 50000;     ///< 50 kHz
-static constexpr uint32_t default_hz = 50000; ///< 50 kHz
+namespace spi::speed {
+inline constexpr uint32_t max_hz = 50000;     ///< 50 kHz
+inline constexpr uint32_t default_hz = 50000; ///< 50 kHz
 } // namespace spi::speed
 
-namespace lcd
-{
-static constexpr uint8_t address = 0x82;
-static constexpr char id_string[] = "spi_lcd";
-static constexpr uint8_t max_characters = 16;
-static constexpr uint8_t max_lines = 2;
-namespace spi
-{
-static constexpr uint32_t write_delay_us = 12;
+namespace lcd {
+inline constexpr uint8_t address = 0x82;
+inline constexpr char id_string[] = "spi_lcd";
+inline constexpr uint8_t max_characters = 16;
+inline constexpr uint8_t max_lines = 2;
+namespace spi {
+inline constexpr uint32_t write_delay_us = 12;
 } // namespace spi
 } // namespace lcd
 
-namespace dio
-{
-static constexpr uint8_t address = 0x84;
-static constexpr char id_string[] = "spi_dio";
+namespace dio {
+inline constexpr uint8_t address = 0x84;
+inline constexpr char id_string[] = "spi_dio";
 } // namespace dio
 
-namespace fets
-{
-static constexpr uint8_t address = 0x88;
-static constexpr char id_string[] = "spi_7fets";
+namespace fets {
+inline constexpr uint8_t address = 0x88;
+inline constexpr char id_string[] = "spi_7fets";
 } // namespace fets
 
-namespace relay
-{
-static constexpr uint8_t address = 0x8E;
-static constexpr char id_string[] = "spi_relay";
+namespace relay {
+inline constexpr uint8_t address = 0x8E;
+inline constexpr char id_string[] = "spi_relay";
 } // namespace relay
 
-namespace dimmer
-{
-static constexpr uint8_t address = 0x9E;
-static constexpr char id_string[] = "spi_dimmer";
+namespace dimmer {
+inline constexpr uint8_t address = 0x9E;
+inline constexpr char id_string[] = "spi_dimmer";
 } // namespace dimmer
 
-namespace port
-{
-namespace read
-{
-static constexpr uint8_t id_string = 0x01;
+namespace port {
+namespace read {
+inline constexpr uint8_t kIdString = 0x01;
 } // namespace read
-namespace write
-{
-static constexpr uint8_t set_all_outputs = 0x10;
-static constexpr uint8_t io_direction = 0x30;
+namespace write {
+inline constexpr uint8_t kSetAllOutputs = 0x10;
+inline constexpr uint8_t kIoDirection = 0x30;
 
-static constexpr uint8_t display_data = 0x00;
-static constexpr uint8_t clear_screen = 0x10; ///< any data clears the screen
-static constexpr uint8_t move_cursor = 0x11;
-static constexpr uint8_t reinit_lcd = 0x14;
+inline constexpr uint8_t kDisplayData = 0x00;
+inline constexpr uint8_t kClearScreen = 0x10; ///< any data clears the screen
+inline constexpr uint8_t kMoveCursor = 0x11;
+inline constexpr uint8_t kReinitLcd = 0x14;
 
 } // namespace write
 } // namespace port
 
 } // namespace bw
 
-class BwSpi : public HAL_SPI
-{
+class BwSpi : public Spi {
    public:
-    BwSpi(uint8_t nChipSelect, uint8_t address, const char* pIdString) : HAL_SPI(nChipSelect, bw::spi::speed::default_hz), address_(address)
-    {
-        char spiBuffer[bw::id_string::length + 2];
+    BwSpi(uint8_t chip_select, uint8_t address, const char* string) : Spi(chip_select, bw::spi::speed::default_hz), address_(address) {
+        char buffer[bw::id_string::kLength + 2];
 
-        spiBuffer[0] = static_cast<char>(address_ | 1);
-        spiBuffer[1] = bw::port::read::id_string;
+        buffer[0] = static_cast<char>(address_ | 1);
+        buffer[1] = bw::port::read::kIdString;
 
-        HAL_SPI::WriteRead(spiBuffer, sizeof(spiBuffer));
+        spi::Transfern(buffer, sizeof(buffer));
 
-        if (pIdString != nullptr)
-        {
-            const auto length = std::min(bw::id_string::length, strlen(pIdString));
-            m_IsConnected = (strncmp(&spiBuffer[2], pIdString, length) == 0);
+        if (string != nullptr) {
+            const auto kLength = std::min(bw::id_string::kLength, strlen(string));
+            connected_ = (strncmp(&buffer[2], string, kLength) == 0);
         }
     }
 
    protected:
     uint8_t address_;
-    bool m_IsConnected = false;
+    bool connected_{false};
 };
 
-#endif  // BW_H_
+#endif // BW_H_

lib-device/include/bwspi7fets.h

@@ -2,7 +2,7 @@
  * @file bwspi7fets.h
  *
  */
-/* Copyright (C) 2020 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2020-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -30,34 +30,32 @@
 
 #include "bw.h"
 
-class BwSpi7fets : BwSpi
-{
-    void SetDirection(uint8_t nMask)
-    {
+class BwSpi7fets : BwSpi {
+   public:
+    explicit BwSpi7fets(uint8_t chip_select = 0, uint8_t address = bw::fets::address) : BwSpi(chip_select, address, bw::fets::id_string) { SetDirection(0x7F); }
+
+    void Output(uint8_t pins) {
         char cmd[3];
 
         cmd[0] = static_cast<char>(address_);
-        cmd[1] = bw::port::write::io_direction;
-        cmd[2] = static_cast<char>(nMask);
+        cmd[1] = bw::port::write::kSetAllOutputs;
+        cmd[2] = static_cast<char>(pins);
 
-        HAL_SPI::Write(cmd, sizeof(cmd));
+        Spi::Write(cmd, sizeof(cmd), true);
     }
 
-   public:
-    explicit BwSpi7fets(uint8_t nChipSelect = 0, uint8_t address = bw::fets::address) : BwSpi(nChipSelect, address, bw::fets::id_string) { SetDirection(0x7F); }
+    bool IsConnected() { return connected_; }
 
-    void Output(uint8_t nPins)
-    {
+   private:
+    void SetDirection(uint8_t mask) {
         char cmd[3];
 
         cmd[0] = static_cast<char>(address_);
-        cmd[1] = bw::port::write::set_all_outputs;
-        cmd[2] = static_cast<char>(nPins);
+        cmd[1] = bw::port::write::kIoDirection;
+        cmd[2] = static_cast<char>(mask);
 
-        HAL_SPI::Write(cmd, sizeof(cmd));
+        Spi::Write(cmd, sizeof(cmd), true);
     }
-
-    bool IsConnected() { return m_IsConnected; }
 };
 
-#endif  // BWSPI7FETS_H_
+#endif // BWSPI7FETS_H_

lib-device/include/bwspidimmer.h

@@ -2,7 +2,7 @@
  * @file bwspidimmer.h
  *
  */
-/* Copyright (C) 2020 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2020-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -30,23 +30,21 @@
 
 #include "bw.h"
 
-class BwSpiDimmer: BwSpi {
-public:
-	explicit BwSpiDimmer(uint8_t nChipSelect = 0, uint8_t address = bw::dimmer::address): BwSpi(nChipSelect, address, bw::dimmer::id_string) {}
+class BwSpiDimmer : BwSpi {
+   public:
+    explicit BwSpiDimmer(uint8_t chip_select = 0, uint8_t address = bw::dimmer::address) : BwSpi(chip_select, address, bw::dimmer::id_string) {}
 
-	void Output(uint8_t nValue) {
-		char cmd[3];
+    void Output(uint8_t value) {
+        char cmd[3];
 
-		cmd[0] = static_cast<char>(address_);
-		cmd[1] = bw::port::write::set_all_outputs;
-		cmd[2] = static_cast<char>(nValue);
+        cmd[0] = static_cast<char>(address_);
+        cmd[1] = bw::port::write::kSetAllOutputs;
+        cmd[2] = static_cast<char>(value);
 
-		HAL_SPI::Write(cmd, sizeof(cmd));
-	}
+        Spi::Write(cmd, sizeof(cmd), true);
+    }
 
-	bool IsConnected() {
-		return m_IsConnected;
-	}
+    bool IsConnected() { return connected_; }
 };
 
-#endif  // BWSPIDIMMER_H_
+#endif // BWSPIDIMMER_H_

lib-device/include/bwspidio.h

@@ -2,7 +2,7 @@
  * @file bwspidio.h
  *
  */
-/* Copyright (C) 2020 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2020-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -30,34 +30,31 @@
 
 #include "bw.h"
 
-class BwSpiDio : BwSpi
-{
+class BwSpiDio : BwSpi {
    public:
-    explicit BwSpiDio(uint8_t nChipSelect = 0, uint8_t address = bw::dio::address) : BwSpi(nChipSelect, address, bw::dio::id_string) {}
+    explicit BwSpiDio(uint8_t chip_select = 0, uint8_t address = bw::dio::address) : BwSpi(chip_select, address, bw::dio::id_string) {}
 
-    void SetDirection(uint8_t nMask)
-    {
+    void SetDirection(uint8_t mask) {
         char cmd[3];
 
         cmd[0] = static_cast<char>(address_);
-        cmd[1] = bw::port::write::io_direction;
-        cmd[2] = static_cast<char>(nMask);
+        cmd[1] = bw::port::write::kIoDirection;
+        cmd[2] = static_cast<char>(mask);
 
-        HAL_SPI::Write(cmd, sizeof(cmd));
+        Spi::Write(cmd, sizeof(cmd), true);
     }
 
-    void Output(uint8_t nPins)
-    {
+    void Output(uint8_t pins) {
         char cmd[3];
 
         cmd[0] = static_cast<char>(address_);
-        cmd[1] = bw::port::write::set_all_outputs;
-        cmd[2] = static_cast<char>(nPins);
+        cmd[1] = bw::port::write::kSetAllOutputs;
+        cmd[2] = static_cast<char>(pins);
 
-        HAL_SPI::Write(cmd, sizeof(cmd));
+        Spi::Write(cmd, sizeof(cmd), true);
     }
 
-    bool IsConnected() { return m_IsConnected; }
+    bool IsConnected() { return connected_; }
 };
 
-#endif  // BWSPIDIO_H_
+#endif // BWSPIDIO_H_