Tighten ConfigStore debug logging flow

Removes redundant `CONFIGSTORE_DEBUG_ENTRY/EXIT` calls from `StoreDevice::Write` and `ConfigStore::Timer` to reduce noisy tracing. It also stops logging state at the start of `Flash()` and instead logs it when a write successfully transitions back to `kIdle`, so debug output reflects the meaningful state change.

Author: vanvught

lib-configstore/device/gd32/rom/storedevice.cpp

@@ -80,13 +80,9 @@ bool StoreDevice::Erase(uint32_t offset, uint32_t length, storedevice::Result& r
 }
 
 bool StoreDevice::Write(uint32_t offset, std::span<const uint8_t> buffer, storedevice::Result& result) {
-    CONFIGSTORE_DEBUG_ENTRY();
-
     flashcode::Result flashrom_result;
     const auto kState = FlashCode::Write(offset, buffer, flashrom_result);
 
     result = static_cast<storedevice::Result>(flashrom_result);
-
-    CONFIGSTORE_DEBUG_EXIT();
     return kState;
 }

lib-configstore/include/configstore.h

@@ -518,16 +518,12 @@ class ConfigStore : StoreDevice {
     }
 
     static void Timer([[maybe_unused]] TimerHandle_t timer_handle) {
-        CONFIGSTORE_DEBUG_ENTRY();
-
         if (!Instance().Commit()) {
             Instance().TimerStop();
 
             CONFIGSTORE_DEBUG_EXIT();
             return;
         }
-
-        CONFIGSTORE_DEBUG_EXIT();
     }
 
     void TimerStart() {
@@ -561,8 +557,6 @@ class ConfigStore : StoreDevice {
     }
 
     bool Flash() {
-        CONFIGSTORE_DEBUG_PUTS(kStateNames[static_cast<unsigned int>(s_state)]);
-
         if (__builtin_expect((s_state == State::kIdle), 1)) {
             return false;
         }
@@ -596,6 +590,7 @@ class ConfigStore : StoreDevice {
                 storedevice::Result result;
                 if (StoreDevice::Write(s_start_address, std::span{s_store}.first<sizeof(ConfigurationStore)>(), result)) {
                     s_state = State::kIdle;
+					CONFIGSTORE_DEBUG_PUTS(kStateNames[static_cast<unsigned int>(s_state)]);
                     return false;
                 }
                 assert(result == storedevice::Result::kOk);