Tighten GD32 type conversions

Use explicit casts and an underlying type for several GD32-facing enums and register reads to avoid implicit narrowing and signedness issues. This keeps ADC, backup, SPI bitbang, and FT245 data paths type-safe and warning-free.

Author: vanvught

lib-dmxnode/include/dmxnode.h

@@ -80,7 +80,7 @@ inline static constexpr const char kLtpUpper[] = "LTP";
 
 enum class Direction { kInput, kOutput, kDisable };
 
-enum class FailSafe { kHold, kOff, kOn, kPlayback, kRecord };
+enum class FailSafe : uint8_t { kHold, kOff, kOn, kPlayback, kRecord };
 
 namespace failsafe {
 inline static constexpr const char kHold[] = "hold";

lib-gd32/src/f/gd32_adc.cpp

@@ -23,7 +23,7 @@
  * THE SOFTWARE.
  */
 
-#include "gd32.h"
+#include "gd32.h" // IWYU pragma: keep
 #include "timing.h"
 
 void Gd32AdcInit() {
@@ -86,20 +86,20 @@ void Gd32AdcInit() {
 }
 
 float G32AdcGetTemp() {
-    const float kTemperature = (1.43f - ADC_IDATA0(ADC0) * 3.3f / 4096U) * 1000U / 4.3f + 25U;
+    const float kTemperature = (1.43f - static_cast<float>(ADC_IDATA0(ADC0)) * 3.3f / 4096U) * 1000U / 4.3f + 25U;
     adc_software_trigger_enable(ADC0, ADC_INSERTED_CHANNEL);
     return kTemperature;
 }
 
 float Gd32AdcGetVref() {
-    const float kVrefValue = (ADC_IDATA1(ADC0) * 3.3f / 4096U);
+    const float kVrefValue = static_cast<float>(ADC_IDATA1(ADC0)) * 3.3f / 4096U;
     adc_software_trigger_enable(ADC0, ADC_INSERTED_CHANNEL);
     return kVrefValue;
 }
 
 #if defined(GD32F4XX)
 float Gd32AdcGetVbat() {
-    const float kVrefValue = (ADC_IDATA2(ADC0) * 3.3f / 4096U) * 4U;
+    const float kVrefValue = (static_cast<float>(ADC_IDATA2(ADC0)) * 3.3f / 4096U) * 4U;
     adc_software_trigger_enable(ADC0, ADC_INSERTED_CHANNEL);
     return kVrefValue;
 }

lib-gd32/src/f/gd32_spi.cpp

@@ -265,7 +265,7 @@ static inline char BitbangSpiWriteRead(char c) {
         GPIO_BOP(SPI_BITBANG_SCK_GPIOx) = SPI_BITBANG_SCK_GPIO_PINx;
 
         if ((GPIO_ISTAT(SPI_BITBANG_MISO_GPIOx) & SPI_BITBANG_MISO_GPIO_PINx) == SPI_BITBANG_MISO_GPIO_PINx) {
-            r |= (mask);
+            r |= static_cast<char>(mask);
         }
 
         __ISB();

lib-gd32/src/gd32_bkp.cpp

@@ -44,10 +44,10 @@ void bkp_data_write(bkp_data_register_enum register_number, uint16_t data) {
 uint16_t bkp_data_read(bkp_data_register_enum register_number) {
     switch (register_number) {
         case BKP_DATA_0:
-            return RTC_BKP0;
+            return static_cast<uint16_t>(RTC_BKP0);
             break;
         case BKP_DATA_1:
-            return RTC_BKP1;
+            return static_cast<uint16_t>(RTC_BKP1);
             break;
         default:
             assert(false && "Invalid register_number");

lib-usb/src/gd32/ft245rl.cpp

@@ -155,15 +155,15 @@ uint8_t FT245RL_read_data()
     const auto kInGpioA = static_cast<uint16_t>(GPIO_ISTAT(GPIOA));
     const auto kInGpioB = static_cast<uint16_t>(GPIO_ISTAT(GPIOB));
 
-    data |= ((kInGpioA & (GPIO_PIN_6)) ? 4 : 0);
-    data |= ((kInGpioA & (GPIO_PIN_14)) ? 8 : 0);
-    data |= ((kInGpioA & (GPIO_PIN_15)) ? 16 : 0);
-
-    data |= ((kInGpioB & (GPIO_PIN_9)) ? 1 : 0);
-    data |= ((kInGpioB & (GPIO_PIN_8)) ? 2 : 0);
-    data |= ((kInGpioB & (GPIO_PIN_4)) ? 32 : 0);
-    data |= ((kInGpioB & (GPIO_PIN_5)) ? 64 : 0);
-    data |= ((kInGpioB & (GPIO_PIN_3)) ? 128 : 0);
+    data |= ((kInGpioA & (GPIO_PIN_6)) ? 4U : 0);
+    data |= ((kInGpioA & (GPIO_PIN_14)) ? 8U : 0);
+    data |= ((kInGpioA & (GPIO_PIN_15)) ? 16U : 0);
+
+    data |= ((kInGpioB & (GPIO_PIN_9)) ? 1U : 0);
+    data |= ((kInGpioB & (GPIO_PIN_8)) ? 2U : 0);
+    data |= ((kInGpioB & (GPIO_PIN_4)) ? 32U : 0);
+    data |= ((kInGpioB & (GPIO_PIN_5)) ? 64U : 0);
+    data |= ((kInGpioB & (GPIO_PIN_3)) ? 128U : 0);
 
     // Bring RD# back up so the FT245 can let go of the data.
     Gd32GpioSet(_RD);