Skip app jump when firmware image is empty

Add a check for an empty user image by reading the reset vector word at `FLASH_BASE + OFFSET_UIMAGE + 4` and requiring it to be valid before branching to the application. This prevents jumping into unprogrammed flash. The startup log now also reports the empty-image state (`Empty=Y/N`) alongside remote/key status.

Author: vanvught

bootloader-tftp/firmware/main.cpp

@@ -41,7 +41,7 @@
 
 namespace board {
 void RebootHandler() {}
-} // namespace board
+} // namespace hal
 
 int main() {
     rcu_periph_clock_enable(KEY_BOOTLOADER_TFTP_RCU_GPIOx);
@@ -66,13 +66,15 @@ int main() {
 
     const auto kIsNotRemote = (bkp_data_read(BKP_DATA_1) != 0xA5A5);
     const auto kIsNotKey = (gpio_input_bit_get(KEY_BOOTLOADER_TFTP_GPIOx, KEY_BOOTLOADER_TFTP_GPIO_PINx));
+    const uint32_t* reset_p = reinterpret_cast<uint32_t*>(FLASH_BASE + OFFSET_UIMAGE + 4);
+    const auto kIsEmpty = (*reset_p == UINT32_MAX);
 
-    if (kIsNotRemote && kIsNotKey) {
+    if (kIsNotRemote && kIsNotKey && !kIsEmpty) {
         // https://developer.arm.com/documentation/ka001423/1-0
         // 1. Disable interrupt response.
         __disable_irq();
         // 2. Disable all enabled interrupts in NVIC.
-        for (auto& reg : NVIC->ICER) {
+                for (auto& reg : NVIC->ICER) {
             reg = 0xFFFFFFFF;
         }
         /* 3. Disable all enabled peripherals which might generate interrupt requests.
@@ -81,7 +83,7 @@ int main() {
          */
 
         /* Clear all pending interrupt requests in NVIC. */
-        for (auto& reg : NVIC->ICPR) {
+                for (auto& reg : NVIC->ICPR) {
             reg = 0xFFFFFFFF;
         }
         // 4. Disable SysTick and clear its exception pending bit.
@@ -97,7 +99,6 @@ int main() {
         // 7. Enable interrupts.
         __enable_irq();
         // 8. Call the reset handler
-        const uint32_t* reset_p = reinterpret_cast<uint32_t*>(FLASH_BASE + OFFSET_UIMAGE + 4);
         asm volatile("bx %0;" : : "r"(*reset_p));
     }
 
@@ -108,7 +109,7 @@ int main() {
     FirmwareVersion fw(kSoftwareVersion, __DATE__, __TIME__);
     FlashCodeInstall flashcode_install;
 
-    printf("Remote=%c, Key=%c\n", kIsNotRemote ? 'N' : 'Y', kIsNotKey ? 'N' : 'Y');
+    printf("Remote=%c, Key=%c, Empty=%c\n", kIsNotRemote ? 'N' : 'Y', kIsNotKey ? 'N' : 'Y', kIsEmpty ? 'Y' : 'N');
     fw.Print("Bootloader TFTP Server");
 
     RemoteConfig remote_config(remoteconfig::Output::CONFIG);