gd32: fix warnings, include paths, style updates

Add compiler warning suppressions (Gd32FirmwareOps.mk) and switch GD32 include handling to -isystem in Includes.mk; reorder and simplify include list. Remove diagnostic pragma blocks from gd32xxxx.h and add GD32F30X_XD support. Simplify TIMER_INTF clears (remove explicit static_casts) across DMX, timer and softuart code and add IRQ mapping for GD32F30X_XD. Refactor pixel output code: modernize BIT_SET/BIT_CLEAR to use reinterpret_cast, adjust buffer/dma pointer, and apply general formatting/brace/style cleanups and minor control-flow clarifications in PixelDmxMulti.

Author: vanvught

common/make/gd32/Gd32FirmwareOps.mk

@@ -0,0 +1,3 @@
+$(info "Gd32FirmwareOpts.mk")
+
+GD32FIRMWAREOPS=-Wno-error=unused-parameter -Wno-error=unused-but-set-variable -Wno-error=conversion -Wno-error=old-style-cast

common/make/gd32/Includes.mk

@@ -1,13 +1,14 @@
 $(info "Includes.mk")
 
-INCLUDES:=-I./include 
-INCLUDES+=-I../common/include -I../include 
-INCLUDES+=-I../firmware-template-gd32/include
-INCLUDES+=-I../CMSIS/Core/Include
-INCLUDES+=-I../lib-gd32/${FAMILY}/${FAMILY_UC}_standard_peripheral/Include
-INCLUDES+=-I../lib-gd32/${FAMILY}/CMSIS/GD/${FAMILY_UC}/Include
-INCLUDES+=-I../lib-gd32/include
+INCLUDES:=-I../include
+INCLUDES+=-isystem ../CMSIS/Core/Include
+INCLUDES+=-isystem ../lib-gd32/${FAMILY}/${FAMILY_UC}_standard_peripheral/Include
+INCLUDES+=-isystem ../lib-gd32/${FAMILY}/CMSIS/GD/${FAMILY_UC}/Include
+INCLUDES+=-isystem ../lib-gd32/include
+INCLUDES+=-isystem ../firmware-template-gd32/include
+INCLUDES+=-I../common/include
 INCLUDES+=-I../lib-hwclock/include
+INCLUDES+=-I./include
 
 INCLUDES+=$(addprefix -I,$(EXTRA_INCLUDES))
 
@@ -104,5 +105,5 @@ ifdef USB_HOST_MSC
 		INCLUDES+=-I../lib-fatfs
 endif
 
-INCLUDES:= $(strip -I../${PROJECT}/include $(sort $(INCLUDES)))
+#INCLUDES:= $(strip -I../${PROJECT}/include $(sort $(INCLUDES)))
 $(info $$INCLUDES [${INCLUDES}])

lib-dmx/src/gd32/dmx.cpp

@@ -494,7 +494,7 @@ void TIMER1_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER1) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH0);
+        TIMER_INTF(TIMER1) = (~TIMER_INT_FLAG_CH0);
     }
 #endif // defined(DMX_USE_USART0)
 // USART 1
@@ -561,7 +561,7 @@ void TIMER1_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER1) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH1);
+        TIMER_INTF(TIMER1) = (~TIMER_INT_FLAG_CH1);
     }
 #endif // defined(DMX_USE_USART1)
 // USART 2
@@ -629,7 +629,7 @@ void TIMER1_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER1) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH2);
+        TIMER_INTF(TIMER1) = (~TIMER_INT_FLAG_CH2);
     }
 #endif // defined(DMX_USE_USART2)
 // UART 3
@@ -695,7 +695,7 @@ void TIMER1_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER1) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH3);
+        TIMER_INTF(TIMER1) = (~TIMER_INT_FLAG_CH3);
     }
 #endif // defined(DMX_USE_UART3)
     // Clear all remaining interrupt flags (safety measure)
@@ -770,7 +770,7 @@ void TIMER4_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER4) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH0);
+        TIMER_INTF(TIMER4) = (~TIMER_INT_FLAG_CH0);
     }
 #endif // defined(DMX_USE_UART4)
 // USART 5
@@ -839,7 +839,7 @@ void TIMER4_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER4) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH1);
+        TIMER_INTF(TIMER4) = (~TIMER_INT_FLAG_CH1);
     }
 #endif // defined(DMX_USE_USART5)
 // UART 6
@@ -898,7 +898,7 @@ void TIMER4_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER4) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH2);
+        TIMER_INTF(TIMER4) = (~TIMER_INT_FLAG_CH2);
     }
 #endif // defined(DMX_USE_UART6)
 // UART 7
@@ -957,7 +957,7 @@ void TIMER4_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER4) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH3);
+        TIMER_INTF(TIMER4) = (~TIMER_INT_FLAG_CH3);
     }
 #endif // defined(DMX_USE_UART7)
     // Clear all remaining interrupt flags (safety measure)
@@ -979,7 +979,7 @@ void TIMER6_IRQHandler() {
     }
 
     // Clear all remaining interrupt flags (safety measure)
-    TIMER_INTF(TIMER6) = static_cast<uint32_t>(~kIntFlag);
+    TIMER_INTF(TIMER6) = (~kIntFlag);
 }
 
 // USART 0

lib-gd32/include/gd32xxxx.h

@@ -26,26 +26,11 @@
 #ifndef GD32FXXX_H_
 #define GD32FXXX_H_
 
-// Needed for GD32 Firmware and CMSIS
-
-#ifdef __cplusplus
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wuseless-cast"
-#pragma GCC diagnostic ignored "-Wold-style-cast"
-#pragma GCC diagnostic ignored "-Wconversion"
-#pragma GCC diagnostic ignored "-Wsign-conversion"
-#if __cplusplus > 201402
-// error: compound assignment with 'volatile'-qualified left operand is
-// deprecated
-#pragma GCC diagnostic ignored "-Wvolatile"
-#endif
-#endif
-
 #if defined(GD32F10X_HD) || defined(GD32F10X_CL)
 #include "gd32f10x.h" // IWYU pragma: keep
 #elif defined(GD32F20X_CL)
 #include "gd32f20x.h" // IWYU pragma: keep
-#elif defined(GD32F30X_HD)
+#elif defined(GD32F30X_HD) || defined(GD32F30X_XD)
 #include "gd32f30x.h" // IWYU pragma: keep
 #elif defined(GD32F407) || defined(GD32F450) || defined(GD32F470)
 #include "gd32f4xx.h" // IWYU pragma: keep
@@ -56,8 +41,4 @@
 #error MCU is not supported
 #endif
 
-#ifdef __cplusplus
-#pragma GCC diagnostic pop
-#endif
-
 #endif // GD32FXXX_H_ */

lib-gd32/src/softuart0/uart0.cpp

@@ -35,8 +35,13 @@
 #elif defined(GD32F30X)
 #define TIMERx            TIMER7
 #define RCU_TIMERx        RCU_TIMER7
+#if defined (GD32F30X_XD)
+#define TIMERx_IRQHandler TIMER7_UP_TIMER12_IRQHandler
+#define TIMERx_IRQn       TIMER7_UP_TIMER12_IRQn
+#else
 #define TIMERx_IRQHandler TIMER7_UP_IRQHandler
 #define TIMERx_IRQn       TIMER7_UP_IRQn
+#endif
 #else
 #define TIMERx            TIMER9
 #define RCU_TIMERx        RCU_TIMER9
@@ -147,7 +152,7 @@ void TIMERx_IRQHandler() {
         }
     }
 
-    TIMER_INTF(TIMERx) = static_cast<uint32_t>(~kIntFlag);
+    TIMER_INTF(TIMERx) = ~kIntFlag;
 }
 #if defined(SOFTUART0_ENABLE_RX)
 void SOFTUART_RX_EXTIx_IRQHandler() {

lib-gd32/src/timer6.cpp

@@ -41,7 +41,7 @@ void TIMER6_IRQHandler() {
         gv_seconds.uptime = gv_seconds.uptime + 1;
     }
 
-    TIMER_INTF(TIMER6) = static_cast<uint32_t>(~kIntFlag);
+    TIMER_INTF(TIMER6) = ~kIntFlag;
 }
 #endif
 }