ArtNet: update poll reply & DMA handling

efactor ArtNet poll reply handling and improve DMA memcpy behavior across GD32 targets. Key changes:
- Simplify ArtNetNode::ProcessPollReply signature (removed out parameters) and adjust SendPollReply to call it directly. Set NumPortsLo and PortTypes appropriately and add early return for disabled ports. Rework poll_reply_count and CreateNodeReport ordering to ensure correct reporting and reset behavior.
- Update printing and formatting minor cleanups in ArtNetNode (line-wrapping and spacing fixes).
- Add conditional alignment assertions and IRQ handling in dma::memcpy32: different checks for GD32F4XX, optional compile-time disabling of DMA IRQs (DMA_MEMCPY32_DISABLE_IRQ), and related IRQ setup/teardown fixes. Remove unused include in dma file.
- Update PixelOutputMulti to support synchronous DMA mode when DMA_MEMCPY32_DISABLE_IRQ is defined (start DMA, wait for completion, then enable timers). Guard IRQ handlers with the same macro and remove an unnecessary pragma/NDEBUG tweaks.
- Miscellaneous: update copyright years in several headers/sources, rename node type string to "Art-Net", reformat dmxnode output type names array, and add missing debug include in pixeldmxparams.cpp.
These changes fix poll reply composition, add safer DMA alignment and optional IRQ-less DMA operation, and tidy up formatting and metadata.

Author: vanvught

lib-artnet/include/artnetnode.h

@@ -2,7 +2,7 @@
  * @file artnetnode.h
  *
  */
-/* Copyright (C) 2016-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2016-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -395,7 +395,7 @@ class ArtNetNode
     void UpdateMergeStatus(uint32_t port_index);
     void CheckMergeTimeouts(uint32_t port_index);
 
-    void ProcessPollReply(uint32_t port_index, uint32_t& num_ports_input, uint32_t& num_ports_output);
+    void ProcessPollReply(uint32_t port_index);
     void SendPollReply(uint32_t port_index, uint32_t destination_ip, artnet::ArtPollQueue* poll_queue = nullptr);
 
     void SendTodRequest(uint32_t port_index);

lib-artnet/src/node/artnetnode.cpp

@@ -84,7 +84,7 @@ ArtNetNode::ArtNetNode()
     art_poll_reply_.Oem = ArtNetConst::kOemId[1];
     art_poll_reply_.EstaMan[0] = ArtNetConst::kEstaId[1];
     art_poll_reply_.EstaMan[1] = ArtNetConst::kEstaId[0];
-     network::iface::CopyMacAddressTo(art_poll_reply_.MAC);
+    network::iface::CopyMacAddressTo(art_poll_reply_.MAC);
 #if (ARTNET_VERSION >= 4)
     art_poll_reply_.AcnPriority = e131::priority::kDefault;
 #endif
@@ -165,9 +165,9 @@ void ArtNetNode::Start()
     art_poll_reply_.Status2 |=
         artnet::Status2::kPortAddress15Bit | (artnet::kVersion >= 4 ? artnet::Status2::kSacnAbleToSwitch : artnet::Status2::kSacnNoSwitch);
     art_poll_reply_.Status2 &= static_cast<uint8_t>(~artnet::Status2::kIpDhcp);
-    art_poll_reply_.Status2 |=  network::iface::Dhcp() ? artnet::Status2::kIpDhcp : artnet::Status2::kIpManualy;
+    art_poll_reply_.Status2 |= network::iface::Dhcp() ? artnet::Status2::kIpDhcp : artnet::Status2::kIpManualy;
     art_poll_reply_.Status2 &= static_cast<uint8_t>(~artnet::Status2::kDhcpCapable);
-    art_poll_reply_.Status2 |=  network::iface::IsDhcpCapable() ? artnet::Status2::kDhcpCapable : static_cast<uint8_t>(0);
+    art_poll_reply_.Status2 |= network::iface::IsDhcpCapable() ? artnet::Status2::kDhcpCapable : static_cast<uint8_t>(0);
 #if defined(ENABLE_HTTPD) && defined(ENABLE_CONTENT)
     art_poll_reply_.Status2 |= artnet::Status2::kWebBrowserSupport;
 #endif
@@ -738,7 +738,8 @@ void ArtNetNode::Print()
                 printf("  Port %-2u %-4u", static_cast<unsigned int>(port_index), static_cast<unsigned int>(kUniverse));
                 if (node_.port[port_index].protocol == artnet::PortProtocol::kArtnet)
                 {
-                    const auto kDestinationIp = (input_port_[port_index].destination_ip == 0 ? network::GetBroadcastIp() : input_port_[port_index].destination_ip);
+                    const auto kDestinationIp =
+                        (input_port_[port_index].destination_ip == 0 ? network::GetBroadcastIp() : input_port_[port_index].destination_ip);
                     printf(" -> " IPSTR, IP2STR(kDestinationIp));
                 }
 #if (ARTNET_VERSION >= 4)

lib-artnet/src/node/artnetnodehandlepoll.cpp

@@ -42,7 +42,7 @@
 #include "artnet.h"
 #include "hal_millis.h"
 #include "network.h"
- #include "firmware/debug/debug_debug.h"
+#include "firmware/debug/debug_debug.h"
 
 template <uint8_t N> static inline void Uitoa(uint32_t v, uint8_t* p)
 {
@@ -141,7 +141,7 @@ union uip
     uint8_t u8[4];
 } static ip;
 
-void ArtNetNode::ProcessPollReply(uint32_t port_index, [[maybe_unused]] uint32_t& num_ports_input, uint32_t& num_ports_output)
+void ArtNetNode::ProcessPollReply(uint32_t port_index)
 {
     if (node_.port[port_index].direction == dmxnode::PortDirection::kOutput)
     {
@@ -155,13 +155,11 @@ void ArtNetNode::ProcessPollReply(uint32_t port_index, [[maybe_unused]] uint32_t
             output_port_[port_index].good_output = good_output;
         }
 #endif
-        art_poll_reply_.PortTypes[0] = artnet::PortType::kOutputArtnet;
         art_poll_reply_.GoodOutput[0] = output_port_[port_index].good_output;
         art_poll_reply_.GoodOutputB[0] = output_port_[port_index].good_output_b;
         art_poll_reply_.GoodInput[0] = 0;
         art_poll_reply_.SwOut[0] = node_.port[port_index].sw;
         art_poll_reply_.SwIn[0] = 0;
-        num_ports_output = 1;
         DEBUG_EXIT();
         return;
     }
@@ -175,24 +173,24 @@ void ArtNetNode::ProcessPollReply(uint32_t port_index, [[maybe_unused]] uint32_t
             input_port_[port_index].good_input |= artnet::GoodInput::kInputIsSacn;
         }
 #endif
-        art_poll_reply_.PortTypes[0] = artnet::PortType::kInputArtnet;
         art_poll_reply_.GoodOutput[0] = 0;
         art_poll_reply_.GoodOutputB[0] = 0;
         art_poll_reply_.GoodInput[0] = input_port_[port_index].good_input;
         art_poll_reply_.SwOut[0] = 0;
         art_poll_reply_.SwIn[0] = node_.port[port_index].sw;
-        num_ports_input = 1;
         DEBUG_EXIT();
         return;
     }
 #endif
-
-    num_ports_output = 0;
-    num_ports_input = 0;
 }
 
 void ArtNetNode::SendPollReply(uint32_t port_index, uint32_t destination_ip, artnet::ArtPollQueue* queue)
 {
+    if (node_.port[port_index].direction == dmxnode::PortDirection::kDisable)
+    {
+        return;
+    }
+
     ip.u32 = network::GetPrimaryIp();
     memcpy(art_poll_reply_.IPAddress, ip.u8, sizeof(art_poll_reply_.IPAddress));
 #if (ARTNET_VERSION >= 4)
@@ -213,6 +211,12 @@ void ArtNetNode::SendPollReply(uint32_t port_index, uint32_t destination_ip, art
     art_poll_reply_.NetSwitch = node_.port[port_index].net_switch;
     art_poll_reply_.SubSwitch = node_.port[port_index].sub_switch;
     art_poll_reply_.bind_index = static_cast<uint8_t>(port_index + 1);
+    art_poll_reply_.NumPortsLo = 1;
+#if defined(ARTNET_HAVE_DMXIN)
+    art_poll_reply_.PortTypes[0] = artnet::PortType::kOutputArtnet | artnet::PortType::kInputArtnet;
+#else
+    art_poll_reply_.PortTypes[0] = artnet::PortType::kOutputArtnet;
+#endif
 
     const auto* shortname = DmxNode::Instance().GetShortName(port_index);
     memcpy(art_poll_reply_.ShortName, shortname, artnet::kShortNameLength);
@@ -227,24 +231,17 @@ void ArtNetNode::SendPollReply(uint32_t port_index, uint32_t destination_ip, art
         art_poll_reply_.UserHi = static_cast<uint8_t>(kUserData >> 8);
     }
 
-    uint32_t ports_output = 0;
-    uint32_t ports_input = 0;
-    ProcessPollReply(port_index, ports_input, ports_output);
-
-    art_poll_reply_.NumPortsLo = ports_input | ports_output;
+    ProcessPollReply(port_index);
 
-    if (art_poll_reply_.NumPortsLo != 0)
+    state_.art.poll_reply_count++;
+    if (state_.art.poll_reply_count == 10000)
     {
-        state_.art.poll_reply_count++;
-        if (state_.art.poll_reply_count == 10000)
-        {
-            state_.art.poll_reply_count = 0;
-        }
-
-        CreateNodeReport(art_poll_reply_.NodeReport, state_.report_code, state_.art.poll_reply_count);
-        network::udp::Send(handle_, reinterpret_cast<const uint8_t*>(&art_poll_reply_), sizeof(artnet::ArtPollReply), destination_ip, artnet::kUdpPort);
+        state_.art.poll_reply_count = 0;
     }
 
+    CreateNodeReport(art_poll_reply_.NodeReport, state_.report_code, state_.art.poll_reply_count);
+    network::udp::Send(handle_, reinterpret_cast<const uint8_t*>(&art_poll_reply_), sizeof(artnet::ArtPollReply), destination_ip, artnet::kUdpPort);
+
     state_.is_changed = false;
 }
 

lib-dmxnode/include/dmxnode_nodetype.h

@@ -47,7 +47,7 @@ enum class NodeType
 
 inline constexpr const char* kNodeTypeNames[static_cast<uint32_t>(NodeType::kUndefined)] = 
 {
-	"Artnet",    
+	"Art-Net",    
 	"sACN E1.31", 
 	"DDP Display", 
 	"PixelPusher",

lib-dmxnode/include/dmxnode_outputtype.h

@@ -1,7 +1,7 @@
 /**
  * @file dmxnode_outputtype.h
  */
-/* Copyright (C) 2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2025-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -21,12 +21,11 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
- 
 
 #ifndef DMXNODE_OUTPUTTYPE_H_
 #define DMXNODE_OUTPUTTYPE_H_
 
- #include <cstdint>
+#include <cstdint>
 
 namespace dmxnode
 {
@@ -49,23 +48,8 @@ enum class OutputType
     kUndefined
 };
 
-inline constexpr const char* kOutputTypeNames[static_cast<uint32_t>(OutputType::kUndefined)] = 
-{
-	"DMX", 
-	"DMX/RDM", 
-	"Pixel",
-	"Pixel/DMX", 
-	"PWM", 
-	"RGB Panel", 
-	"Serial", 
-	"OSC", 
-	"Monitor", 
-	"Stepper", 
-	"Player", 
-	"Art-Net", 
-	"Timecode",
-	"None"
-};
+inline constexpr const char* kOutputTypeNames[static_cast<uint32_t>(OutputType::kUndefined)] = {
+    "DMX", "DMX/RDM", "Pixel", "Pixel/DMX", "PWM", "RGB Panel", "Serial", "OSC", "Monitor", "Stepper", "Player", "Art-Net", "Timecode", "None"};
 
 inline const char* GetOutputType(OutputType type)
 {
@@ -76,7 +60,7 @@ inline const char* GetOutputType(OutputType type)
 
     return "Undefined";
 }
-}  // namespace dmxnode
+} // namespace dmxnode
 
 #if defined(OUTPUT_DMX_SEND) || defined(OUTPUT_DMX_SEND_MULTI)
 #define DMXNODE_OUTPUT_DMX
@@ -195,4 +179,4 @@ inline constexpr auto kOutputType = OutputType::kUndefined;
 #endif
 } // namespace dmxnode
 
-#endif  // DMXNODE_OUTPUTTYPE_H_
+#endif // DMXNODE_OUTPUTTYPE_H_

lib-gd32/include/gd32_dma_memcpy32.h

@@ -2,7 +2,7 @@
  * @file gd32_dma_memcpy32.h
  *
  */
-/* Copyright (C) 2024-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2024-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -37,10 +37,10 @@ void Init();
 
 inline void StartDma(const void* destination, const void* source, uint32_t length)
 {
+#if !defined(GD32F4XX)
     assert((reinterpret_cast<uint32_t>(source) & 0x3) == 0);
     assert((reinterpret_cast<uint32_t>(destination) & 0x3) == 0);
 
-#if !defined(GD32F4XX)
     uint32_t dma_chctl = DMA_CHCTL(DMA0, DMA_CH3);
     dma_chctl &= ~DMA_CHXCTL_CHEN;
     DMA_CHCTL(DMA0, DMA_CH3) = dma_chctl;
@@ -52,6 +52,9 @@ inline void StartDma(const void* destination, const void* source, uint32_t lengt
     dma_chctl |= (DMA_CHXCTL_CHEN | DMA_INT_FTF);
     DMA_CHCTL(DMA0, DMA_CH3) = dma_chctl;
 #else
+    assert((reinterpret_cast<uint32_t>(source) & 0xF) == 0);
+    assert((reinterpret_cast<uint32_t>(destination) & 0xF) == 0);
+
     uint32_t dma_chctl = DMA_CHCTL(DMA1, DMA_CH0);
     dma_chctl &= ~DMA_CHXCTL_CHEN;
     DMA_CHCTL(DMA1, DMA_CH0) = dma_chctl;

lib-gd32/src/f/gd32_dma_memcpy32.cpp

@@ -2,7 +2,7 @@
  * @file gd32_dma_memcpy32.cpp
  *
  */
-/* Copyright (C) 2024-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2024-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -23,7 +23,6 @@
  * THE SOFTWARE.
  */
 
-#include "gd32.h"
 #include "gd32_dma.h"
 
 namespace dma::memcpy32
@@ -49,10 +48,12 @@ void Init()
     dma_circulation_disable(DMA0, DMA_CH3);
     dma_memory_to_memory_enable(DMA0, DMA_CH3);
 
+#if !defined(DMA_MEMCPY32_DISABLE_IRQ)
     Gd32DmaInterruptFlagClear<DMA0, DMA_CH3, (DMA_INT_FLAG_FTF | DMA_INT_FLAG_G)>();
 
     NVIC_SetPriority(DMA0_Channel3_IRQn, 0);
     NVIC_EnableIRQ(DMA0_Channel3_IRQn);
+#endif
 #else
     rcu_periph_clock_enable(RCU_DMA1);
     dma_deinit(DMA1, DMA_CH0);
@@ -73,10 +74,12 @@ void Init()
 
     dma_multi_data_mode_init(DMA1, DMA_CH0, &dma_init_parameter);
 
-    Gd32DmaInterruptFlagClear<DMA1, DMA_CH3, (DMA_INT_FLAG_FTF | DMA_INT_FLAG_TAE)>();
+#if !defined(DMA_MEMCPY32_DISABLE_IRQ)
+    Gd32DmaInterruptFlagClear<DMA1, DMA_CH0, (DMA_INT_FLAG_FTF | DMA_INT_FLAG_TAE)>();
 
     NVIC_SetPriority(DMA1_Channel0_IRQn, 0);
     NVIC_EnableIRQ(DMA1_Channel0_IRQn);
 #endif
+#endif
 }
 } // namespace dma::memcpy32

lib-pixel/src/gd32/gpio/pixeloutputmulti.cpp

@@ -1,7 +1,7 @@
 /**
  * @file pixeloutputmulti.cpp
  */
-/* Copyright (C) 2021-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2021-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -21,8 +21,6 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
- 
- #undef NDEBUG
 
 #if defined(DEBUG_PIXEL)
 #undef NDEBUG
@@ -680,7 +678,6 @@ void PixelOutputMulti::FullOn()
 
 #pragma GCC push_options
 #pragma GCC optimize("O3")
-#pragma GCC optimize("no-tree-loop-distribute-patterns")
 
 void PixelOutputMulti::Update()
 {
@@ -701,6 +698,10 @@ void PixelOutputMulti::Update()
     TIMER_CTL0(TIMER2) = timer2_ctl0;
     TIMER_CNT(TIMER2) = 0;
 
+#if defined(DMA_MEMCPY32_DISABLE_IRQ)
+    dma::memcpy32::StartDma(reinterpret_cast<uint8_t*>(s_pixel_buffer_dma), reinterpret_cast<uint8_t*>(s_pixel_buffer_data), buffer_size_ / 2);
+#endif
+
     const auto& pixel_configuration = PixelConfiguration::Get();
 
     if (pixel_configuration.IsRTZProtocol())
@@ -757,7 +758,16 @@ void PixelOutputMulti::Update()
         TIMER_DMAINTEN(TIMER2) |= (TIMER_DMA_CH2D | TIMER_DMA_CH3D);
     }
 
+#if defined(DMA_MEMCPY32_DISABLE_IRQ)
+    while (dma::memcpy32::IsActive())
+    {
+    }
+
+    TIMER_CTL0(TIMER3) |= TIMER_CTL0_CEN;
+    TIMER_CTL0(TIMER2) |= TIMER_CTL0_CEN;
+#else
     dma::memcpy32::StartDma(reinterpret_cast<uint8_t*>(s_pixel_buffer_dma), reinterpret_cast<uint8_t*>(s_pixel_buffer_data), buffer_size_ / 2);
+#endif
 
 #ifndef NDEBUG
     GPIO_BC(DEBUG_CS_GPIOx) = DEBUG_CS_GPIO_PINx;
@@ -801,6 +811,7 @@ extern "C"
         TIMER_INTF(TIMER10) = ~kIntFlag;
     }
 
+#if !defined(DMA_MEMCPY32_DISABLE_IRQ)
 #if !defined(GD32F4XX)
     void DMA0_Channel3_IRQHandler()
     { // DMX memcpy ready
@@ -828,4 +839,5 @@ extern "C"
         Gd32DmaInterruptFlagClear<DMA1, DMA_CH0, (DMA_INT_FLAG_FTF | DMA_INT_FLAG_TAE)>();
     }
 #endif
+#endif
 }

lib-pixeldmx/src/json/pixeldmxparams.cpp

@@ -22,7 +22,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
-
+ 
 #include <cstdint>
 #include <algorithm>
 
@@ -44,6 +44,7 @@
 #include "dmxnode.h"
 #include "dmxnode_nodetype.h"
 #include "pixeltestpattern.h"
+#include "firmware/debug/debug_debug.h"
 
 static constexpr uint32_t kConfigMaxPorts = CONFIG_DMXNODE_PIXEL_MAX_PORTS;