Auto-flag Timer6 IRQ and print stack at init

Update GD32 validation to mark when Timer6 IRQ is required by DMX/RDM/LTC features and automatically add `CONFIG_TIMER6_HAVE_NO_IRQ_HANDLER` otherwise, while still erroring on conflicting manual flags. In board initialization, always include and run I2C detect plus stack debug printing to improve startup diagnostics.

Author: vanvught

common/make/gd32/Validate.mk

@@ -12,11 +12,16 @@ ifneq ($(findstring _TIME_STAMP_YEAR_,$(FLAGS)),_TIME_STAMP_YEAR_)
 endif
 
 ifneq (,$(findstring OUTPUT_DMX_SEND,$(FLAGS))$(findstring CONFIG_RDM,$(FLAGS))$(findstring RDM_CONTROLLER,$(FLAGS))$(findstring LTC,$(FLAGS)))
+	TIMER6_HAVE_IRQ_HANDLER=1
 	ifneq (,$(findstring CONFIG_TIMER6_HAVE_NO_IRQ_HANDLER,$(MAKE_FLAGS)))
 		$(error CONFIG_TIMER6_HAVE_NO_IRQ_HANDLER is set)
 	endif
 endif
 
+ifndef TIMER6_HAVE_IRQ_HANDLER
+	DEFINES+=-DCONFIG_TIMER6_HAVE_NO_IRQ_HANDLER
+endif
+
 ifeq ($(findstring CONFIG_REMOTECONFIG_MINIMUM,$(FLAGS)),CONFIG_REMOTECONFIG_MINIMUM)
 	DEFINES+=-DCONFIG_NET_APPS_NO_MDNS
 else

lib-board/src/gd32/board_init.cpp

@@ -23,6 +23,7 @@
  * THE SOFTWARE.
  */
 
+#include "firmware/debug/debug_stack.h"
 #if !defined(_TIME_STAMP_DAY_)
 #define _TIME_STAMP_DAY_ 0
 #endif
@@ -62,9 +63,7 @@
 #if defined(ENABLE_USB_HOST)
 #include "device/usb.h"
 #endif
-#if defined(DEBUG_I2C)
 #include "firmware/debug/debug_i2cdetect.h"
-#endif
 #include "board_statusled.h"
 #include "panelled.h"
 #include "logic_analyzer.h"
@@ -260,12 +259,12 @@ void Init() {
 #endif
 #endif
 
-#if defined(DEBUG_I2C)
     debug::i2c::Detect();
-#endif
 
 #if !defined(USE_FREE_RTOS)
     board::statusled::SetFrequency(1);
 #endif
+
+    debug::stack::Print();
 }
 } // namespace board

lib-network/src/emac/gd32/emac_phy.cpp

@@ -159,7 +159,7 @@ bool Config(uint16_t address) {
         }
 
         if (!(value & emac::mmi::BMCR_RESET)) {
-            EMAC_PHY_DEBUG_PRINTF("%u", static_cast<unsigned>(millis() - kMillis));
+            EMAC_PHY_DEBUG_PRINTF("%u", static_cast<unsigned>(gd32::Millis() - kMillis));
             EMAC_PHY_DEBUG_EXIT();
             return true;
         }
@@ -171,7 +171,7 @@ bool Config(uint16_t address) {
         return false;
     }
 
-    EMAC_PHY_DEBUG_PRINTF("%u", static_cast<unsigned>(millis() - kMillis));
+    EMAC_PHY_DEBUG_PRINTF("%u", static_cast<unsigned>(gd32::Millis() - kMillis));
     EMAC_PHY_DEBUG_EXIT();
     return true;
 }

lib-network/src/emac/phy/emac_phy.cpp

@@ -166,12 +166,17 @@ static bool UpdateLink(uint16_t address, Status& phy_status) {
         puts("Waiting for PHY auto negotiation to complete");
 
         const auto kMillis = timing::Millis();
+
         while (!(bmsr & mmi::BMSR_AUTONEGO_COMPLETE)) {
             if ((timing::Millis() - kMillis) > 5000) {
                 EMAC_PHY_DEBUG_EXIT();
                 return false;
             }
-            phy::Read(address, mmi::REG_BMSR, bmsr);
+
+            if (!phy::Read(address, mmi::REG_BMSR, bmsr)) {
+                EMAC_PHY_DEBUG_EXIT();
+                return false;
+            }
         }
 
         phy_status.link = Link::kStateUp;