Unify undefined labels and JSON guards

Adds a shared `common::kUndefined` string and replaces scattered literal "Undefined" fallbacks across DMX, RDM, LTC, and MIDI-related code. The remote config JSON endpoints now enforce non-null/non-zero output buffers with assertions, and several small consistency cleanups were applied (macro style `#ifdef`, Art-Net node ID print usage, and minor formatting/log message tidy-ups).

Author: vanvught

common/include/common/utils/utils_string.h

@@ -33,6 +33,7 @@ inline constexpr char kWarning[] = "Warning";
 inline constexpr char kError[] = "Error";
 inline constexpr char kSuccess[] = "Success";
 inline constexpr char kUnknown[] = "Unknown"; 
+inline constexpr char kUndefined[] = "Undefined";
 
 constexpr const char* IsSuccess(bool is_success) {
   return is_success ? kSuccess : kError;

lib-artnet/include/artnet.h

@@ -38,7 +38,7 @@ inline constexpr uint32_t kNetSwitch = 0;
 inline constexpr uint32_t kSubnetSwitch = 0;
 inline constexpr uint32_t kSwitch = 1;
 } // namespace defaults
-#if !defined(ARTNET_VERSION)
+#ifndef ARTNET_VERSION
 inline constexpr uint32_t kVersion = 4;
 #else
 inline constexpr uint32_t kVersion = ARTNET_VERSION;

lib-artnet/src/node/artnetnode.cpp

@@ -642,9 +642,9 @@ void ArtNetNode::SetNetworkDataLossCondition() {
 }
 
 void ArtNetNode::Print() {
-    printf("Art-Net %u V%u.%u\n", static_cast<unsigned int>(artnet::kVersion), static_cast<unsigned int>(ArtNetConst::kVersion[0]), static_cast<unsigned int>(ArtNetConst::kVersion[1]));
+    printf("%s %u V%u.%u\n", artnet::kNodeId, static_cast<unsigned int>(artnet::kVersion), static_cast<unsigned int>(ArtNetConst::kVersion[0]), static_cast<unsigned int>(ArtNetConst::kVersion[1]));
     printf(" Long name  : %s\n", reinterpret_cast<char*>(art_poll_reply_.long_name));
-#if defined(ARTNET_HAVE_TIMECODE)
+#ifdef ARTNET_HAVE_TIMECODE
     printf(" TimeCode IP: " IPSTR "\n", IP2STR(node_.ip_timecode));
 #endif
 

lib-displayudf/src/artnet/displayudfshowartnet.cpp

@@ -40,7 +40,7 @@ void DisplayUdf::ShowArtNetNode() {
     auto* artnet_node = ArtNetNode::Get();
 
     ShowUniverseArtNetNode();
-#if defined(ARTNET_HAVE_DMXIN)
+#ifdef ARTNET_HAVE_DMXIN
     ShowDestinationIpArtNetNode();
 #endif
     Printf(labels_[static_cast<uint32_t>(displayudf::Labels::kAp)], "AP: %d", artnet_node->GetActiveOutputPorts() + artnet_node->GetActiveInputPorts());
@@ -49,7 +49,7 @@ void DisplayUdf::ShowArtNetNode() {
 }
 
 void DisplayUdf::ShowUniverseArtNetNode() {
-#if defined(DMX_MAX_PORTS)
+#ifdef DMX_MAX_PORTS
     DISPLAYUDF_DEBUG_ENTRY();
     if constexpr (dmxnode::kConfigPortCount != 0) {
         auto* artnet_node = ArtNetNode::Get();
@@ -68,18 +68,19 @@ void DisplayUdf::ShowUniverseArtNetNode() {
                 if (artnet_node->GetPortAddress(kPortIndex, universe, dmxnode::Direction::kOutput)) {
                     ClearEndOfLine();
                     Printf(labels_[kLabelIndex],
-#if defined(OUTPUT_HAVE_STYLESWITCH)
+#ifdef OUTPUT_HAVE_STYLESWITCH
                            "%c %d %s %s %c %s",
 #else
                            "%c %d %s %s %s",
 #endif
                            'A' + config_port_index, universe, dmxnode::GetMergeMode(artnet_node->GetMergeMode(kPortIndex), true),
+
 #if (ARTNET_VERSION >= 4)
                            artnet::GetProtocolMode(artnet_node->GetPortProtocol4(kPortIndex), true),
 #else
-                           "Art-Net",
+                           artnet::kNodeId,
 #endif
-#if defined(OUTPUT_HAVE_STYLESWITCH)
+#ifdef OUTPUT_HAVE_STYLESWITCH
                            artnet_node->GetOutputStyle(kPortIndex) == dmxnode::OutputStyle::kConstant ? 'C' : 'D',
 #endif
                            artnet_node->Rdm(kPortIndex) ? "RDM" : "");

lib-dmxnode/include/dmxnode_nodetype.h

@@ -26,6 +26,7 @@
 #define DMXNODE_NODETYPE_H_
 
 #include <cstdint>
+#include "common/utils/utils_string.h"
 
 namespace dmxnode {
 enum class NodeType { 
@@ -60,7 +61,7 @@ inline const char* GetNodeType(NodeType type) {
         return kNodeTypeNames[static_cast<uint32_t>(type)];
     }
 
-    return "Undefined";
+    return common::kUndefined;
 }
 } // namespace dmxnode
 

lib-dmxnode/include/dmxnode_outputtype.h

@@ -26,24 +26,25 @@
 #define DMXNODE_OUTPUTTYPE_H_
 
 #include <cstdint>
+#include "common/utils/utils_string.h"
 
 namespace dmxnode {
 enum class OutputType {
-    kDmx,      //
-    kDmxRdm,   //
-    kPixel,    //
-    kPixelDmx, //
-    kPwm,      //
-    kRgbPanel, //
-    kSerial,   //
-    kOsc,      //
-    kMonitor,  //
-    kStepper,  //
-    kPlayer,   //
-    kArtNet,   //
-    kTimeCode, //
-    kNone,     //
-    kUndefined //
+    kDmx,       //
+    kDmxRdm,    //
+    kPixel,     //
+    kPixelDmx,  //
+    kPwm,       //
+    kRgbPanel,  //
+    kSerial,    //
+    kOsc,       //
+    kMonitor,   //
+    kStepper,   //
+    kPlayer,    //
+    kArtNet,    //
+    kTimeCode,  //
+    kNone,      //
+    kUndefined, //
 };
 
 inline constexpr const char* kOutputTypeNames[static_cast<uint32_t>(OutputType::kUndefined)] = {
@@ -60,15 +61,15 @@ inline constexpr const char* kOutputTypeNames[static_cast<uint32_t>(OutputType::
     "Player",    //
     "Art-Net",   //
     "Timecode",  //
-    "None"       //
+    "None",      //
 };
 
 inline const char* GetOutputType(OutputType type) {
     if (type < OutputType::kUndefined) {
         return kOutputTypeNames[static_cast<uint32_t>(type)];
     }
 
-    return "Undefined";
+    return common::kUndefined;
 }
 } // namespace dmxnode
 

lib-network/src/core/network_memory.h

@@ -87,7 +87,7 @@ class Allocator {
 
     uint8_t* Allocate() {
         if (IsFull()) {
-            ERROR("Allocate:Full!");
+            ERROR("Full");
             return nullptr;
         }
 
@@ -105,7 +105,7 @@ class Allocator {
         assert(size <= kBlockSize);
 
         if (IsFull()) {
-            ERROR("Allocate:Full!");
+            ERROR("Full");
             return UINT16_MAX;
         }
 

lib-remoteconfig/src/http/json_action.cpp

@@ -37,7 +37,9 @@ static void SetDisplay(const char* val, uint32_t len) {
 }
 
 static void SetIdentify(const char* val, uint32_t len) {
-    if (len != 1) return;
+    if (len != 1) {
+        return;
+    }
 
     if (val[0] != '0') {
         board::statusled::SetMode(board::statusled::Mode::kFast);
@@ -48,7 +50,9 @@ static void SetIdentify(const char* val, uint32_t len) {
 
 // TODO (a) Subject for deletion
 static void SetReboot(const char* val, uint32_t len) {
-    if (len != 1) return;
+    if (len != 1) {
+        return;
+    }
     if (val[0] != '0') board::Reboot();
 }
 

lib-remoteconfig/src/http/json_config_directory.cpp

@@ -25,11 +25,15 @@
 #include <cstddef>
 #include <cstdint>
 #include <cstdio>
+#include <cassert>
 
 #include "http/json_infos.h"
 
 namespace json::config {
 uint32_t Directory(char* out_buffer, uint32_t out_buffer_size) {
+    assert(out_buffer != nullptr);
+    assert(out_buffer_size != 0);
+
     uint32_t total = 0;
 
     total += static_cast<uint32_t>(snprintf(out_buffer + total, out_buffer_size - total, "{\"files\":{"));

lib-remoteconfig/src/http/json_getlist.cpp

@@ -26,6 +26,7 @@
 #include <cstring>
 #include <cstdio>
 
+#include "common/utils/utils_string.h"
 #include "configstore.h"
 #include "configurationstore.h"
 #include "dmxnode_nodetype.h"
@@ -35,9 +36,8 @@
 
 namespace json {
 uint32_t GetList(char* out_buffer, uint32_t out_buffer_size) {
-    if ((out_buffer == nullptr) || (out_buffer_size == 0U)) {
-        return 0U;
-    }
+    assert(out_buffer != nullptr);
+    assert(out_buffer_size != 0);
 
     uint8_t display_name[common::store::remoteconfig::kDisplayNameLength];
 
@@ -47,10 +47,10 @@ uint32_t GetList(char* out_buffer, uint32_t out_buffer_size) {
 
 #ifdef DMXNODE_NODETYPE_DEFINED
     if (display_name[0] == '\0') {
-        const char* const long_name = DmxNodeNodeType::Get()->GetLongName();
+        const char* const kLongName = DmxNodeNodeType::Get()->GetLongName();
 
-        if (long_name != nullptr) {
-            strncpy(reinterpret_cast<char*>(display_name), long_name, common::store::remoteconfig::kDisplayNameLength - 1U);
+        if (kLongName != nullptr) {
+            strncpy(reinterpret_cast<char*>(display_name), kLongName, common::store::remoteconfig::kDisplayNameLength - 1U);
 
             display_name[common::store::remoteconfig::kDisplayNameLength - 1U] = '\0';
         }
@@ -67,11 +67,11 @@ uint32_t GetList(char* out_buffer, uint32_t out_buffer_size) {
     const char* output_type = dmxnode::GetOutputType(dmxnode::kOutputType);
 
     if (node_type == nullptr) {
-        node_type = "Undefined";
+        node_type = common::kUndefined;
     }
 
     if (output_type == nullptr) {
-        output_type = "Undefined";
+        output_type = common::kWarning;
     }
 
     const int kLength = snprintf(out_buffer, out_buffer_size,