Skip to content

Commit fd61036

Browse files
committed
Refactor RDM BW LCD, update generators & fixes
Multiple changes across subsystems: - lib-artnet: remove unused "network.h" include and drop DHCP status update in ArtNetNode::HandleIpProg (status2 modification removed). - lib-rdmsubdevice: major refactor of RDMSubDeviceBwLcd: - Modernized API and variable names (constructor args, locals), replaced macros with constexprs, and cleaned up formatting/indentation. - Introduced common/utils/utils_hex.h and use common::hex::ToCharUppercase for hex conversion. - Improved DMX footprint constant usage, clearer boolean/variable names, and minor logic/style cleanups. - Updated copyright year range. - lib-remoteconfig/http/content/generate_content.cpp: - Rename file pointers and locals to more descriptive names (file_content/file_includes/dir/etc.), reformat supported extensions array, and change include from "httpd/httpd.h" to "http/http.h". - Added "#undef NDEBUG" and adjusted fwrite/snprintf calls to use the renamed variables. - Cleaned up directory iteration and content conversion flow. - lib-remoteconfig/src/http/khtmlinfos.cpp: extend copyright range and remove an ENTRY guarded by ENABLE_PHY_SWITCH. Overall these commits are focused on refactoring for clarity, naming consistency, small behavior removal (DHCP status write), and code-style / copyright updates.
1 parent f55669f commit fd61036

5 files changed

Lines changed: 302 additions & 271 deletions

File tree

lib-artnet/src/json/artnetparams.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
#include <cstdint>
3030

3131
#include "artnetnode.h"
32-
#include "network.h"
3332
#include "json/artnetparams.h"
3433
#include "json/artnetparamsconst.h"
3534
#include "common/utils/utils_port.h"

lib-artnet/src/node/artnetnodehandleipprog.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,6 @@ void ArtNetNode::HandleIpProg()
123123

124124
if (is_changed)
125125
{
126-
art_poll_reply_.status2 = static_cast<uint8_t>((art_poll_reply_.status2 & (~(artnet::Status2::kIpDhcp))) |
127-
(network::iface::Dhcp() ? artnet::Status2::kIpDhcp : artnet::Status2::kIpManualy));
128-
129126
if (state_.send_art_poll_reply_on_change)
130127
{
131128
PollReplyQueueAdd(artnet::kPortAddressFirst, artnet::kPortAddressLast);

0 commit comments

Comments
 (0)