Fix DMX input indexing and simplify timer clears

Use an explicit index variable when storing DMX data to avoid the post-increment-in-assignment pattern (prevents potential undefined behavior/overflow when updating slots_in_packet). Also remove redundant static_cast<uint32_t> around bitwise negation when clearing timer interrupt flags in multiple IRQ handlers (TIMER1, TIMER4, TIMER6 and their channel clears) to simplify the code and improve clarity.

Author: vanvught

lib-dmx/.settings/language.settings.xml

@@ -5,7 +5,7 @@
 			<provider copy-of="extension" id="org.eclipse.cdt.ui.UserLanguageSettingsProvider"/>
 			<provider-reference id="org.eclipse.cdt.core.ReferencedProjectsLanguageSettingsProvider" ref="shared-provider"/>
 			<provider class="org.eclipse.cdt.managedbuilder.language.settings.providers.GCCBuildCommandParser" id="org.eclipse.cdt.managedbuilder.core.GCCBuildCommandParser" keep-relative-paths="false" name="CDT GCC Build Output Parser" parameter="([^/\\\\]*)((g?cc)|([gc]\+\+)|(clang))" prefer-non-shared="true"/>
-			<provider class="org.eclipse.cdt.managedbuilder.language.settings.providers.GCCBuiltinSpecsDetector" console="false" env-hash="1502105070734755712" id="org.eclipse.embedcdt.managedbuild.cross.arm.core.GCCBuiltinSpecsDetector" keep-relative-paths="false" name="CDT Arm Cross GCC Built-in Compiler Settings" parameter="${COMMAND} ${FLAGS} ${cross_toolchain_flags} -E -P -v -dD &quot;${INPUTS}&quot;" prefer-non-shared="true">
+			<provider class="org.eclipse.cdt.managedbuilder.language.settings.providers.GCCBuiltinSpecsDetector" console="false" env-hash="1502105672097326095" id="org.eclipse.embedcdt.managedbuild.cross.arm.core.GCCBuiltinSpecsDetector" keep-relative-paths="false" name="CDT Arm Cross GCC Built-in Compiler Settings" parameter="${COMMAND} ${FLAGS} ${cross_toolchain_flags} -E -P -v -dD &quot;${INPUTS}&quot;" prefer-non-shared="true">
 				<language-scope id="org.eclipse.cdt.core.gcc"/>
 				<language-scope id="org.eclipse.cdt.core.g++"/>
 			</provider>

lib-dmx/src/gd32/dmx.cpp

@@ -372,8 +372,11 @@ void IrqHandlerDmxRdmInput() {
         case dmx::TxRxState::kDmxData: {
 #if defined(CONFIG_DMX_DOUBLE_INPUT_BUFFER)
             dmx_data_buffer.slots_in_packet &= ~dmx::kDmxSlotsCompleteFlag;
-            dmx_data_buffer.data[dmx_data_buffer.slots_in_packet++] = kData;
-
+			auto index = dmx_data_buffer.slots_in_packet;
+            dmx_data_buffer.data[index] = kData;
+			index++;
+			dmx_data_buffer.slots_in_packet = index;
+			
             if (dmx_data_buffer.slots_in_packet > dmx::kChannelsMax) {
                 dmx_data_buffer.slots_in_packet |= dmx::kDmxSlotsCompleteFlag;
 
@@ -604,7 +607,7 @@ void TIMER1_IRQHandler() {
             }
         }
 
-        TIMER_INTF(TIMER1) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH0);
+        TIMER_INTF(TIMER1) = ~TIMER_INT_FLAG_CH0;
     }
 #endif // defined(DMX_USE_USART0)
 // USART 1
@@ -673,7 +676,7 @@ void TIMER1_IRQHandler() {
             assert(false);
         }
 
-        TIMER_INTF(TIMER1) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH1);
+        TIMER_INTF(TIMER1) = ~TIMER_INT_FLAG_CH1;
     }
 #endif // defined(DMX_USE_USART1)
 // USART 2
@@ -743,7 +746,7 @@ void TIMER1_IRQHandler() {
             assert(false);
         }
 
-        TIMER_INTF(TIMER1) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH2);
+        TIMER_INTF(TIMER1) = ~TIMER_INT_FLAG_CH2;
     }
 #endif // defined(DMX_USE_USART2)
 // UART 3
@@ -811,7 +814,7 @@ void TIMER1_IRQHandler() {
             assert(false);
         }
 
-        TIMER_INTF(TIMER1) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH3);
+        TIMER_INTF(TIMER1) = ~TIMER_INT_FLAG_CH3;
     }
 #endif // defined(DMX_USE_UART3)
     // Clear all remaining interrupt flags (safety measure)
@@ -888,7 +891,7 @@ void TIMER4_IRQHandler() {
             assert(false);
         }
 
-        TIMER_INTF(TIMER4) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH0);
+        TIMER_INTF(TIMER4) = ~TIMER_INT_FLAG_CH0;
     }
 #endif // defined(DMX_USE_UART4)
 // USART 5
@@ -959,7 +962,7 @@ void TIMER4_IRQHandler() {
             assert(false);
         }
 
-        TIMER_INTF(TIMER4) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH1);
+        TIMER_INTF(TIMER4) = ~TIMER_INT_FLAG_CH1;
     }
 #endif // defined(DMX_USE_USART5)
 // UART 6
@@ -1020,7 +1023,7 @@ void TIMER4_IRQHandler() {
             assert(false);
         }
 
-        TIMER_INTF(TIMER4) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH2);
+        TIMER_INTF(TIMER4) = ~TIMER_INT_FLAG_CH2;
     }
 #endif // defined(DMX_USE_UART6)
 // UART 7
@@ -1081,7 +1084,7 @@ void TIMER4_IRQHandler() {
             assert(false);
         }
 
-        TIMER_INTF(TIMER4) = static_cast<uint32_t>(~TIMER_INT_FLAG_CH3);
+        TIMER_INTF(TIMER4) = ~TIMER_INT_FLAG_CH3;
     }
 #endif // defined(DMX_USE_UART7)
     // Clear all remaining interrupt flags (safety measure)
@@ -1103,7 +1106,7 @@ void TIMER6_IRQHandler() {
     }
 
     // Clear all remaining interrupt flags (safety measure)
-    TIMER_INTF(TIMER6) = static_cast<uint32_t>(~kIntFlag);
+    TIMER_INTF(TIMER6) = ~kIntFlag;
 }
 
 // USART 0