Refactor GD32 FMC into shared library

Introduces a new `gd32::fmc` API in `lib-gd32` (`gd32_fmc.h`) and moves/renames FMC flash logic there, including a new GD32F4-specific FMC implementation (`src/f/fmc4/gd32_fmc.cpp`). `lib-flashcode` now delegates read/erase/write to this shared FMC layer and its GD32H7-specific flashcode file is removed.

Build wiring was updated to support the refactor: `lib-gd32` now uses a new `Rules.mk` (with `Makefile.mk` symlink) and `lib-flashcode` includes `lib-gd32` headers/sources. `Validate.mk` adds remote-config/minimum and RTL8201F link-check defines. Smaller cleanup changes include labeled bit-print output, GD32 FMC debug macros, GD32F10X soft UART timer mapping, and minor style/formatting fixes.

Author: vanvught

common/include/common/utils/utils_string.h

@@ -81,7 +81,7 @@ inline float Atof(const char* buffer, uint32_t size) {
     }
 
     while (size > 0 && *p >= '0' && *p <= '9') {
-        result = result * 10.0F + static_cast<float>(*p - '0');
+        result = (result * 10.0F) + static_cast<float>(*p - '0');
         ++p;
         --size;
     }

common/include/firmware/debug/debug_printbits.h

@@ -35,7 +35,7 @@
 namespace debug {
 template <typename T>
     requires std::unsigned_integral<T>
-inline void PrintBits(T value) {
+inline void PrintBits(T value, const char* string = nullptr) {
     if constexpr (!config::kDumpEnabled) {
         return;
     }
@@ -46,7 +46,10 @@ inline void PrintBits(T value) {
 
     static_assert(sizeof(T) <= sizeof(unsigned));
 
-    printf("%.*x ", kHexDigits, static_cast<unsigned>(value));
+    if (string != nullptr) {
+        printf("%s :", string);
+    }
+    printf("0x%.*x ", kHexDigits, static_cast<unsigned>(value));
 
     for (int bit_number = kMaxBitIndex; bit_number >= 0; --bit_number) {
         const auto kMask = static_cast<T>(1) << bit_number;

common/make/gd32/Validate.mk

@@ -24,6 +24,8 @@ endif
 
 ifeq ($(findstring CONFIG_REMOTECONFIG_MINIMUM,$(FLAGS)),CONFIG_REMOTECONFIG_MINIMUM)
 	DEFINES+=-DCONFIG_NET_APPS_NO_MDNS
+	DEFINES+=-DCONFIG_UDP_NO_OPTIMIZE
+	DEFINES+=-DDISABLE_RTC
 else
   ifeq ($(findstring NO_EMAC,$(FLAGS)),NO_EMAC)
   else
@@ -56,8 +58,23 @@ ifdef FATFS_MKFS
 	DEFINES+=-DCONFIG_FATFS_MKFS
 endif
 
+# Hardware Scenario    Flag Condition              Resulting Compiler Definitions (DEFINES)
+# Using RTL8201F       ENET_LINK_CHECK is missing  -DRTL8201F_LED1_LINK_ALL  -DENET_LINK_CHECK_USE_INT (Uses Interrupts)
+# Using RTL8201F       ENET_LINK_CHECK is present  -DRTL8201F_LED1_LINK_ALL
+# Other Hardware       Any                         -DENET_LINK_CHECK_REG_POLL (Uses Polling)
+
+ifneq ($(findstring RTL8201F,$(FLAGS)),)
+	DEFINES+=-DRTL8201F_LED1_LINK_ALL
+	ifeq ($(findstring ENET_LINK_CHECK,$(FLAGS)),)
+		DEFINES+=-DENET_LINK_CHECK_USE_INT
+	endif
+else
+	DEFINES+=-DENET_LINK_CHECK_REG_POLL
+endif
+
 $(info $$DEFINES [${DEFINES}])
 
 DEFINES:= $(sort $(DEFINES))
 
 $(info $$DEFINES [${DEFINES}])
+

lib-clib/src/asctime.cpp

@@ -35,7 +35,9 @@ static const char kWdayName[][4] = {"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "S
 static char s_buffer[kMaxAscTime + 1];
 
 extern "C" char* asctime(const struct tm* p_tm) {
-    if (!p_tm) return nullptr;
+    if (p_tm == nullptr) {
+        return nullptr;
+    }
 
     const char* const kWday = (p_tm->tm_wday >= 0 && p_tm->tm_wday <= 6) ? kWdayName[p_tm->tm_wday] : "???";
     const char* const kMon = (p_tm->tm_mon >= 0 && p_tm->tm_mon <= 11) ? kMonName[p_tm->tm_mon] : "???";

lib-flashcode/Makefile.GD32

@@ -1,18 +1,8 @@
 DEFINES =NDEBUG
 
-ifneq ($(MAKE_FLAGS),)
-	ifeq ($(findstring gd32f4xx,$(FAMILY)), gd32f4xx)
-		EXTRA_SRCDIR=src/gd32/f4xx
-	else
-		ifeq ($(findstring gd32h7xx,$(FAMILY)), gd32h7xx)
-			EXTRA_SRCDIR=src/gd32/h7xx
-		else
-			EXTRA_SRCDIR=src/gd32/fmc
-		endif
-	endif
-else
-	EXTRA_SRCDIR=src/gd32/fmc
-endif
+EXTRA_INCLUDES=../lib-gd32/include ../lib-gd32/src
+
+EXTRA_SRCDIR=src/spi/gd32
 
 include Rules.mk
 include ../firmware-template-gd32/lib/Rules.mk

lib-flashcode/src/gd32/flashcode.cpp

@@ -23,11 +23,19 @@
  * THE SOFTWARE.
  */
 
-#include <cstdio>
-#include <cassert>
+ #include <cstdint>
+ #include <cassert>
+ #include <span>
 
-#include "flashcode.h"
-#include "gd32.h"
+ #include "flashcode.h"
+ #include "gd32_fmc.h"
+ #include "gd32.h" // IWYU pragma: keep
+ 
+ namespace {
+ constexpr uint32_t k1KiB = 1024;
+ // Backwards compatibility with SPI FLASH
+ constexpr auto kFlashSectorSize = 4096;
+ } // namespace
 
 FlashCode::FlashCode() {
     FLASHCODE_DEBUG_ENTRY();
@@ -36,16 +44,38 @@ FlashCode::FlashCode() {
 
     detected_ = true;
 
-    printf("FMC: %s %u [%u]\n", GetName(), static_cast<unsigned int>(GetSize()), static_cast<unsigned int>(GetSize() / 1024U));
+    printf("FMC: %s %u [%u]\n", GetName(), static_cast<unsigned>(GetSize()), static_cast<unsigned>(GetSize() / k1KiB));
     FLASHCODE_DEBUG_EXIT();
 }
 
-FlashCode::~FlashCode() {
-    FLASHCODE_DEBUG_ENTRY();
+const char* FlashCode::GetName() const {
+    return GD32_MCU_NAME;
+}
 
-    FLASHCODE_DEBUG_EXIT();
+uint32_t FlashCode::GetSize() const {
+    return FMC_SIZE * k1KiB;
 }
 
-const char* FlashCode::GetName() const {
-    return GD32_MCU_NAME;
+uint32_t FlashCode::GetSectorSize() const {
+    return kFlashSectorSize;
+}
+
+bool FlashCode::Read(uint32_t offset, std::span<uint8_t> buffer, flashcode::Result& result) {
+    const auto kStatus = gd32::fmc::Read(offset, buffer); // Blocking
+    result = kStatus ? flashcode::Result::kOk : flashcode::Result::kError;
+    return true;
+}
+
+bool FlashCode::Erase(uint32_t offset, uint32_t length, flashcode::Result& result) {
+    gd32::fmc::Result fmc_result;
+    const auto kStatus = gd32::fmc::Erase(offset, length, fmc_result); // State-machine
+    result = (fmc_result == gd32::fmc::Result::kOk) ? flashcode::Result::kOk : flashcode::Result::kError;
+    return kStatus;
+}
+
+bool FlashCode::Write(uint32_t offset, std::span<const uint8_t> buffer, flashcode::Result& result) {
+    gd32::fmc::Result fmc_result;
+    const auto kStatus = gd32::fmc::Write(offset, buffer, fmc_result); // State-machine
+    result = (fmc_result == gd32::fmc::Result::kOk) ? flashcode::Result::kOk : flashcode::Result::kError;
+    return kStatus;
 }