Refactor RDM device handling and unify device info

Refactored RDM device management by introducing a singleton RdmDevice class, consolidating device info and label handling. Removed the now-redundant RDMDeviceController class and updated RDMDeviceResponder and related code to use the new RdmDevice interface. Updated all references and method signatures to use the new rdm::DeviceInfoData and rdm::DeviceInfo structures, improving code clarity and maintainability.

Author: vanvught

gd32_dmx_usb_pro/firmware/main.cpp

@@ -28,6 +28,7 @@
 #include "hal.h"
 #include "gd32/hal_watchdog.h"
 #include "hal_boardinfo.h"
+#include "rdmdevice.h"
 #include "widget.h"
 #include "widgetparams.h"
 #include "configstore.h"
@@ -45,13 +46,13 @@ static constexpr char kWidgetModeNames[4][12] ALIGNED =
   "RDM_SNIFFER"
 };
 
-static constexpr TRDMDeviceInfoData kDeviceLabel ALIGNED = 
+static constexpr rdm::DeviceInfoData kDeviceLabel ALIGNED = 
 {
   const_cast<char*>("GD32F103RC DMX USB Pro"),
   22
 };
 
-int main()
+int main() // NOLINT
 {
     hal::Init();
     ConfigStore config_store;
@@ -63,12 +64,13 @@ int main()
     widget_params.Load();
     widget_params.Set();
 
-    widget.SetLabel(&kDeviceLabel);
-    widget.Init();
+    auto& rdm_device = RdmDevice::Get();
+    rdm_device.SetLabel(&kDeviceLabel);
+    rdm_device.Init();
 
-    const auto* rdm_device_uid = widget.GetUID();
-    TRDMDeviceInfoData rdm_device_label;
-    widget.GetLabel(&rdm_device_label);
+    const auto* rdm_device_uid = rdm_device.GetUID();
+    struct rdm::DeviceInfoData rdm_device_label;
+    rdm_device.GetLabel(&rdm_device_label);
     const auto kWidgetMode = widget_params.GetMode();
 
     uint8_t hw_text_length;

gd32_rdm_responder/firmware/main.cpp

@@ -28,6 +28,7 @@
 #include "gd32/hal_watchdog.h"
 #include "displayudf.h"
 #include "json/displayudfparams.h"
+#include "rdmdevice.h"
 #include "rdmresponder.h"
 #include "rdmpersonality.h"
 #include "json/pixeldmxparams.h"
@@ -60,7 +61,7 @@ int main() // NOLINT
     DisplayUdf display;
     ConfigStore config_store;
 #if !defined(NO_EMAC)    
-    Network nw;
+    network::Init();
 #endif    
     FirmwareVersion fw(SOFTWARE_VERSION, __DATE__, __TIME__);
 
@@ -79,6 +80,10 @@ int main() // NOLINT
     PixelTestPattern pixel_test_pattern(kTestPattern, 1);
 
     PixelDmxParamsRdm pixeldmx_paramsrdm;
+    
+    auto& rdm_device = RdmDevice::Get();
+    rdm_device.SetProductCategory(E120_PRODUCT_CATEGORY_FIXTURE);
+    rdm_device.SetProductDetail(E120_PRODUCT_DETAIL_LED);
 
 #if defined(CONFIG_RDM_MANUFACTURER_PIDS_SET)
     static constexpr auto kPersonalityCount = static_cast<uint32_t>(pixel::Type::UNDEFINED);
@@ -98,8 +103,6 @@ int main() // NOLINT
     RDMPersonality* personalities[2] = {new RDMPersonality(description, &pixeldmx), new RDMPersonality("Config mode", &pixeldmx_paramsrdm)};
     RDMResponder rdm_responder(personalities, 2);
 #endif
-    rdm_responder.SetProductCategory(E120_PRODUCT_CATEGORY_FIXTURE);
-    rdm_responder.SetProductDetail(E120_PRODUCT_DETAIL_LED);
     rdm_responder.Init();
     rdm_responder.Start();
     rdm_responder.DmxDisableOutput(!kIsConfigMode && (kTestPattern != pixelpatterns::Pattern::kNone));
@@ -149,7 +152,7 @@ int main() // NOLINT
         hal::WatchdogFeed();
         rdm_responder.Run();
 #if !defined(NO_EMAC)
-        net::Run();
+        network::Run();
 #endif
         pixel_test_pattern.Run();
         display.Run();