Fix formatting, console messages & network tweaks

Multiple small fixes and cleanups across the codebase: adjust snprintf buffer usage and UTC offset formatting; append newlines to many console::Error messages and replace a Puts call with console::Write; bump copyright years. Change DmxNode layout (use reserved[2]), increase network memory blocks (8->12), and tweak HOST_NAME_PREFIX strings. Improve hostname generation and sanitization, add IWYU pragmas and needed includes, simplify USB host compile guards, and refactor file/variable names and includes in the HTTP content generator. Also minor PHY, IGMP/UDP/TCP/DHCP messaging and other small refactors (variable renames, removed an ENABLE_PHY_SWITCH html entry). These changes fix formatting/printing bugs, harden hostname handling, raise some network limits, and clean up various headers and file operations.

Author: vanvught

common/include/json/json_format_helpers.h

@@ -36,23 +36,22 @@ constexpr size_t kOffsetBufferSize = 12; // For timezone offsets e.g. "+01:00"
 
 [[nodiscard]] inline const char* FormatFloat(float value, char (&buf)[kFloatBufferSize], const char* fmt = "%.2f")
 {
-    snprintf(buf, sizeof(buf) - 1, fmt, value);
+    snprintf(buf, sizeof(buf), fmt, value);
     return buf;
 }
 
 [[nodiscard]] inline const char* FormatUtcOffset(int32_t hours, uint32_t minutes, char (&buf)[kOffsetBufferSize])
 {
-    if (hours == 0)
+    if (hours <= 0)
     {
-        snprintf(buf, sizeof(buf) - 1, "%.2d:%.2u", hours, minutes);
+        snprintf(buf, sizeof(buf), "%.2d:%.2u", hours, minutes);
     }
     else
     {
-        snprintf(buf, sizeof(buf) - 1, "%c%.2d:%.2u", hours < 0 ? '-' : '+', hours, minutes);
+        snprintf(buf, sizeof(buf), "+%.2d:%.2u", hours, minutes);
     }
     return buf;
 }
-
 } // namespace format
 
 #endif  // JSON_JSON_FORMAT_HELPERS_H_

lib-clib/src/malloc.cpp

@@ -150,7 +150,7 @@ extern "C"
 
             if (next > block_limit)
             {
-                console::Error("malloc: out of memory");
+                console::Error("malloc: out of memory\n");
 #ifdef DEBUG_HEAP
                 debug_heap();
 #endif

lib-clib/src/perror.cpp

@@ -2,7 +2,7 @@
  * @file perror.cpp
  *
  */
-/* Copyright (C) 2020-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2020-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -31,6 +31,7 @@ namespace console
 void Error(const char*);
 int Putc(int);
 int Puts(const char*);
+void Write(const char*, unsigned int);
 } // namespace console
 
 /*
@@ -107,7 +108,7 @@ extern "C"
         if (s && *s)
         {
             console::Error(s);
-            console::Puts(": ");
+            console::Write(": ", 2);
         }
 
         console::Error(ptr);

lib-configstore/include/configurationstore.h

@@ -167,8 +167,7 @@ struct Flags
 struct DmxNode
 {
     uint32_t flags;
-    uint8_t personality;
-    uint8_t reserved;
+    uint8_t reserved[2];
     uint16_t universe[dmxnode::kParamPorts];
     uint16_t direction;
     uint16_t merge_mode;

lib-hal/console/uart0/console.cpp

@@ -23,6 +23,7 @@
  * THE SOFTWARE.
  */
 
+#include <cstdint>
 #include <cstring>
 
 #include "console.h"

lib-hal/include/gd32/hal.h

@@ -2,7 +2,7 @@
  * @file hal.h
  *
  */
-/* Copyright (C) 2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2025-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -28,17 +28,13 @@
 
 #include <cstdint>
 
-#include "gd32.h"
+#include "gd32.h" // IWYU pragma: keep
 
-#if defined(ENABLE_USB_HOST) && defined(CONFIG_USB_HOST_MSC)
+#if defined(ENABLE_USB_HOST)
 extern "C"
 {
 #include "usbh_core.h"
-#if defined(GD32H7XX) || defined(GD32F4XX)
-    extern usbh_host usb_host_msc;
-#else
     extern usbh_host usb_host;
-#endif
 }
 #endif
 
@@ -54,10 +50,10 @@ void emac_debug_run();
 #include "task.h"
 #endif
 
-#include "softwaretimers.h"
+#include "softwaretimers.h" // IWYU pragma: keep
 
 #if !defined(DISABLE_RTC)
-#include "hwclock.h"
+#include "hwclock.h" // IWYU pragma: keep
 #endif
 
 #include "hal_panelled.h"
@@ -74,13 +70,9 @@ inline constexpr float kCoreTemperatureMax = +85.0;
 
 inline void Run()
 {
-#if defined(ENABLE_USB_HOST) && defined(CONFIG_USB_HOST_MSC)
-#if defined(GD32H7XX) || defined(GD32F4XX)
-    usbh_core_task(&usb_host_msc);
-#else
+#if defined(ENABLE_USB_HOST)
     usbh_core_task(&usb_host);
 #endif
-#endif
 #if !defined(USE_FREE_RTOS)
     SoftwareTimerRun();
 #endif

lib-hal/superloop/softwaretimers.cpp

@@ -77,7 +77,7 @@ TimerHandle_t SoftwareTimerAdd(uint32_t interval_millis, const TimerCallbackFunc
     if (s_timers_count >= hal::kSoftwareTimersMax)
     {
 #ifndef NDEBUG
-        console::Error("SoftwareTimerAdd: Max timer limit reached");
+        console::Error("SoftwareTimerAdd: Max timer limit reached\n");
 #endif
         return -1;
     }
@@ -134,7 +134,7 @@ bool SoftwareTimerDelete(TimerHandle_t& id)
     }
 
 #ifndef NDEBUG
-    console::Error("SoftwareTimerDelete: Timer not found");
+    console::Error("SoftwareTimerDelete: Timer not found\n");
 #endif
 
     DEBUG_EXIT();
@@ -163,7 +163,7 @@ bool SoftwareTimerChange(TimerHandle_t id, uint32_t interval_millis)
     }
 
 #ifndef NDEBUG
-    console::Error("SoftwareTimerChange: Timer not found");
+    console::Error("SoftwareTimerChange: Timer not found\n");
 #endif
 
     return false;

lib-network/config/net_config.h

@@ -2,7 +2,7 @@
  * @file net_config.h
  *
  */
-/* Copyright (C) 2021-2024 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2021-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -26,16 +26,20 @@
 #ifndef NET_CONFIG_H_
 #define NET_CONFIG_H_
 
+// Valid hostnames (as per RFC 1123) must consist only of ASCII letters (a-z, A-Z), digits (0-9), and hyphens (-). 
+// Labels must be 1-63 characters, with a maximum total length of 253 characters. 
+// They cannot start or end with a hyphen, and should not be all-numeric. 
+
 #if defined(__linux__) || defined (__APPLE__)
 # define UDP_MAX_PORTS_ALLOWED			32
 # define IGMP_MAX_JOINS_ALLOWED			(4 + (8 * 4)) /* 8 outputs x 4 Universes */
-# define TCP_MAX_TCBS_ALLOWED			16
+# define TCP_MAX_TCBS_ALLOWED			32
 # define TCP_MAX_PORTS_ALLOWED			2
 #else
 # define TCP_MAX_PORTS_ALLOWED			1
 # if defined (H3)
 #  if !defined(HOST_NAME_PREFIX)
-#   define HOST_NAME_PREFIX				"allwinner_"
+#   define HOST_NAME_PREFIX				"allwinner-"
 #  endif
 #  define UDP_MAX_PORTS_ALLOWED			16
 #  define IGMP_MAX_JOINS_ALLOWED		(4 + (8 * 4)) /* 8 outputs x 4 Universes */
@@ -46,7 +50,7 @@
  */
 #  define CHECKSUM_BY_HARDWARE
 #  if !defined(HOST_NAME_PREFIX)
-#   define HOST_NAME_PREFIX				"gigadevice_"
+#   define HOST_NAME_PREFIX				"gigadevice-"
 #  endif
 #  if !defined (UDP_MAX_PORTS_ALLOWED)
 #   define UDP_MAX_PORTS_ALLOWED		8

lib-network/src/core/ipv4/dhcp.cpp

@@ -250,7 +250,7 @@ void Inform()
 #ifndef NDEBUG
     if (kHandle < 0)
     {
-        console::Error("DHCP Inform");
+        console::Error("DHCP Inform\n");
         return;
     }
 #endif
@@ -766,7 +766,7 @@ bool Start()
 #ifndef NDEBUG
     if (dhcp->handle < 0)
     {
-        console::Error("DHCP Start");
+        console::Error("DHCP Start\n");
         DEBUG_EXIT();
         return false;
     }

lib-network/src/core/ipv4/igmp.cpp

@@ -378,7 +378,7 @@ void static Join(uint32_t group_address)
     }
 
 #ifndef NDEBUG
-    console::Error("igmp::Join");
+    console::Error("igmp::Join\n");
 #endif
     DEBUG_ENTRY();
 }