Refactor UTC globals and tighten debug formatting

Replace the `Global` singleton with inline helpers in the `global` namespace for UTC offset access/validation, simplifying usage while preserving behavior. Update multiple debug headers to use safer `printf` argument casts and minor const/unsigned cleanups, and remove noisy command TX/RX byte logging from the GD32 flasher while keeping timeout/error reporting.

Author: vanvught

common/include/firmware/debug/debug_dump.h

@@ -2,7 +2,7 @@
  * @file debug_dump.h
  *
  */
-/* Copyright (C) 2018-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2018-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -46,27 +46,27 @@ static inline void Dump([[maybe_unused]] const void* data, [[maybe_unused]] uint
 #else
 inline void Dump(const void* data, uint32_t size) {
     uint32_t chars = 0;
-    const auto* p = reinterpret_cast<const uint8_t*>(data);
+    const auto* ptr = reinterpret_cast<const uint8_t*>(data);
 
-    printf("%p:%d\n", data, size);
+    printf("%p:%u\n", data, static_cast<int>(size));
 
     do {
         uint32_t chars_this_line = 0;
 
-        printf("%04x ", chars);
+        printf("%04x ", static_cast<unsigned>(chars));
 
-        const auto* q = p;
+        const auto* q = ptr;
 
         while ((chars_this_line < dump::kCharsPerLine) && (chars < size)) {
             if (chars_this_line % 8 == 0) {
                 printf(" ");
             }
 
-            printf("%02x ", *p);
+            printf("%02x ", *ptr);
 
             chars_this_line++;
             chars++;
-            p++;
+            ptr++;
         }
 
         auto chars_dot_line = chars_this_line;

common/include/firmware/debug/debug_i2cdetect.h

@@ -44,7 +44,7 @@ void Detect() {
     puts("\n     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f");
 
     for (uint32_t i = 0; i < 128; i = (i + 16)) {
-        printf("%02x: ", i);
+        printf("%02x: ", static_cast<unsigned>(i));
         for (uint32_t j = 0; j < 16; j++) {
             // Skip unwanted addresses
             if ((i + j < kFirst) || (i + j > kLast)) {
@@ -53,7 +53,7 @@ void Detect() {
             }
 
             if (::i2c::IsConnected(static_cast<uint8_t>(i + j))) {
-                printf("%02x ", i + j);
+                printf("%02x ", static_cast<unsigned>(i + j));
             } else {
                 printf("-- ");
             }

common/include/firmware/debug/debug_stack.h

@@ -45,18 +45,18 @@ inline void Print() {
 	assert(end > start);
     const auto kSize = static_cast<uint32_t>(end - start);
 
-    auto* p = start;
+    const auto* ptr = start;
 
-    while (p < end) {
-        if (*p != kMagicWord) {
+    while (ptr < end) {
+        if (*ptr != kMagicWord) {
             break;
         }
-        p++;
+        ptr++;
     }
 
-    const auto kUsedBytes = static_cast<uint32_t>(4 * (end - p));
-    const auto kFreeBytes = static_cast<uint32_t>(4 * (p - start));
-    const auto kFreePct = (static_cast<uint32_t>(p - start) * 100U) / kSize;
+    const auto kUsedBytes = static_cast<uint32_t>(4 * (end - ptr));
+    const auto kFreeBytes = static_cast<uint32_t>(4 * (ptr - start));
+    const auto kFreePct = (static_cast<uint32_t>(ptr - start) * 100U) / kSize;
 
     if (s_used_bytes_previous != kUsedBytes) {
         s_used_bytes_previous = kUsedBytes;
@@ -70,9 +70,9 @@ inline void Print() {
         }
 
 #ifndef NDEBUG
-        printf("Stack: Size %uKB, [%p:%p:%p], Used: %u, Free: %u [%u]", kSize / (1024 / 4), start, p, end, kUsedBytes, kFreeBytes, kFreePct);
+        printf("Stack: Size %uKB, [%p:%p:%p], Used: %u, Free: %u [%u]", static_cast<unsigned>(kSize / (1024 / 4)), reinterpret_cast<const void *>(start), reinterpret_cast<const void *>(ptr), reinterpret_cast<const void *>(end), static_cast<unsigned>(kUsedBytes), static_cast<unsigned>(kFreeBytes), static_cast<unsigned>(kFreePct));
 #else
-        printf("Stack: Size %uKB, Used: %u, Free: %u", kSize / (1024 / 4), kUsedBytes, kFreeBytes);
+        printf("Stack: Size %uKB, Used: %u, Free: %u", static_cast<unsigned>(kSize / (1024 / 4)), static_cast<unsigned>(kUsedBytes), static_cast<unsigned>(kFreeBytes));
 #endif
         printf("\x1b[39m\n");
     }
@@ -81,7 +81,7 @@ inline void Print() {
 inline void Run() {
 	static uint32_t s_millis_previous;
     const auto kMillis = timing::Millis();
-    if (kMillis - s_millis_previous >= 1000) {
+    if (kMillis - s_millis_previous >= 1000U) {
         s_millis_previous = kMillis;
         Print();
     }

common/include/firmware/pixeldmx/show.h

@@ -35,7 +35,7 @@
 
 namespace common::firmware::pixeldmx {
 inline void Show(uint32_t line, pixelpatterns::Pattern pattern) {
-	DEBUG_PRINTF("line=%u, pattern=%u", line, static_cast<uint32_t>(pattern));
+	DEBUG_PRINTF("line=%u, pattern=%u", static_cast<unsigned>(line), static_cast<unsigned>(pattern));
 
     auto& configuration = PixelDmxConfiguration::Get();
     auto* display = Display::Get();
@@ -44,8 +44,8 @@ inline void Show(uint32_t line, pixelpatterns::Pattern pattern) {
     display->ClearEndOfLine();
     display->Printf(line, "%s:%d G%d %s", 
 		pixel::GetTypeName(configuration.GetType()), 
-		configuration.GetCount(), 
-		configuration.GetGroupingCount(), 
+		static_cast<unsigned>(configuration.GetCount()), 
+		static_cast<unsigned>(configuration.GetGroupingCount()), 
 		pixel::GetMapName(configuration.GetMap())
 	);
 
@@ -55,7 +55,7 @@ inline void Show(uint32_t line, pixelpatterns::Pattern pattern) {
     if (pattern != pixelpatterns::Pattern::kNone) {
         display->Printf(6, "%s:%u", 
 			PixelPatterns::GetName(pattern), 
-			static_cast<uint32_t>(pattern)
+			static_cast<unsigned>(pattern)
 		);
     }
 }

common/include/global.h

@@ -16,71 +16,51 @@
 
 #include "utc.h"
 
+namespace global {
+
 /**
- * @class Global
- * @brief Singleton class for managing and validating UTC offsets.
- *
- * The Global class provides methods to set and get the UTC offset in seconds.
- * It also includes validation logic for standard UTC time zones.
+ * @brief Gets the current UTC offset in seconds.
+ * @return UTC offset in seconds.
  */
-class Global {
-   public:
-    /**
-     * @brief Get the singleton instance of the Global class.
-     * @return Reference to the singleton Global object.
-     */
-    static Global& Instance() {
-        static Global instance;
-        return instance;
-    }
+inline int32_t GetUtcOffset() {
+    return global::g_utc_offset;
+}
 
-    /**
-     * @brief Gets the current UTC offset in seconds.
-     * @return UTC offset in seconds.
-     */
-    int32_t GetUtcOffset() const { return global::g_utc_offset; }
-
-    /**
-     * @brief Gets the current UTC offset as (hours, minutes).
-     * @param[out] hours Signed hour component.
-     * @param[out] minutes Unsigned minute component.
-     */
-    void GetUtcOffset(int32_t& hours, uint32_t& minutes) { utc::SplitOffset(global::g_utc_offset, hours, minutes); }
+/**
+ * @brief Gets the current UTC offset as (hours, minutes).
+ * @param[out] hours Signed hour component.
+ * @param[out] minutes Unsigned minute component.
+ */
+inline void GetUtcOffset(int32_t& hours, uint32_t& minutes) {
+    utc::SplitOffset(global::g_utc_offset, hours, minutes);
+}
 
-    /**
-     * @brief Sets the global UTC offset if the value is valid.
-     * @param utc_offset_seconds Offset in seconds
-     * @return true if successfully set; false otherwise
-     */
-    bool SetUtcOffsetIfValid(int32_t utc_offset_seconds) {
-        if (utc::IsValidOffset(utc_offset_seconds)) {
-            ::global::g_utc_offset = utc_offset_seconds;
-            return true;
-        }
-        return false;
+/**
+ * @brief Sets the global UTC offset if the value is valid.
+ * @param utc_offset_seconds Offset in seconds
+ * @return true if successfully set; false otherwise
+ */
+inline bool SetUtcOffsetIfValid(int32_t utc_offset_seconds) {
+    if (utc::IsValidOffset(utc_offset_seconds)) {
+        ::global::g_utc_offset = utc_offset_seconds;
+        return true;
     }
+    return false;
+}
 
-    /**
-     * @brief Sets the global UTC offset from (hours, minutes) if valid.
-     * @param hours Signed hour component
-     * @param minutes Unsigned minute component
-     * @return true if valid and set; false otherwise
-     */
-    bool SetUtcOffsetIfValid(int32_t hours, uint32_t minutes) {
-        int32_t offset_seconds;
-        if (utc::ValidateOffset(hours, minutes, offset_seconds)) {
-            return SetUtcOffsetIfValid(offset_seconds);
-        }
-        return false;
+/**
+ * @brief Sets the global UTC offset from (hours, minutes) if valid.
+ * @param hours Signed hour component
+ * @param minutes Unsigned minute component
+ * @return true if valid and set; false otherwise
+ */
+inline bool SetUtcOffsetIfValid(int32_t hours, uint32_t minutes) {
+    int32_t offset_seconds;
+    if (utc::ValidateOffset(hours, minutes, offset_seconds)) {
+        return SetUtcOffsetIfValid(offset_seconds);
     }
-
-   private:
-    Global() = default;
-    // Delete copy/move constructors and assignment operators
-    Global(const Global&) = delete;
-    Global& operator=(const Global&) = delete;
-    Global(Global&&) = delete;
-    Global& operator=(Global&&) = delete;
-};
+    return false;
+}
+} // namespace global
 
 #endif // GLOBAL_H_

common/scripts/gd32/flash.py

@@ -177,11 +177,6 @@ def _try_sync(self, attempts=3):
     def _send_command(self, cmd):
         command = bytes([cmd, cmd ^ 0xFF])
 
-        print(
-            f"  Command TX: "
-            f"0x{command[0]:02X} 0x{command[1]:02X}"
-        )
-
         self.port.write(command)
         self.port.flush()
 
@@ -191,8 +186,6 @@ def _send_command(self, cmd):
             print(f"  Command 0x{cmd:02X}: timeout")
             return False
 
-        print(f"  Command RX: 0x{response[0]:02X}")
-
         if response[0] == self.ACK:
             return True