Clean up StoreDevice logging and formatting

Standardize brace formatting in the GD32 RAM and I2C store device implementations, remove noisy debug prints from RAM read/write paths, and cast size values in `printf` calls to match the expected unsigned format specifiers.

Author: vanvught

lib-configstore/device/gd32/ram/storedevice.cpp

@@ -42,37 +42,31 @@
 static constexpr uint32_t kFlashSectorSize = 4096U;
 static constexpr uint32_t kBsramSize = 4096U;
 
-StoreDevice::StoreDevice()
-{
+StoreDevice::StoreDevice() {
     DEBUG_ENTRY();
 
     detected_ = true;
 
-    printf("StoreDevice: BSRAM with total %d bytes [%d kB]\n", GetSize(), GetSize() / 1024U);
+    printf("StoreDevice: BSRAM with total %d bytes [%d kB]\n", static_cast<unsigned>(GetSize()), static_cast<unsigned>(GetSize() / 1024U));
     DEBUG_EXIT();
 }
 
-StoreDevice::~StoreDevice()
-{
+StoreDevice::~StoreDevice() {
     DEBUG_ENTRY();
 
     DEBUG_EXIT();
 }
 
-uint32_t StoreDevice::GetSize() const
-{
+uint32_t StoreDevice::GetSize() const {
     return kBsramSize;
 }
 
-uint32_t StoreDevice::GetSectorSize() const
-{
+uint32_t StoreDevice::GetSectorSize() const {
     return kFlashSectorSize;
 }
 
-bool StoreDevice::Read(__attribute__((unused)) uint32_t offset, __attribute__((unused)) uint32_t length, __attribute__((unused)) uint8_t* buffer, storedevice::Result& result)
-{
+bool StoreDevice::Read(__attribute__((unused)) uint32_t offset, __attribute__((unused)) uint32_t length, __attribute__((unused)) uint8_t* buffer, storedevice::Result& result) {
     DEBUG_ENTRY();
-    DEBUG_PRINTF("offset=%p[%d], len=%u[%d], data=%p[%d]", offset, (((uint32_t)(offset) & 0x3) == 0), length, (((uint32_t)(length) & 0x3) == 0), buffer, (((uint32_t)(buffer) & 0x3) == 0));
     assert((offset + length) <= BSRAM_SIZE);
 
     result = storedevice::Result::kOk;
@@ -81,20 +75,18 @@ bool StoreDevice::Read(__attribute__((unused)) uint32_t offset, __attribute__((u
     return true;
 }
 
-bool StoreDevice::Erase(__attribute__((unused)) uint32_t offset, __attribute__((unused)) uint32_t length, storedevice::Result& result)
-{
+bool StoreDevice::Erase(__attribute__((unused)) uint32_t offset, __attribute__((unused)) uint32_t length, storedevice::Result& result) {
     DEBUG_ENTRY();
 
     result = storedevice::Result::kOk;
+    
 
     DEBUG_EXIT();
     return true;
 }
 
-bool StoreDevice::Write(__attribute__((unused)) uint32_t offset, __attribute__((unused)) uint32_t length, __attribute__((unused)) const uint8_t* buffer, storedevice::Result& result)
-{
+bool StoreDevice::Write(__attribute__((unused)) uint32_t offset, __attribute__((unused)) uint32_t length, __attribute__((unused)) const uint8_t* buffer, storedevice::Result& result) {
     DEBUG_ENTRY();
-    DEBUG_PRINTF("offset=%p[%d], len=%u[%d], data=%p[%d]", offset, (((uint32_t)(offset) & 0x3) == 0), length, (((uint32_t)(length) & 0x3) == 0), buffer, (((uint32_t)(buffer) & 0x3) == 0));
     assert((offset + length) <= BSRAM_SIZE);
 
     result = storedevice::Result::kOk;

lib-configstore/device/i2c/storedevice.cpp

@@ -39,8 +39,7 @@
 #include "i2c/at24cxx.h" // IWYU pragma: keep
 #include "firmware/debug/debug_debug.h"
 
-namespace storedevice
-{
+namespace storedevice {
 #if !defined(CONFIG_FLASHROM_I2C_INDEX)
 #define CONFIG_FLASHROM_I2C_INDEX 0
 #endif
@@ -50,42 +49,34 @@ static constexpr auto kFlashSectorSize = 4096U;
 static constexpr auto kRomSize = 4096U;
 } // namespace storedevice
 
-StoreDevice::StoreDevice() : AT24C32(storedevice::kI2CIndex)
-{
+StoreDevice::StoreDevice() : AT24C32(storedevice::kI2CIndex) {
     DEBUG_ENTRY();
 
     detected_ = AT24C32::IsConnected();
 
-    if (!detected_)
-    {
+    if (!detected_) {
         printf("StoreDevice: No AT24C32 at %2x", AT24C32::GetAddress());
-    }
-    else
-    {
-        printf("StoreDevice: AT24C32 total %u bytes [%u kB]\n", GetSize(), GetSize() / 1024U);
+    } else {
+        printf("StoreDevice: AT24C32 total %u bytes [%u kB]\n", static_cast<unsigned>(GetSize()), static_cast<unsigned>(GetSize() / 1024U));
     }
 
     DEBUG_EXIT();
 }
 
-StoreDevice::~StoreDevice()
-{
+StoreDevice::~StoreDevice() {
     DEBUG_ENTRY();
     DEBUG_EXIT();
 }
 
-uint32_t StoreDevice::GetSize() const
-{
+uint32_t StoreDevice::GetSize() const {
     return storedevice::kRomSize;
 }
 
-uint32_t StoreDevice::GetSectorSize() const
-{
+uint32_t StoreDevice::GetSectorSize() const {
     return storedevice::kFlashSectorSize;
 }
 
-bool StoreDevice::Read(uint32_t offset, uint32_t length, uint8_t* buffer, storedevice::Result& result)
-{
+bool StoreDevice::Read(uint32_t offset, uint32_t length, uint8_t* buffer, storedevice::Result& result) {
     DEBUG_ENTRY();
     assert((offset + length) <= storedevice::ROM_SIZE);
 
@@ -97,8 +88,7 @@ bool StoreDevice::Read(uint32_t offset, uint32_t length, uint8_t* buffer, stored
     return true;
 }
 
-bool StoreDevice::Erase([[maybe_unused]] uint32_t offset, [[maybe_unused]] uint32_t length, storedevice::Result& result)
-{
+bool StoreDevice::Erase([[maybe_unused]] uint32_t offset, [[maybe_unused]] uint32_t length, storedevice::Result& result) {
     DEBUG_ENTRY();
 
     result = storedevice::Result::kOk;
@@ -107,8 +97,7 @@ bool StoreDevice::Erase([[maybe_unused]] uint32_t offset, [[maybe_unused]] uint3
     return true;
 }
 
-bool StoreDevice::Write(uint32_t offset, uint32_t length, const uint8_t* buffer, storedevice::Result& result)
-{
+bool StoreDevice::Write(uint32_t offset, uint32_t length, const uint8_t* buffer, storedevice::Result& result) {
     DEBUG_ENTRY();
     assert((offset + length) <= ROM_SIZE);