Refactor EMAC PHY link handling and cleanup

Consolidates link-check logic into `emac::phy::link`, removing the separate `emac_link_check`/`emac_link` files and wiring init/poll/interrupt handling through the PHY layer. The PHY flow was tightened with shared `kAddress`, improved status/autonegotiation parsing, link-change handling, and timer-based polling for register/pin modes; `emac::Start` now only adjusts media when link is up and autonegotiation is complete. Also standardizes many `#endif` comments and includes small naming/style cleanups across networking sources.

Author: vanvught

lib-network/include/apps/ntpclient.h

@@ -32,10 +32,10 @@
 
 #if !defined(CONFIG_NTP_CLIENT_POLL_POWER_MIN)
 #define CONFIG_NTP_CLIENT_POLL_POWER_MIN 3
-#endif
+#endif // CONFIG_NTP_CLIENT_POLL_POWER_MIN
 #if !defined(CONFIG_NTP_CLIENT_POLL_POWER_MAX)
 #define CONFIG_NTP_CLIENT_POLL_POWER_MAX 12
-#endif
+#endif // CONFIG_NTP_CLIENT_POLL_POWER_MAX
 
 namespace network::apps::ntpclient {
 inline constexpr uint32_t kTimeoutSeconds = 3;

lib-network/include/core/ip4/arp.h

@@ -37,7 +37,7 @@ void Input(const struct network::arp::Header*);
 void Send(void*, const uint32_t, uint32_t);
 #if defined CONFIG_NET_ENABLE_PTP
 void SendTimestamp(void*, uint32_t, uint32_t);
-#endif
+#endif // defined CONFIG_NET_ENABLE_PTP
 void AcdProbe(ip4_addr_t ipaddr);
 void AcdSendAnnouncement(ip4_addr_t ipaddr);
 } // namespace network::arp

lib-network/include/core/netif.h

@@ -32,7 +32,7 @@
 
 #ifndef NETIF_MAX_HWADDR_LEN
 #define NETIF_MAX_HWADDR_LEN 6U
-#endif
+#endif // NETIF_MAX_HWADDR_LEN
 
 namespace netif {
 

lib-network/include/core/protocol/arp.h

@@ -33,7 +33,7 @@
 
 #if !defined(PACKED)
 #define PACKED __attribute__((packed))
-#endif
+#endif // PACKED
 
 namespace network::arp {
 inline constexpr uint16_t kHwtypeEthernet = 1;

lib-network/include/core/protocol/icmp.h

@@ -33,7 +33,7 @@
 
 #if !defined(PACKED)
 #define PACKED __attribute__((packed))
-#endif
+#endif // PACKED
 
 namespace network::icmp {
 struct Type {

lib-network/include/core/protocol/igmp.h

@@ -33,7 +33,7 @@
 
 #if !defined(PACKED)
 #define PACKED __attribute__((packed))
-#endif
+#endif // PACKED
 
 namespace network::igmp {
 struct Type {

lib-network/include/core/protocol/ip4.h

@@ -31,7 +31,7 @@
 
 #if !defined(PACKED)
 #define PACKED __attribute__((packed))
-#endif
+#endif // PACKED
 
 namespace network::ip4 {
 inline constexpr uint32_t kAddressLength = 4;

lib-network/include/core/protocol/ntp.h

@@ -101,4 +101,4 @@ inline void SubTime(struct ntp::Time* r, const struct ntp::Time* x, const struct
 }
 } // namespace ntp
 
-#endif /* CORE_PROTOCOL_NTP_H_ */
+#endif // CORE_PROTOCOL_NTP_H_

lib-network/include/core/protocol/tcp.h

@@ -33,7 +33,7 @@
 
 #if !defined(PACKED)
 #define PACKED __attribute__((packed))
-#endif
+#endif // PACKED
 
 namespace network::tcp {
 

lib-network/include/core/protocol/udp.h

@@ -33,7 +33,7 @@
 
 #if !defined(PACKED)
 #define PACKED __attribute__((packed))
-#endif
+#endif // PACKED
 
 namespace network::udp {