Skip to content

Commit b47ee28

Browse files
committed
Centralize PHY define and drop RTL8201 LED flag
Move `PHY_TYPE=$(ENET_PHY)` into shared `DEFINES` in `firmware-template-gd32/lib/Rules.mk` and remove it from `COPS` so PHY selection is handled consistently through the define list. Also remove `RTL8201F_LED1_LINK_ALL` from the Art-Net pixel multi and E1.31 DMX multi build configs to stop forcing that PHY-specific LED behavior in those targets.
1 parent b86a4dc commit b47ee28

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

firmware-template-gd32/lib/Rules.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ $(info $$ENET_PHY [${ENET_PHY}])
2121
SRCDIR=src src/gd32 $(EXTRA_SRCDIR)
2222

2323
DEFINES:=$(addprefix -D,$(DEFINES))
24+
DEFINES+=-DPHY_TYPE=$(ENET_PHY)
2425

2526
include ../common/make/gd32/Board.mk
2627
include ../common/make/gd32/Mcu.mk
@@ -32,7 +33,7 @@ include ../common/make/gd32/Validate.mk
3233

3334
INCLUDES+=-I../lib-configstore/include -I../lib-device/include -I../lib-display/include -I../lib-flash/include -I../lib-flashcode/include -I../lib-board/include -I../lib-network/include
3435

35-
COPS=-DGD32 -D$(FAMILY_UCA) -D$(LINE_UC) -D$(MCU) -D$(BOARD) -DPHY_TYPE=$(ENET_PHY)
36+
COPS=-DGD32 -D$(FAMILY_UCA) -D$(LINE_UC) -D$(MCU) -D$(BOARD)
3637
COPS+=$(strip $(DEFINES) $(MAKE_FLAGS) $(VALIDATE_FLAGS) $(INCLUDES))
3738
COPS+=$(strip $(ARMOPS) $(CMSISOPS))
3839
COPS+=-Os -nostartfiles -ffreestanding -nostdlib

gd32_emac_e131_dmx_multi/Common.mk

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ DEFINES+=NODE_RDMNET_LLRP_ONLY
22

33
DEFINES+=CONFIG_STORE_USE_SPI
44

5-
DEFINES+=RTL8201F_LED1_LINK_ALL
6-
75
DEFINES+=DISPLAY_UDF
86

97
DEFINES+=ENABLE_HTTPD

0 commit comments

Comments
 (0)