Skip to content

Commit 2d42d4a

Browse files
committed
Unify undefined labels and JSON guards
Adds a shared `common::kUndefined` string and replaces scattered literal "Undefined" fallbacks across DMX, RDM, LTC, and MIDI-related code. The remote config JSON endpoints now enforce non-null/non-zero output buffers with assertions, and several small consistency cleanups were applied (macro style `#ifdef`, Art-Net node ID print usage, and minor formatting/log message tidy-ups).
1 parent 36d90db commit 2d42d4a

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

common/include/common/utils/utils_string.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ inline constexpr char kWarning[] = "Warning";
3333
inline constexpr char kError[] = "Error";
3434
inline constexpr char kSuccess[] = "Success";
3535
inline constexpr char kUnknown[] = "Unknown";
36+
inline constexpr char kUndefined[] = "Undefined";
3637

3738
constexpr const char* IsSuccess(bool is_success) {
3839
return is_success ? kSuccess : kError;

lib-network/src/core/network_memory.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ class Allocator {
8787

8888
uint8_t* Allocate() {
8989
if (IsFull()) {
90-
ERROR("Allocate:Full!");
90+
ERROR("Full");
9191
return nullptr;
9292
}
9393

@@ -105,7 +105,7 @@ class Allocator {
105105
assert(size <= kBlockSize);
106106

107107
if (IsFull()) {
108-
ERROR("Allocate:Full!");
108+
ERROR("Full");
109109
return UINT16_MAX;
110110
}
111111

0 commit comments

Comments
 (0)