Refactor board/panelled APIs and rename files

Move and rename board and panel LED APIs into common modules and update usages across the codebase. Key changes:
- Rename hal_boardinfo.h -> common/include/board.h and hal_boardinfo.cpp -> lib-gd32/src/board.cpp; introduce board namespace (replacing hal), add BootDevice enum and new board helpers (Init, Reboot, RebootHandler, GetBootDevice, CoreTemperatureMin/Max/Current, Website).
- Rename hal_panelled header/source to panelled.h/.cpp and remove old hal_panelled.h; switch namespace usages from hal::panelled to panelled and update callers.
- Update includes (firmwareversion, hal.h, hal_init, hal_statusled, etc.) to use new headers and symbols.
- Delete unused hwclockrtc.cpp and adjust remoteconfig to skip display messages before calling reboot.
- Misc: formatting/brace style changes, small debug/log additions (Show), inline constexpr adjustments, and pixel/ArtNet handler formatting fixes.
These changes consolidate board/panel LED APIs, simplify namespaces, and harmonize file locations.

Author: vanvught

lib-hal/include/hal_boardinfo.h common/include/board.hlib-hal/include/hal_boardinfo.h renamed to common/include/board.h

@@ -1,8 +1,8 @@
 /**
- * @file hal_boardinfo.h
+ * @file board.h
  *
  */
-/* Copyright (C) 2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -23,18 +23,31 @@
  * THE SOFTWARE.
  */
 
-#ifndef HAL_BOARDINFO_H_
-#define HAL_BOARDINFO_H_
+#ifndef BOARD_H_
+#define BOARD_H_
 
 #include <cstdint>
 
-namespace hal
-{
+namespace board {
+enum class BootDevice { kUnkown, kFel, kMmc0, kSpi, kHdd, kFlash, kRam };
+
+void Init();
+bool Reboot();
+void RebootHandler();
+
+BootDevice GetBootDevice();
+
 const char* BoardName(uint8_t& length);
 const char* SocName(uint8_t& length);
 const char* CpuName(uint8_t& length);
-const char* SysName(uint8_t& length);
 const char* MachineName(uint8_t& length);
-} // namespace hal
+const char* SysName(uint8_t& length);
+
+float CoreTemperatureMin();
+float CoreTemperatureMax();
+float CoreTemperatureCurrent();
+
+const char* Website();
+} // namespace board
 
-#endif  // HAL_BOARDINFO_H_
+#endif // BOARD_H_

common/include/firmware/artnet/pixel/artnettriggerhandler.h

@@ -35,11 +35,9 @@
 #include "pixeldmxconfiguration.h"
 #include "displayudf.h"
 
-class ArtNetTriggerHandler : ArtNetTrigger
-{
+class ArtNetTriggerHandler : ArtNetTrigger {
    public:
-    explicit ArtNetTriggerHandler(DmxNodeOutputType* output_type) : dmxnode_output_type_(output_type)
-    {
+    explicit ArtNetTriggerHandler(DmxNodeOutputType* output_type) : dmxnode_output_type_(output_type) {
         assert(s_this == nullptr);
         s_this = this;
 
@@ -48,68 +46,55 @@ class ArtNetTriggerHandler : ArtNetTrigger
 
     ~ArtNetTriggerHandler() = default;
 
-    void static StaticCallbackFunction(const ArtNetTrigger* trigger)
-    {
+    void static StaticCallbackFunction(const ArtNetTrigger* trigger) {
         assert(s_this != nullptr);
         s_this->Handler(trigger);
     }
 
    private:
-    void Handler(const ArtNetTrigger* trigger)
-    {
-        if (trigger->key == ArtTriggerKey::kArtTriggerKeyShow)
-        {
+    void Handler(const ArtNetTrigger* trigger) {
+        if (trigger->key == ArtTriggerKey::kArtTriggerKeyShow) {
             ArtNetNode::Get()->SetOutput(dmxnode_output_type_);
 
             const auto kShow = static_cast<pixelpatterns::Pattern>(trigger->sub_key);
 
-            if (kShow == PixelTestPattern::Get()->GetPattern())
-            {
+            if (kShow == PixelTestPattern::Get()->GetPattern()) {
                 return;
             }
 
             const auto kIsSet = PixelTestPattern::Get()->SetPattern(kShow);
 
-            if (!kIsSet)
-            {
+            if (!kIsSet) {
                 return;
             }
 
-            if (static_cast<pixelpatterns::Pattern>(kShow) != pixelpatterns::Pattern::kNone)
-            {
+            if (static_cast<pixelpatterns::Pattern>(kShow) != pixelpatterns::Pattern::kNone) {
                 ArtNetNode::Get()->SetOutput(nullptr);
                 Display::Get()->ClearLine(6);
                 Display::Get()->Printf(6, "%s:%u", PixelPatterns::GetName(kShow), static_cast<uint32_t>(kShow));
-            }
-            else
-            {
+            } else {
                 dmxnode_output_type_->Blackout(true);
                 DisplayUdf::Get()->Show();
             }
 
             return;
         }
 
-        if (trigger->key == ArtTriggerKey::kArtTriggerUndefined)
-        {
-            if (trigger->sub_key == 0)
-            {
+        if (trigger->key == ArtTriggerKey::kArtTriggerUndefined) {
+            if (trigger->sub_key == 0) {
                 const auto kIsSet = PixelTestPattern::Get()->SetPattern(pixelpatterns::Pattern::kNone);
 
-                if (!kIsSet)
-                {
+                if (!kIsSet) {
                     return;
                 }
 
                 ArtNetNode::Get()->SetOutput(nullptr);
 
                 auto& configuration = PixelDmxConfiguration::Get();
                 const auto* trigger_data = &trigger->data[0];
-                const uint32_t kColour = trigger_data[0] | (static_cast<uint32_t>(trigger_data[1]) << 8) | (static_cast<uint32_t>(trigger_data[2]) << 16) |
-                                         (static_cast<uint32_t>(trigger_data[3]) << 24);
+                const uint32_t kColour = trigger_data[0] | (static_cast<uint32_t>(trigger_data[1]) << 8) | (static_cast<uint32_t>(trigger_data[2]) << 16) | (static_cast<uint32_t>(trigger_data[3]) << 24);
 
-                for (uint32_t active_port = 0; active_port < configuration.GetOutputPorts(); active_port++)
-                {
+                for (uint32_t active_port = 0; active_port < configuration.GetOutputPorts(); active_port++) {
                     pixel::SetPixelColour(active_port, kColour);
                 }
 

common/include/firmware/pixeldmx/show.h

@@ -29,25 +29,34 @@
 #include <cstdint>
 
 #include "pixeldmxconfiguration.h"
-#include "display.h"
+#include "display.h" // IWYU pragma: keep
 #include "pixelpatterns.h"
+#include "firmware/debug/debug_debug.h"
 
 namespace common::firmware::pixeldmx {
-inline void Show(uint32_t line, pixelpatterns::Pattern pattern = pixelpatterns::Pattern::kNone) {
+inline void Show(uint32_t line, pixelpatterns::Pattern pattern) {
+	DEBUG_PRINTF("line=%u, pattern=%u", line, static_cast<uint32_t>(pattern));
+	
     auto& configuration = PixelDmxConfiguration::Get();
     auto* display = Display::Get();
     assert(display != nullptr);
 
     display->ClearEndOfLine();
     display->Printf(line, "%s:%d G%d %s", 
 		pixel::GetTypeName(configuration.GetType()), 
-		configuration.GetCount(), configuration.GetGroupingCount(), 
-		pixel::GetMapName(configuration.GetMap()));
+		configuration.GetCount(), 
+		configuration.GetGroupingCount(), 
+		pixel::GetMapName(configuration.GetMap())
+	);
+
     display->ClearLine(8); // Status line
 
+    display->ClearLine(6);
     if (pattern != pixelpatterns::Pattern::kNone) {
-        display->ClearLine(6);
-        display->Printf(6, "%s:%u", PixelPatterns::GetName(pattern), static_cast<uint32_t>(pattern));
+        display->Printf(6, "%s:%u", 
+			PixelPatterns::GetName(pattern), 
+			static_cast<uint32_t>(pattern)
+		);
     }
 }
 } // namespace common::firmware::pixeldmx

lib-gd32/include/board/16x4u-pixel.h

@@ -112,7 +112,7 @@
 // Panel LEDs
 #ifdef __cplusplus
 #include <cstdint>
-namespace hal::panelled {
+namespace panelled {
 inline constexpr uint32_t kActivity = 0;
 inline constexpr uint32_t kArtnet = 0;
 inline constexpr uint32_t kDdp = 0;
@@ -127,7 +127,7 @@ inline constexpr uint32_t kTcnet = 0;
 // DMX
 static constexpr uint32_t kPortARx = 0;
 static constexpr uint32_t kPortATx = 0;
-} // namespace hal::panelled
+} // namespace panelled
 #endif
 
 /**

lib-gd32/include/board/bw_opidmx4.h

@@ -117,7 +117,7 @@
 // Panel LEDs
 #ifdef __cplusplus
 #include <cstdint>
-namespace hal::panelled {
+namespace panelled {
 inline constexpr uint32_t kActivity = 0;
 inline constexpr uint32_t kArtnet = 0;
 inline constexpr uint32_t kDdp = 0;
@@ -132,7 +132,7 @@ inline constexpr uint32_t kTcnet = 0;
 // DMX
 static constexpr uint32_t kPortARx = 0;
 static constexpr uint32_t kPortATx = 0;
-} // namespace hal::panelled
+} // namespace panelled
 #endif
 
 /**

lib-gd32/include/board/dmx3.h

@@ -112,7 +112,7 @@
 
 // Panel LEDs
 #ifdef __cplusplus
-namespace hal::panelled {
+namespace panelled {
 inline constexpr uint32_t kActivity = 0;
 inline constexpr uint32_t kArtnet = 0;
 inline constexpr uint32_t kDdp = 0;
@@ -129,7 +129,7 @@ inline constexpr uint32_t kPortATx = (1U << 0);
 inline constexpr uint32_t kPortARx = (1U << 8);
 #define CONFIG_PANELLED_RDM_PORT
 inline constexpr uint32_t kPortARdm = (1U << 16);
-} // namespace hal::panelled
+} // namespace panelled
 #endif
 
 #define PANELLED_595_COUNT			2

lib-gd32/include/board/dmx4.h

@@ -116,7 +116,7 @@
 
 // Panel LEDs
 #ifdef __cplusplus
-namespace hal::panelled {
+namespace panelled {
 inline constexpr uint32_t kActivity = 0;
 inline constexpr uint32_t kArtnet = 0;
 inline constexpr uint32_t kDdp = 0;
@@ -133,7 +133,7 @@ inline constexpr uint32_t kPortATx = (1U << 0);
 inline constexpr uint32_t kPortARx = (1U << 8);
 #define CONFIG_PANELLED_RDM_PORT
 inline constexpr uint32_t kPortARdm = (1U << 16);
-} // namespace hal::panelled
+} // namespace panelled
 #endif
 
 #define PANELLED_595_COUNT			2

lib-gd32/include/board/gd32f407re.h

@@ -162,7 +162,7 @@
 // Panel LEDs
 #ifdef __cplusplus
 #include <cstdint>
-namespace hal::panelled {
+namespace panelled {
 inline constexpr uint32_t kActivity = 0;
 inline constexpr uint32_t kArtnet = 0;
 inline constexpr uint32_t kDdp = 0;
@@ -177,7 +177,7 @@ inline constexpr uint32_t kTcnet = 0;
 // DMX
 static constexpr uint32_t kPortARx = 0;
 static constexpr uint32_t kPortATx = 0;
-} // namespace hal::panelled
+} // namespace panelled
 #endif
 
 /**

lib-gd32/include/board/gd32f450vi.h

@@ -121,7 +121,7 @@
  // Panel LEDs
  #ifdef __cplusplus
  #include <cstdint>
- namespace hal::panelled {
+ namespace panelled {
  inline constexpr uint32_t kActivity = 0;
  inline constexpr uint32_t kArtnet = 0;
  inline constexpr uint32_t kDdp = 0;
@@ -136,7 +136,7 @@
  // DMX
  static constexpr uint32_t kPortARx = 0;
  static constexpr uint32_t kPortATx = 0;
- } // namespace hal::panelled
+ } // namespace panelled
  #endif
 
 /**

lib-hal/include/gd32/hal_panelled.h lib-gd32/include/panelled.hlib-hal/include/gd32/hal_panelled.h renamed to lib-gd32/include/panelled.h

@@ -1,5 +1,5 @@
 /**
- * @file hal_panelled.h
+ * @file panelled.h
  *
  */
 /* Copyright (C) 2023-2026 by Arjan van Vught mailto:info@gd32-dmx.org
@@ -23,16 +23,16 @@
  * THE SOFTWARE.
  */
 
-#ifndef GD32_HAL_PANELLED_H_
-#define GD32_HAL_PANELLED_H_
+#ifndef PANELLED_H_
+#define PANELLED_H_
 
 #include <cstdint>
 
 #if defined(PANELLED_595_COUNT)
 #include "gd32.h"
 #endif
 
-namespace hal::panelled {
+namespace panelled {
 namespace global {
 extern uint32_t data;
 }
@@ -117,6 +117,6 @@ inline void Run() {
 
 #endif
 }
-} // namespace hal::panelled
+} // namespace panelled
 
-#endif // GD32_HAL_PANELLED_H_
+#endif // PANELLED_H_