Clean up GD32 flash/PTP debug logging

Normalizes flash state enum names in the H7 flashcode path, tightens debug format usage with explicit casts, and keeps the GD32 include for IWYU. Also adds the missing GD32F450 9VEE (512KB) device mapping in gd32.json and introduces a new gd32_debug.h header.

Author: vanvught

common/scripts/gd32/gd32.json

@@ -51,6 +51,12 @@
           "512": "GD32F407XEXX"
         }
       },
+      "9VEE": {
+        "series": "GD32F450",
+        "flash": {
+          "512": "GD32F450VEXX"
+        }
+      },
       "9VIE": {
         "series": "GD32F450",
         "flash": {

lib-flashcode/src/gd32/h7xx/flashcode.cpp

@@ -24,12 +24,11 @@
  */
 
 #include <cstdint>
-#include <stdio.h>
 #include <cstring>
 #include <cassert>
 
 #include "flashcode.h"
-#include "gd32.h"
+#include "gd32.h" // IWYU pragma: keep
 #include "firmware/debug/debug_debug.h"
 
 namespace {
@@ -38,7 +37,7 @@ constexpr auto kFlashSectorSize = 4096U;
 // The flash page size is 4KB for bank1
 constexpr auto kBanK1FlashPage = (4U * 1024U);
 
-enum class State { kIdle, ERASE_BUSY, ERASE_PROGAM, WRITE_BUSY, WRITE_PROGRAM, ERROR };
+enum class State { kIdle, kEraseBusy, kEraseProgam, kWriteBusy, kWriteProgram, kError };
 
 State s_state = State::kIdle;
 uint32_t s_page;
@@ -60,7 +59,7 @@ uint32_t FlashCode::GetSectorSize() const {
 
 bool FlashCode::Read(uint32_t offset, uint32_t length, uint8_t* buffer, Result& result) {
     DEBUG_ENTRY();
-    DEBUG_PRINTF("offset=%p[%d], len=%u[%d], data=%p[%d]", offset, (((uint32_t)(offset) & 0x3) == 0), length, (((uint32_t)(length) & 0x3) == 0), buffer, (((uint32_t)(buffer) & 0x3) == 0));
+    DEBUG_PRINTF("offset=%x, len=%u, data=%p", static_cast<unsigned>(offset), static_cast<unsigned>(length), reinterpret_cast<void*>(buffer));
 
     const auto* src = reinterpret_cast<uint32_t*>(offset + FLASH_BASE);
     auto* dst = reinterpret_cast<uint32_t*>(buffer);
@@ -87,11 +86,11 @@ bool FlashCode::Erase(uint32_t offset, uint32_t length, flashcode::Result& resul
             s_page = offset + FLASH_BASE;
             s_length = length;
             fmc_unlock();
-            s_state = State::ERASE_BUSY;
+            s_state = State::kEraseBusy;
             DEBUG_EXIT();
             return false;
             break;
-        case State::ERASE_BUSY:
+        case State::kEraseBusy:
             if (SET == fmc_flag_get(FMC_FLAG_BUSY)) {
                 DEBUG_EXIT();
                 return false;
@@ -104,21 +103,21 @@ bool FlashCode::Erase(uint32_t offset, uint32_t length, flashcode::Result& resul
                 return true;
             }
 
-            s_state = State::ERASE_PROGAM;
+            s_state = State::kEraseProgam;
             DEBUG_EXIT();
             return false;
             break;
-        case State::ERASE_PROGAM:
+        case State::kEraseProgam:
             if (s_length > 0) {
-                DEBUG_PRINTF("s_nPage=%p", s_page);
+                DEBUG_PRINTF("s_page=%p", reinterpret_cast<void*>(s_page));
 
                 fmc_sector_erase(s_page);
 
                 s_length -= kBanK1FlashPage;
                 s_page += kBanK1FlashPage;
             }
 
-            s_state = State::ERASE_BUSY;
+            s_state = State::kEraseBusy;
             DEBUG_EXIT();
             return false;
             break;
@@ -134,7 +133,7 @@ bool FlashCode::Erase(uint32_t offset, uint32_t length, flashcode::Result& resul
 }
 
 bool FlashCode::Write(uint32_t offset, uint32_t length, const uint8_t* buffer, flashcode::Result& result) {
-    if ((s_state == State::WRITE_PROGRAM) || (s_state == State::WRITE_BUSY)) {
+    if ((s_state == State::kWriteProgram) || (s_state == State::kWriteBusy)) {
     } else {
         DEBUG_ENTRY();
     }
@@ -147,11 +146,11 @@ bool FlashCode::Write(uint32_t offset, uint32_t length, const uint8_t* buffer, f
             s_data = const_cast<uint32_t*>(reinterpret_cast<const uint32_t*>(buffer));
             s_length = length;
             fmc_unlock();
-            s_state = State::WRITE_BUSY;
+            s_state = State::kWriteBusy;
             DEBUG_EXIT();
             return false;
             break;
-        case State::WRITE_BUSY:
+        case State::kWriteBusy:
             if (SET == fmc_flag_get(FMC_FLAG_BUSY)) {
                 DEBUG_EXIT();
                 return false;
@@ -171,10 +170,10 @@ bool FlashCode::Write(uint32_t offset, uint32_t length, const uint8_t* buffer, f
                 return true;
             }
 
-            s_state = State::WRITE_PROGRAM;
+            s_state = State::kWriteProgram;
             return false;
             break;
-        case State::WRITE_PROGRAM:
+        case State::kWriteProgram:
             if (s_length >= 4) {
                 if (FMC_READY == fmc_ready_wait(0xFF)) {
                     /* set the PG bit to start program */
@@ -193,7 +192,7 @@ bool FlashCode::Write(uint32_t offset, uint32_t length, const uint8_t* buffer, f
             } else if (s_length > 0) {
                 DEBUG_PUTS("Error!");
             }
-            s_state = State::WRITE_BUSY;
+            s_state = State::kWriteBusy;
             return false;
             break;
         default:

lib-gd32/device/enet/ptp/gd32_ptp.cpp

@@ -93,7 +93,7 @@ void Gd32PtpStart() {
     DEBUG_ENTRY();
     DEBUG_PRINTF("PTP_TICK=%u", gd32::ptp::kPtpTick);
     DEBUG_PRINTF("ADJ_FREQ_BASE_INCREMENT=%u", gd32::ptp::kAdjFreqBaseIncrement);
-    DEBUG_PRINTF("ADJ_FREQ_BASE_ADDEND=x%X", gd32::ptp::kAdjFreqBaseAddend);
+    DEBUG_PRINTF("ADJ_FREQ_BASE_ADDEND=x%X", static_cast<unsigned>(gd32::ptp::kAdjFreqBaseAddend));
 
     struct tm tmbuf;
     memset(&tmbuf, 0, sizeof(struct tm));

lib-gd32/include/gd32_debug.h

@@ -0,0 +1,29 @@
+/**
+ * @file gd32_debug.h
+ *
+ */
+/* Copyright (C) 2026 by Arjan van Vught mailto:info@gd32-dmx.org
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+#ifndef GD32_DEBUG_H_
+#define GD32_DEBUG_H_
+
+#endif // GD32_DEBUG_H_