Add config guards and tidy storedevice files

Update storedevice implementations across GD32 RAM/ROM, I2C and SPI backends: bump copyright years to 2026, add preprocessor checks to error on mutually-exclusive storage backend defines, enable DEBUG_CONFIGSTORE to undef NDEBUG, standardize destructor formatting (split single-line bodies), and add IWYU pragmas/comment cleanup for includes. These changes prevent misconfiguration, improve debug behavior, and unify style/formatting across the storage device drivers.

Author: vanvught

common/make/gd32/Board.mk

@@ -17,12 +17,18 @@ endif
 ifeq ($(strip $(BOARD)),BOARD_GD32F107RC)
 	MCU=GD32F107RC
 	DEFINES+=-DCONFIG_STORE_USE_ROM
+	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_NONE
 endif
 
 ifeq ($(strip $(BOARD)),BOARD_GD32F207RG)
 	MCU=GD32F207RG
 	DEFINES+=-DCONFIG_STORE_USE_SPI
-	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_O2
+endif
+
+ifeq ($(strip $(BOARD)),BOARD_GD32F303CB)
+	MCU=GD32F303CB
+	DEFINES+=-DCONFIG_STORE_USE_ROM
+	DEFINES+=-DNO_EMAC
 endif
 
 ifeq ($(strip $(BOARD)),BOARD_GD32F303RC)
@@ -34,22 +40,20 @@ endif
 ifeq ($(strip $(BOARD)),BOARD_GD32F407RE)
 	MCU=GD32F407RE
 	DEFINES+=-DCONFIG_STORE_USE_SPI
-	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_O2
 endif
 
 ifeq ($(strip $(BOARD)),BOARD_GD32F450VI)
 	MCU=GD32F450VI
-	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_O2
 endif
 
 ifeq ($(strip $(BOARD)),BOARD_16X4U_PIXEL)
 	MCU=GD32F450VI
-	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_O2
+	DEFINES+=-DCONFIG_STORE_USE_SPI
 endif
 
 ifeq ($(strip $(BOARD)),BOARD_GD32F470VG)
 	MCU=GD32F470VG
-	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_O2
+	DEFINES+=-DCONFIG_STORE_USE_SPI
 endif
 
 ifeq ($(strip $(BOARD)),BOARD_GD32F207C_EVAL)
@@ -70,19 +74,16 @@ endif
 ifeq ($(strip $(BOARD)),BOARD_BW_OPIDMX4)
 	BOARD_DMX=4
 	DEFINES+=-DCONFIG_STORE_USE_SPI
-	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_O2
 endif
 
 ifeq ($(strip $(BOARD)),BOARD_DMX3)
 	BOARD_DMX=3
 	DEFINES+=-DCONFIG_STORE_USE_SPI
-	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_O2
 endif
 
 ifeq ($(strip $(BOARD)),BOARD_DMX4)
-	BOARD_DMX=4
 	DEFINES+=-DCONFIG_STORE_USE_SPI
-	DEFINES+=-DCONFIG_HTTPD_OPTIMIZE_O2
+	BOARD_DMX=4
 endif
 
 ifdef BOARD_DMX

lib-configstore/device/gd32/ram/storedevice.cpp

@@ -2,7 +2,7 @@
  * @file storedevice.cpp
  *
  */
-/* Copyright (C) 2022-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2022-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -23,13 +23,20 @@
  * THE SOFTWARE.
  */
 
+#if defined(CONFIG_STORE_USE_SPI) || defined(CONFIG_STORE_USE_I2C) || defined(CONFIG_STORE_USE_ROM)
+#error Configuration error
+#endif
+
+#if defined(DEBUG_CONFIGSTORE)
+#undef NDEBUG
+#endif
+
 #include <cstdint>
 #include <cstdio>
 #include <cassert>
 
 #include "configstoredevice.h"
-#include "gd32.h"
-
+#include "gd32.h" // IWYU pragma: keep
 #include "firmware/debug/debug_debug.h"
 
 static constexpr uint32_t kFlashSectorSize = 4096U;
@@ -45,9 +52,12 @@ StoreDevice::StoreDevice()
     DEBUG_EXIT();
 }
 
-StoreDevice::~StoreDevice(){DEBUG_ENTRY();
+StoreDevice::~StoreDevice()
+{
+    DEBUG_ENTRY();
 
-                                DEBUG_EXIT();}
+    DEBUG_EXIT();
+}
 
 uint32_t StoreDevice::GetSize() const
 {

lib-configstore/device/gd32/rom/storedevice.cpp

@@ -2,7 +2,7 @@
  * @file storedevice.cpp
  *
  */
-/* Copyright (C) 2022-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2022-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -23,6 +23,14 @@
  * THE SOFTWARE.
  */
 
+#if defined(CONFIG_STORE_USE_SPI) || defined(CONFIG_STORE_USE_I2C) || defined(CONFIG_STORE_USE_RAM)
+#error Configuration error
+#endif
+
+#if defined(DEBUG_CONFIGSTORE)
+#undef NDEBUG
+#endif
+
 #include <cstdint>
 
 #include "configstoredevice.h"
@@ -40,8 +48,8 @@ StoreDevice::StoreDevice()
 
 StoreDevice::~StoreDevice()
 {
-  DEBUG_ENTRY();
-  DEBUG_EXIT();
+    DEBUG_ENTRY();
+    DEBUG_EXIT();
 }
 
 uint32_t StoreDevice::GetSize() const

lib-configstore/device/i2c/storedevice.cpp

@@ -23,6 +23,10 @@
  * THE SOFTWARE.
  */
 
+#if defined(CONFIG_STORE_USE_SPI) || defined(CONFIG_STORE_USE_ROM) || defined(CONFIG_STORE_USE_RAM)
+#error Configuration error
+#endif
+
 #if defined(DEBUG_CONFIGSTORE)
 #undef NDEBUG
 #endif
@@ -32,8 +36,8 @@
 #include <cassert>
 
 #include "configstoredevice.h"
-#include "i2c/at24cxx.h"
- #include "firmware/debug/debug_debug.h"
+#include "i2c/at24cxx.h" // IWYU pragma: keep
+#include "firmware/debug/debug_debug.h"
 
 namespace storedevice
 {
@@ -64,7 +68,11 @@ StoreDevice::StoreDevice() : AT24C32(storedevice::kI2CIndex)
     DEBUG_EXIT();
 }
 
-StoreDevice::~StoreDevice(){DEBUG_ENTRY(); DEBUG_EXIT();}
+StoreDevice::~StoreDevice()
+{
+    DEBUG_ENTRY();
+    DEBUG_EXIT();
+}
 
 uint32_t StoreDevice::GetSize() const
 {

lib-configstore/device/spi/storedevice.cpp

@@ -2,7 +2,7 @@
  * @file storedevice.cpp
  *
  */
-/* Copyright (C) 2022-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2022-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -23,6 +23,10 @@
  * THE SOFTWARE.
  */
 
+#if defined(CONFIG_STORE_USE_I2C) || defined(CONFIG_STORE_USE_ROM) || defined(CONFIG_STORE_USE_RAM)
+#error Configuration error
+#endif
+
 #if defined(DEBUG_CONFIGSTORE)
 #undef NDEBUG
 #endif
@@ -32,7 +36,7 @@
 
 #include "configstoredevice.h"
 #include "spi/spi_flash.h"
- #include "firmware/debug/debug_debug.h"
+#include "firmware/debug/debug_debug.h"
 
 StoreDevice::StoreDevice()
 {
@@ -52,7 +56,11 @@ StoreDevice::StoreDevice()
     DEBUG_EXIT();
 }
 
-StoreDevice::~StoreDevice(){DEBUG_ENTRY(); DEBUG_EXIT();}
+StoreDevice::~StoreDevice()
+{
+    DEBUG_ENTRY();
+    DEBUG_EXIT();
+}
 
 uint32_t StoreDevice::GetSize() const
 {