Refine GD32 build flags and debug bit printing

Updates GD32 make rules to better control networking-related defines: add UDP/RTC restrictions for `CONFIG_REMOTECONFIG_MINIMUM`, introduce RTL8201F-specific link-check behavior (interrupt vs polling), and centralize `PHY_TYPE` via `DEFINES` to avoid duplication in compiler options. It also enhances `debug::PrintBits` with an optional label and `0x`-prefixed hex output, plus small readability-only cleanups in `Atof` and `asctime`.

Author: vanvught

common/include/common/utils/utils_string.h

@@ -81,7 +81,7 @@ inline float Atof(const char* buffer, uint32_t size) {
     }
 
     while (size > 0 && *p >= '0' && *p <= '9') {
-        result = result * 10.0F + static_cast<float>(*p - '0');
+        result = (result * 10.0F) + static_cast<float>(*p - '0');
         ++p;
         --size;
     }

common/include/firmware/debug/debug_printbits.h

@@ -35,7 +35,7 @@
 namespace debug {
 template <typename T>
     requires std::unsigned_integral<T>
-inline void PrintBits(T value) {
+inline void PrintBits(T value, const char* string = nullptr) {
     if constexpr (!config::kDumpEnabled) {
         return;
     }
@@ -46,7 +46,10 @@ inline void PrintBits(T value) {
 
     static_assert(sizeof(T) <= sizeof(unsigned));
 
-    printf("%.*x ", kHexDigits, static_cast<unsigned>(value));
+    if (string != nullptr) {
+        printf("%s :", string);
+    }
+    printf("0x%.*x ", kHexDigits, static_cast<unsigned>(value));
 
     for (int bit_number = kMaxBitIndex; bit_number >= 0; --bit_number) {
         const auto kMask = static_cast<T>(1) << bit_number;

common/make/gd32/Validate.mk

@@ -24,6 +24,8 @@ endif
 
 ifeq ($(findstring CONFIG_REMOTECONFIG_MINIMUM,$(FLAGS)),CONFIG_REMOTECONFIG_MINIMUM)
 	DEFINES+=-DCONFIG_NET_APPS_NO_MDNS
+	DEFINES+=-DCONFIG_UDP_NO_OPTIMIZE
+	DEFINES+=-DDISABLE_RTC
 else
   ifeq ($(findstring NO_EMAC,$(FLAGS)),NO_EMAC)
   else
@@ -56,8 +58,23 @@ ifdef FATFS_MKFS
 	DEFINES+=-DCONFIG_FATFS_MKFS
 endif
 
+# Hardware Scenario    Flag Condition              Resulting Compiler Definitions (DEFINES)
+# Using RTL8201F       ENET_LINK_CHECK is missing  -DRTL8201F_LED1_LINK_ALL  -DENET_LINK_CHECK_USE_INT (Uses Interrupts)
+# Using RTL8201F       ENET_LINK_CHECK is present  -DRTL8201F_LED1_LINK_ALL
+# Other Hardware       Any                         -DENET_LINK_CHECK_REG_POLL (Uses Polling)
+
+ifneq ($(findstring RTL8201F,$(FLAGS)),)
+	DEFINES+=-DRTL8201F_LED1_LINK_ALL
+	ifeq ($(findstring ENET_LINK_CHECK,$(FLAGS)),)
+		DEFINES+=-DENET_LINK_CHECK_USE_INT
+	endif
+else
+	DEFINES+=-DENET_LINK_CHECK_REG_POLL
+endif
+
 $(info $$DEFINES [${DEFINES}])
 
 DEFINES:= $(sort $(DEFINES))
 
 $(info $$DEFINES [${DEFINES}])
+

firmware-template-gd32/Rules.mk

@@ -24,7 +24,9 @@ FIRMWARE_DIR=./../firmware-template-gd32/
 PROJECT=$(notdir $(patsubst %/,%,$(CURDIR)))
 $(info $$PROJECT [${PROJECT}])
 
-DEFINES:=$(addprefix -D,$(DEFINES)) -DCONFIG_NETWORK_MEMORY_BLOCKS=1
+DEFINES:=$(addprefix -D,$(DEFINES))
+DEFINES+=-DCONFIG_NETWORK_MEMORY_BLOCKS=1
+DEFINES+=-DPHY_TYPE=$(ENET_PHY)
 
 include ../common/make/gd32/Board.mk
 include ../common/make/gd32/Mcu.mk
@@ -48,7 +50,7 @@ LDLIBS:=$(addprefix -l,$(LIBS))
 # The variables for the dependency check
 LIBDEP=$(addprefix ../lib-,$(LIBS))
 
-COPS=-DGD32 -D$(FAMILY_UCA) -D$(LINE_UC) -D$(MCU) -D$(BOARD) -DPHY_TYPE=$(ENET_PHY)
+COPS=-DGD32 -D$(FAMILY_UCA) -D$(LINE_UC) -D$(MCU) -D$(BOARD)
 COPS+=$(strip $(DEFINES) $(MAKE_FLAGS) $(INCLUDES) $(LIBINCDIRS))
 COPS+=$(strip $(ARMOPS) $(CMSISOPS))
 COPS+=-Os -nostartfiles -ffreestanding -nostdlib

lib-clib/src/asctime.cpp

@@ -35,7 +35,9 @@ static const char kWdayName[][4] = {"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "S
 static char s_buffer[kMaxAscTime + 1];
 
 extern "C" char* asctime(const struct tm* p_tm) {
-    if (!p_tm) return nullptr;
+    if (p_tm == nullptr) {
+        return nullptr;
+    }
 
     const char* const kWday = (p_tm->tm_wday >= 0 && p_tm->tm_wday <= 6) ? kWdayName[p_tm->tm_wday] : "???";
     const char* const kMon = (p_tm->tm_mon >= 0 && p_tm->tm_mon <= 11) ? kMonName[p_tm->tm_mon] : "???";