Replace HAL_I2C with I2c in display drivers

Swap out the legacy HAL_I2C implementation for the new I2c interface across display drivers (HD44780, SSD1306, SSD1311). Update includes, constructors and method calls to use I2c, adapt write/read/register calls, and adjust initialization and detection logic accordingly. Add a debug i2c detect header (common/include/firmware/debug/debug_i2cdetect.h) and introduce debug trace calls in display code. Remove obsolete lib-hal i2c headers/sources and bump copyright years to 2026. Also contains assorted formatting/namespace cleanups and small fixes to cursor/clear logic.

Author: vanvught

common/include/firmware/debug/debug_i2cdetect.h

@@ -0,0 +1,70 @@
+/**
+ * @file debug_i2cdetect.h
+ *
+ */
+/* Copyright (C) 2020-2026 by Arjan van Vught mailto:info@gd32-dmx.org
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+#ifndef FIRMWARE_DEBUG_DEBUG_I2CDETECT_H_
+#define FIRMWARE_DEBUG_DEBUG_I2CDETECT_H_
+
+#include <cstdint>
+#include <cstdio>
+
+#include "i2c.h"
+
+namespace debug::i2c {
+#ifndef DEBUG_I2C
+void Detect() {}
+#else
+inline constexpr uint32_t kFirst = 0x03;
+inline constexpr uint32_t kLast = 0x77;
+void Detect() {
+    ::i2c::Begin();
+    ::i2c::SetBaudrate(::i2c::kNormalSpeed);
+
+    puts("\n     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f");
+
+    for (uint32_t i = 0; i < 128; i = (i + 16)) {
+        printf("%02x: ", i);
+        for (uint32_t j = 0; j < 16; j++) {
+            // Skip unwanted addresses
+            if ((i + j < kFirst) || (i + j > kLast)) {
+                printf("   ");
+                continue;
+            }
+
+            if (::i2c::IsConnected(static_cast<uint8_t>(i + j))) {
+                printf("%02x ", i + j);
+            } else {
+                printf("-- ");
+            }
+        }
+
+        puts("");
+    }
+
+    ::i2c::Begin();
+}
+#endif
+} // namespace debug::i2c
+
+#endif // FIRMWARE_DEBUG_DEBUG_I2CDETECT_H_

lib-display/include/i2c/hd44780.h

@@ -2,7 +2,7 @@
  * @file hd44780.h
  *
  */
-/* Copyright (C) 2017-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2017-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -29,17 +29,15 @@
 #include <cstdint>
 
 #include "displayset.h"
-#include "hal_i2c.h"
+#include "i2c.h"
 
-namespace hd44780::pcf8574t
-{
+namespace hd44780::pcf8574t {
 inline constexpr uint8_t kDefaultAddress = 0x27;
 inline constexpr uint8_t kTC2004Address = kDefaultAddress;
 inline constexpr uint8_t kTC1602Address = 0x26;
 } // namespace hd44780::pcf8574t
 
-class Hd44780 final : public DisplaySet
-{
+class Hd44780 final : public DisplaySet {
    public:
     Hd44780();
     Hd44780(uint8_t cols, uint8_t rows);
@@ -67,7 +65,7 @@ class Hd44780 final : public DisplaySet
     void WriteReg(uint8_t reg);
 
    private:
-    HAL_I2C hal_i2c_;
+    I2c i2c_;
 };
 
-#endif  // I2C_HD44780_H_
+#endif // I2C_HD44780_H_

lib-display/include/i2c/ssd1306.h

@@ -2,7 +2,7 @@
  * @file ssd1306.h
  *
  */
-/* Copyright (C) 2017-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2017-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -29,25 +29,22 @@
 #include <cstdint>
 
 #include "displayset.h"
-#include "hal_i2c.h"
+#include "i2c.h"
 
 #define OLED_I2C_ADDRESS_DEFAULT 0x3C
 
-enum class OledPanel
-{
+enum class OledPanel {
     k128x648Rows, ///< Default
     k128x644Rows,
     k128x324Rows
 };
 
-class Ssd1306 final : public DisplaySet
-{
+class Ssd1306 final : public DisplaySet {
    public:
     Ssd1306();
     explicit Ssd1306(OledPanel);
     Ssd1306(uint8_t, OledPanel);
-    ~Ssd1306() override
-    {
+    ~Ssd1306() override {
 #if defined(CONFIG_DISPLAY_ENABLE_CURSOR_MODE)
         delete[] shadow_ram_;
         shadow_ram_ = nullptr;
@@ -93,7 +90,7 @@ class Ssd1306 final : public DisplaySet
     void DumpShadowRam();
 
    private:
-    HAL_I2C hal_i2c_;
+    I2c i2c_;
     OledPanel oled_panel_{OledPanel::k128x648Rows};
     bool have_sh1106_{false};
     uint32_t pages_;
@@ -111,4 +108,4 @@ class Ssd1306 final : public DisplaySet
     static inline Ssd1306* s_this;
 };
 
-#endif  // I2C_SSD1306_H_
+#endif // I2C_SSD1306_H_

lib-display/include/i2c/ssd1311.h

@@ -2,7 +2,7 @@
  * @file ssd1311.h
  *
  */
-/* Copyright (C) 2020-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2020-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -29,10 +29,9 @@
 #include <cstdint>
 
 #include "displayset.h"
-#include "hal_i2c.h"
+#include "i2c.h"
 
-class Ssd1311 final : public DisplaySet
-{
+class Ssd1311 final : public DisplaySet {
    public:
     Ssd1311();
     ~Ssd1311() override = default;
@@ -63,27 +62,19 @@ class Ssd1311 final : public DisplaySet
     void SelectRamRom(uint32_t ram, uint32_t rom);
     void SetDDRAM(uint8_t address);
     void SetCGRAM(uint8_t address);
-    enum class FunctionSet
-    {
-        kReZero = (0 << 1),
-        kReOne = (1 << 1)
-    };
+    enum class FunctionSet { kReZero = (0 << 1), kReOne = (1 << 1) };
     void SetRE(FunctionSet re);
-    enum class CommandSet
-    {
-        kDisabled = 0,
-        kEnabled = 1
-    };
+    enum class CommandSet { kDisabled = 0, kEnabled = 1 };
     void SetSD(CommandSet sd);
     void SendCommand(uint8_t command);
     void SendData(uint8_t data);
     void SendData(const uint8_t* data, uint32_t length);
 
    private:
-    HAL_I2C hal_i2_c_;
+    I2c i2c_;
     uint8_t display_control_{1U << 3}; // Section 9.1.4 Display ON/OFF Control
 
     static inline Ssd1311* s_this;
 };
 
-#endif  // I2C_SSD1311_H_
+#endif // I2C_SSD1311_H_