refactor: type replay input wiring

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c779ef78-f1e2-4b31-8c60-1b7fc8811ccb

Author: matteopolak

src/maps/map_ui.gd

@@ -24,26 +24,33 @@ func on_shot(mag_ammo: int, _reserve_ammo := 0) -> void:
 	ammo_label.text = "Ammo: %d / Inf" % [mag_ammo]
 
 func _ready() -> void:
-	var settings_manager = get_node("/root/Global").settings_manager
-	keybind_info_label.text = ("Press Ctrl to toggle UI\nPress %s to restart" % settings_manager.get_keybind_string("restart"))
+	keybind_info_label.text = ("Press Ctrl to toggle UI\nPress %s to restart" % Global.settings_manager.get_keybind_string("restart"))
 	done_replay_btn.pressed.connect(func() -> void: return_control_to_player.emit())
 
-	alt_speed_label.visible = settings_manager.value("Display", "speed")
+	alt_speed_label.visible = Global.settings_manager.value("Display", "speed")
 
 func set_frame(frame: int, total: int) -> void:
 	tick_label.text = "Tick: %d / %d" % [frame + 1, total]
 	replay_slider.value = frame
 	replay_slider.max_value = total - 1
 
-func set_replay_inputs(frame) -> void:
+func set_replay_inputs(
+		forward_input: bool,
+		back_input: bool,
+		left_input: bool,
+		right_input: bool,
+		shoot_input: bool,
+		ads_input: bool,
+		reload_input: bool,
+	) -> void:
 	replay_input_display.set_inputs(
-			frame.forward_input,
-			frame.back_input,
-			frame.left_input,
-			frame.right_input,
-			frame.shoot_input,
-			frame.ads_input,
-			frame.reload_input,
+			forward_input,
+			back_input,
+			left_input,
+			right_input,
+			shoot_input,
+			ads_input,
+			reload_input,
 	)
 
 func set_replay_visible(value: bool) -> void:

src/recorder.gd

@@ -103,7 +103,15 @@ func set_frame(value: int) -> void:
 	else:
 		map.map_ui.set_speed(speed)
 		map.map_ui.set_timer(current_frame * dt)
-		map.map_ui.set_replay_inputs(frame)
+		map.map_ui.set_replay_inputs(
+				frame.forward_input,
+				frame.back_input,
+				frame.left_input,
+				frame.right_input,
+				frame.shoot_input,
+				frame.ads_input,
+				frame.reload_input,
+		)
 
 	if prev_frame.weapon_index != frame.weapon_index:
 		controller.weapon_handler.set_weapon(Global.game_manager.get_weapon_from_index(frame.weapon_index), is_ghost)

tests/replay_input_display_test.gd

@@ -84,17 +84,8 @@ func _run() -> void:
 					"MapUi replay_input_display export should reference ReplayContainer/V/ReplayInputDisplay",
 			)
 
-			if t.check(map_ui.has_method("set_replay_inputs"), "MapUi should expose set_replay_inputs(Recorder.Frame)"):
-				var frame := _RecorderFrame.new()
-				frame.forward_input = true
-				frame.back_input = false
-				frame.left_input = false
-				frame.right_input = true
-				frame.shoot_input = false
-				frame.ads_input = true
-				frame.reload_input = false
-
-				map_ui.set_replay_inputs(frame)
+			if t.check(map_ui.has_method("set_replay_inputs"), "MapUi should expose set_replay_inputs(bool, bool, bool, bool, bool, bool, bool)"):
+				map_ui.set_replay_inputs(true, false, false, true, false, true, false)
 				if replay_input_display != null:
 					_check_input_state(t, replay_input_display, &"forward", true)
 					_check_input_state(t, replay_input_display, &"right", true)
@@ -126,12 +117,3 @@ func _panel_stylebox(replay_input_display: Node, label_path: String) -> StyleBox
 
 	var parent_control := label.get_parent() as Control
 	return parent_control.get_theme_stylebox("panel") if parent_control != null else null
-
-class _RecorderFrame:
-	var forward_input: bool
-	var back_input: bool
-	var left_input: bool
-	var right_input: bool
-	var shoot_input: bool
-	var ads_input: bool
-	var reload_input: bool