Skip to content

Use the upstream extracted Go SDK for XenOrchestra - #174

Closed
ringods wants to merge 3 commits into
masterfrom
upstream-xo-sdk
Closed

Use the upstream extracted Go SDK for XenOrchestra#174
ringods wants to merge 3 commits into
masterfrom
upstream-xo-sdk

Conversation

@ringods

@ringods ringods commented Nov 17, 2021

Copy link
Copy Markdown
Contributor

Fixes #173

The Go SDK for XenOrchestra has been extracted to https://github.com/vatesfr/xo-sdk-go. In this pull request, I change this TF provider to start using this extracted provider.

Signed-off-by: Ringo De Smet <ringo@de-smet.name>
Signed-off-by: Ringo De Smet <ringo@de-smet.name>
@ringods
ringods requested a review from ddelnano November 17, 2021 18:47
Signed-off-by: Ringo De Smet <ringo@de-smet.name>
@ddelnano

Copy link
Copy Markdown
Collaborator

Thanks for opening this. I'm trying to prioritize getting #175 merged so I can release the provider (since it's been a while since the last release). That will require a minor change to the vatesfr/xo-sdk-go client. I'll follow up with that small change and run it against the provider's test suite tomorrow.

@ddelnano ddelnano mentioned this pull request Nov 19, 2021
1 task
@4censord

Copy link
Copy Markdown
Contributor

In #213 and #195 I did some minor changes to the client.
Should I open those as separate PRs against the extracted client SDK?

@ddelnano

Copy link
Copy Markdown
Collaborator

Sorry for the delay, but I'll be giving your PRs a look this week.

@ddelnano ddelnano closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split Go client/SDK in a separate git repository?

3 participants