feat(xo6/new-vm-form): allow resizing existing template disks when a config drive is used

Author: AlinaD-2912

@xen-orchestra/web/src/modules/vm/components/new/NewVmSrTable.vue

@@ -33,12 +33,14 @@ import UiTableCell from '@core/components/ui/table-cell/UiTableCell.vue'
 import { useFormSelect } from '@core/packages/form-select'
 import { useNewVmSrColumns } from '@core/tables/column-sets/new-vm-sr-columns.ts'
 import { renderBodyCell } from '@core/tables/helpers/render-body-cell.ts'
-import { toRef } from 'vue'
+import { toRef, watch } from 'vue'
 import { useI18n } from 'vue-i18n'
 
-const { vmState, srs } = defineProps<{
+const { vmState, srs, canResizeExistingDisks, defaultExistingVdis } = defineProps<{
   vmState: VmState
   srs: FrontXoSr[]
+  canResizeExistingDisks: boolean
+  defaultExistingVdis: Vdi[]
 }>()
 
 const emit = defineEmits<{
@@ -65,10 +67,29 @@ const { HeadCells, BodyCells, colspan } = useNewVmSrColumns({
     const size = toRef(vdi, 'size')
     const description = toRef(vdi, 'name_description')
 
+    const isExistingVdi = vmState.existingVdis.includes(vdi)
+    const defaultVdi = isExistingVdi ? defaultExistingVdis[vmState.existingVdis.indexOf(vdi)] : undefined
+    const isDisabled = isExistingVdi ? !canResizeExistingDisks : false
+
+    if (isExistingVdi && defaultVdi) {
+      watch(
+        () => vdi.size,
+        newValue => {
+          if (isExistingVdi && newValue < defaultVdi.size) {
+            vdi.size = defaultVdi.size
+          }
+        }
+      )
+    }
+
     return {
       sr: r => r(srSelectId),
       diskName: r => r(diskName),
-      size: r => r(size, { disabled: !onRemove }),
+      size: r =>
+        r(size, {
+          disabled: isDisabled,
+          min: defaultVdi?.size ?? 1,
+        } as any),
       description: r => r(description),
       remove: r => (onRemove ? r(onRemove) : renderBodyCell()),
     }

@xen-orchestra/web/src/pages/vm/new.vue

@@ -192,6 +192,8 @@
             <NewVmSrTable
               :srs="filteredSrs"
               :vm-state
+              :can-resize-existing-disks="canResizeExistingDisks"
+              :default-existing-vdis="defaultExistingVdis"
               @add="addStorageEntry()"
               @remove="index => deleteItem(vmState.vdis, index)"
             />
@@ -634,26 +636,32 @@ const redirectToPool = (poolId: XoPool['id']) => {
   router.push({ name: '/pool/[id]/dashboard', params: { id: poolId } })
 }
 
-function getExistingVdisDiff(vdi1: Vdi, vdi2: Vdi) {
-  const changes: Record<string, unknown> = {}
-  let hasChanged = false
+function getExistingVdisDiff(vdi1: Vdi, vdi2: Vdi, canResizeExistingDisks: boolean = false) {
+  const changes: Partial<Vdi> = {}
 
-  for (const _key in vdi1) {
-    const key = _key as keyof Vdi
+  if (vdi1.name_label !== vdi2.name_label) {
+    changes.name_label = vdi2.name_label
+  }
 
-    if (vdi1[key] !== vdi2[key]) {
-      hasChanged = true
-      changes[key] = vdi2[key]
-    }
+  if (vdi1.name_description !== vdi2.name_description) {
+    changes.name_description = vdi2.name_description
+  }
+
+  if (canResizeExistingDisks && vdi1.size !== vdi2.size) {
+    changes.size = vdi2.size
   }
 
-  return hasChanged ? (changes as Partial<Vdi>) : undefined
+  return Object.keys(changes).length > 0 ? changes : undefined
 }
 
+const canResizeExistingDisks = computed(() => {
+  return vmState.installMode !== 'no-config'
+})
+
 const modifiedExistingVdis = computed(() => {
   return vmState.existingVdis.reduce<Partial<Vdi>[]>((acc, vdi, index) => {
     const defaultVdi = defaultExistingVdis.value[index]
-    const changes = getExistingVdisDiff(defaultVdi, vdi)
+    const changes = getExistingVdisDiff(defaultVdi, vdi, canResizeExistingDisks.value)
 
     if (changes) {
       acc.push({ ...changes, userdevice: vdi.userdevice })