feat(xo-lite): add network delete action for host internal networks - #10332
Open
amouillard-vates wants to merge 1 commit into
Open
feat(xo-lite): add network delete action for host internal networks#10332amouillard-vates wants to merge 1 commit into
amouillard-vates wants to merge 1 commit into
Conversation
MarieGarde
reviewed
Sep 3, 2026
| <MenuItem icon="action:copy" :disabled="!isClipboardSupported" @click="copy()"> | ||
| {{ t('action:copy-info-json') }} | ||
| </MenuItem> | ||
| <NetworkDeleteMenuItem v-if="pifsCount === 0" :network /> |
Collaborator
There was a problem hiding this comment.
To match the mockups more closely, delete should be moved out of "more actions", like here:
Collaborator
|
You can add screenshots of the modal |
MarieGarde
reviewed
Sep 3, 2026
| ## **0.25.0** (2026-08-31) | ||
| ## **next** | ||
|
|
||
| - [Pool/Network] Add the possibility to delete host internal networks |
MarieGarde
reviewed
Sep 3, 2026
| "job:migrate:in-progress": "Migrate in progess…", | ||
| "job:network-delete:has-n-physical-pif-connected": "The network has one physical PIF connected | The network has {n} physical PIFs connected", | ||
| "job:network-delete:has-n-vif-attached": "The network has one VIF attached | The network has {n} VIFs attached", | ||
| "job:network-delete:missing-network": "No networks to delete", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "job:network-delete:missing-network": "No networks to delete", | |
| "job:network-delete:missing-network": "No network to delete", |
MarieGarde
reviewed
Sep 3, 2026
| <MenuItem icon="action:copy" :disabled="!isClipboardSupported" @click="copy()"> | ||
| {{ t('action:copy-info-json') }} | ||
| </MenuItem> | ||
| <NetworkDeleteMenuItem v-if="pifsCount === 0" :network /> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <NetworkDeleteMenuItem v-if="pifsCount === 0" :network /> | |
| <NetworkDeleteMenuItem v-if="network.PIFs.length === 0" :network /> |
This way, it no longer depends on the PIF store loading.
MarieGarde
reviewed
Sep 3, 2026
Comment on lines
+98
to
+108
| actions: [ | ||
| { | ||
| label: t('action:delete'), | ||
| icon: 'action:delete', | ||
| danger: true, | ||
| onClick: () => deleteNetworks(), | ||
| busy: isDeletingNetworks.value, | ||
| disabled: !canDeleteNetworks.value, | ||
| hint: deleteNetworksErrorMessage.value, | ||
| }, | ||
| ], |
Collaborator
There was a problem hiding this comment.
Suggested change
| actions: [ | |
| { | |
| label: t('action:delete'), | |
| icon: 'action:delete', | |
| danger: true, | |
| onClick: () => deleteNetworks(), | |
| busy: isDeletingNetworks.value, | |
| disabled: !canDeleteNetworks.value, | |
| hint: deleteNetworksErrorMessage.value, | |
| }, | |
| ], | |
| component: NetworkDeleteMenuItem, | |
| props: { network }, |
I'd suggest doing the same as in VmsTable: to reduce the amount of code in this file, call NetworkDeleteMenuItem directly and remove the code added to VtsAction.
MarieGarde
reviewed
Sep 3, 2026
Comment on lines
+86
to
+88
| const { deleteNetworks, canDeleteNetworks, isDeletingNetworks, deleteNetworksErrorMessage } = useNetworkDelete( | ||
| () => [network] | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| const { deleteNetworks, canDeleteNetworks, isDeletingNetworks, deleteNetworksErrorMessage } = useNetworkDelete( | |
| () => [network] | |
| ) |
See comment below
MarieGarde
reviewed
Sep 3, 2026
| @@ -85,3 +87,9 @@ function isGroupAction(action: ActionItem): action is GroupActionItem { | |||
| return 'children' in action | |||
| } | |||
| </script> | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| </script> |
MarieGarde
reviewed
Sep 3, 2026
| icon?: IconName | ||
| disabled?: boolean | ||
| busy?: boolean | ||
| danger?: boolean |
Collaborator
There was a problem hiding this comment.
Suggested change
| danger?: boolean |
MarieGarde
reviewed
Sep 3, 2026
| <MenuItem | ||
| v-for="(action, index) of actions" | ||
| :key="index" | ||
| :class="{ danger: action.danger }" |
Collaborator
There was a problem hiding this comment.
Suggested change
| :class="{ danger: action.danger }" |
See comment on PoolHostInternalNetworksTable.vue
MarieGarde
requested changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a delete action for host internal networks in XO Lite
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.
Notes: