fix(xo-server): disable restart toolstack on HA pools - #10344
Open
ayoub-el-kajji-v wants to merge 4 commits into
Open
fix(xo-server): disable restart toolstack on HA pools#10344ayoub-el-kajji-v wants to merge 4 commits into
ayoub-el-kajji-v wants to merge 4 commits into
Conversation
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
ayoub-el-kajji-v
marked this pull request as ready for review
September 2, 2026 13:40
mpiton
requested changes
Sep 3, 2026
| const { pool } = this | ||
|
|
||
| if (pool.ha_enabled) { | ||
| throw new Error('HA must be disabled on the pool to restart the agent') |
Collaborator
There was a problem hiding this comment.
incorrectState is already imported here, and installPatches throws it for this same HA condition. A plain Error gives REST a 500 and non-admin users "unknown error from the peer". Can this reuse incorrectState?
| const { pool } = this | ||
|
|
||
| if (pool.ha_enabled) { | ||
| throw new Error('HA must be disabled on the pool to restart the agent') |
Collaborator
There was a problem hiding this comment.
This now also fires inside xostor.installDependencies, after the packages are already installed on an HA pool. Should the HA check sit next to backupGuard in the two restart entry points instead?
Collaborator
|
Don't forget : "If bug fix, add Introduced by" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[XO-2916] This PR throws an error and disable restart toolstack for the hosts who belongs to HA enabled pools
Introduced by 3293e69
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.
Notes: