Skip to content

fix(xo-server): disable restart toolstack on HA pools - #10344

Open
ayoub-el-kajji-v wants to merge 4 commits into
masterfrom
fix/xapi/disable-restart-toolstack-on-ha-pool
Open

fix(xo-server): disable restart toolstack on HA pools#10344
ayoub-el-kajji-v wants to merge 4 commits into
masterfrom
fix/xapi/disable-restart-toolstack-on-ha-pool

Conversation

@ayoub-el-kajji-v

@ayoub-el-kajji-v ayoub-el-kajji-v commented Sep 2, 2026

Copy link
Copy Markdown

Description

[XO-2916] This PR throws an error and disable restart toolstack for the hosts who belongs to HA enabled pools
Introduced by 3293e69

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.
  4. If the PR relates to a change in the openAPI specification, a member of the DevOps team must also participate in the review.

@plane-sync-vates

Copy link
Copy Markdown

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@ayoub-el-kajji-v
ayoub-el-kajji-v marked this pull request as ready for review September 2, 2026 13:40
Comment thread @xen-orchestra/xapi/host.mjs Outdated
const { pool } = this

if (pool.ha_enabled) {
throw new Error('HA must be disabled on the pool to restart the agent')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrectState is already imported here, and installPatches throws it for this same HA condition. A plain Error gives REST a 500 and non-admin users "unknown error from the peer". Can this reuse incorrectState?

Comment thread @xen-orchestra/xapi/host.mjs Outdated
const { pool } = this

if (pool.ha_enabled) {
throw new Error('HA must be disabled on the pool to restart the agent')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now also fires inside xostor.installDependencies, after the packages are already installed on an HA pool. Should the HA check sit next to backupGuard in the two restart entry points instead?

Comment thread CHANGELOG.unreleased.md Outdated
@mpiton

mpiton commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Don't forget : "If bug fix, add Introduced by"

@ayoub-el-kajji-v ayoub-el-kajji-v changed the title fix(xapi): disable restart toolstack on HA pools fix(xo-server): disable restart toolstack on HA pools Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants