feat(web-core): add accent prop to MenuItem - #10348
Open
amouillard-vates wants to merge 3 commits into
Open
Conversation
sylvere-a
requested changes
Sep 4, 2026
sylvere-a
left a comment
sylvere-a
left a comment
Collaborator
There was a problem hiding this comment.
-
Additional file to be changed:
@xen-orchestra/web/src/modules/pool/components/list/PoolsTable.vue:
'action:forget'and'action:disconnect'should have the "danger" accent as well. -
The XO Lite changelog should probably be updated?
| <MenuItem accent="brand" icon="fa:layer-group" @click="emit('convertToGroup')"> | ||
| {{ t('action:turn-into-group') }} | ||
| </MenuItem> | ||
| <MenuItem accent="brand" icon="fa:trash" @click="emit('remove')">{{ t('action:delete-filter') }}</MenuItem> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <MenuItem accent="brand" icon="fa:trash" @click="emit('remove')">{{ t('action:delete-filter') }}</MenuItem> | |
| <MenuItem accent="danger" icon="fa:trash" @click="emit('remove')">{{ t('action:delete-filter') }}</MenuItem> |
Figma says it should be "danger" (even though it does not have a special class for now - and the menu's z-index is broken...)
| <MenuItem accent="brand" @click="emit('remove', true)"> | ||
| {{ t('action:move-filters-to-parent-group') }} | ||
| </MenuItem> | ||
| <MenuItem accent="brand" @click="emit('remove')">{{ t('action:delete-group') }}</MenuItem> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <MenuItem accent="brand" @click="emit('remove')">{{ t('action:delete-group') }}</MenuItem> | |
| <MenuItem accent="danger" @click="emit('remove')">{{ t('action:delete-group') }}</MenuItem> |
same as previous file
| <MenuItem v-if="showChangeStateButton && !uiStore.isSmall" icon="action:change-state" class="change-state"> | ||
| <MenuItem | ||
| v-if="showChangeStateButton && !uiStore.isSmall" | ||
| accent="brand" |
Collaborator
There was a problem hiding this comment.
Should be a different accent, as discussed
| <template> | ||
| <MenuItem | ||
| v-tooltip="!canDetachHost && detachHostErrorMessage" | ||
| accent="brand" |
Collaborator
There was a problem hiding this comment.
Should be a different accent, as discussed
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <MenuItem class="change-state" icon="action:change-state"> | |||
| <MenuItem accent="brand" class="change-state" icon="action:change-state"> | |||
Collaborator
There was a problem hiding this comment.
"Change state" exception here too
| @@ -1,5 +1,6 @@ | |||
| <template> | |||
| <MenuItem | |||
| accent="brand" | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| accent="brand" | |
| accent="danger" |
- remove the
disconnectclass on this element - delete the
.disconnectclass at the bottom of this file
| </MenuItem> | ||
|
|
||
| <MenuItem class="icon" icon="fa:arrow-right-from-bracket" @click="logout()"> | ||
| <MenuItem accent="brand" class="icon" icon="fa:arrow-right-from-bracket" @click="logout()"> |
Collaborator
There was a problem hiding this comment.
For some reason the icon is white in the default state now (but ok on hover)...
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <MenuItem icon="action:delete" :disabled="!canDeleteVifs" :busy="isDeletingVifs" @click="deleteVifs()"> | |||
| <MenuItem accent="brand" icon="action:delete" :disabled="!canDeleteVifs" :busy="isDeletingVifs" @click="deleteVifs()"> | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| <MenuItem accent="brand" icon="action:delete" :disabled="!canDeleteVifs" :busy="isDeletingVifs" @click="deleteVifs()"> | |
| <MenuItem accent="danger" icon="action:delete" :disabled="!canDeleteVifs" :busy="isDeletingVifs" @click="deleteVifs()"> |
| <template> | ||
| <MenuItem | ||
| v-tooltip="areSomeVmsInExecution && t('selected-vms-in-execution')" | ||
| accent="brand" |
Collaborator
There was a problem hiding this comment.
Suggested change
| accent="brand" | |
| accent="danger" |
Comment on lines
30
to
34
| <style lang="postcss" scoped> | ||
| .delete { | ||
| color: var(--color-danger-item-base); | ||
| } | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds accent prop to MenuItem and remove local overrides
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.
Notes: