Repository navigation
Commit dd03867
revert: hold the aperture edge check out of the release
Reverts merge 927a506, which carried 2755b3a (code-update/
aperture-edge-validity-20261014): rejecting rays that enter an
asphere through its rim, and sizing prune_surf apertures only from
sensor-reaching rays.
The check is physically right and changes no evaluated metric of an
existing lens, but it changes AutoLens trajectories: with lost edge
rays out of the RMS loss, vignetting becomes free. In the short ex2
gate, full-field throughput fell on 3 of 4 seeds (v2.5.6 -> dev:
s1 0.81 -> 0.78, s2 0.69 -> 0.77, s3 0.99 -> 0.42, s7 0.77 -> 0.48).
Held out of this release until the owner decides to re-land it.
To re-land it, revert this commit (re-merging the branch would be a
no-op, since its commits are already in history).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent 70c7363 commit dd03867
3 files changed
Lines changed: 6 additions & 205 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
45 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
46 | 46 | | |
47 | | - | |
48 | | - | |
| 47 | + | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
| |||
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | 78 | | |
| 79 | + | |
84 | 80 | | |
85 | 81 | | |
86 | 82 | | |
| |||
95 | 91 | | |
96 | 92 | | |
97 | 93 | | |
98 | | - | |
99 | | - | |
100 | | - | |
| 94 | + | |
101 | 95 | | |
102 | 96 | | |
103 | 97 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | 181 | | |
244 | 182 | | |
245 | 183 | | |
| |||
This file was deleted.
0 commit comments