Skip to content

Commit be63a79

Browse files
authored
test(e2e): run vfox main against a Windows home containing a space (#42)
vfox main carries the fix for Windows homes containing a space (version-fox/vfox#712), so its combos now point VFOX_HOME at C:\Users\John Doe\.vfox, the layout from version-fox/vfox-flutter#33. Released builds still fail on such paths, so they keep the unspaced slot home. The plugin only double-quotes Windows paths when they contain whitespace: vfox main passes the command line to cmd.exe verbatim, so the quotes survive, while released builds still re-quote the line and mangle embedded double quotes. Also check the license headers of YAML, TOML, Dockerfiles and ignore files: SkyWalking Eyes already knows their comment style, so they no longer need to be excluded from paths-ignore. go.mod and .gitattributes get hand-written headers because the fixer knows no comment style for them, as does Dockerfile-runner (the fixer only matches the exact name `Dockerfile`). The two Windows Dockerfiles keep `# escape=` on line 1, so their headers sit right below it. go.sum stays ignored: the go tool parses every non-empty line as a hash record.
1 parent 709d41e commit be63a79

23 files changed

Lines changed: 301 additions & 24 deletions

‎.dockerignore‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# Copyright 2026 Han Li and contributors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
.git
216
.gitignore
317
.idea

‎.gitattributes‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,15 @@
1+
# Copyright 2026 Han Li and contributors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
* text=auto eol=lf

‎.github/workflows/e2e.yml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# Copyright 2026 Han Li and contributors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
name: E2E
216

317
on:

‎.github/workflows/license.yml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# Copyright 2026 Han Li and contributors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
name: License
216

317
on:

‎.github/workflows/lint.yml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# Copyright 2026 Han Li and contributors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
name: Lint
216

317
on:

‎.github/workflows/publish.yaml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# Copyright 2026 Han Li and contributors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
name: Plugin
216

317
on:

‎.github/workflows/test.yml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# Copyright 2026 Han Li and contributors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
name: Test Plugin
216

317
on:

‎.gitignore‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,15 @@
1+
# Copyright 2026 Han Li and contributors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
.idea

‎.licenserc.yaml‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,13 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414
#
15-
# License header check (Apache SkyWalking Eyes): Go and Lua are both covered.
15+
# License header check (Apache SkyWalking Eyes): Go, Lua, YAML, TOML,
16+
# Dockerfiles, ignore files and similar text formats are covered.
17+
# Some headers stay hand-written because `header fix` cannot place them:
18+
# go.mod and .gitattributes have no comment style upstream, the Windows
19+
# Dockerfiles must keep `# escape=` on line 1 (their headers sit right
20+
# below it), and the fixer only recognises the exact name `Dockerfile`,
21+
# not Dockerfile-runner. The checker still verifies them all.
1622
# PowerShell is check-only here (no `<# ... #>` fix support upstream):
1723
# tests/e2e/windows/*.ps1 is fixed and checked with addlicense instead (see
1824
# the addlicense step in .github/workflows/license.yml and docs/e2e.md).
@@ -38,18 +44,11 @@ header:
3844
limitations under the License.
3945
4046
paths-ignore:
41-
# Documentation and data files carry no license header.
47+
# Files without the header by design; go.sum cannot take one at all (the
48+
# go tool parses every non-empty line as a hash record).
4249
- '**/*.md'
43-
- '**/*.yaml'
44-
- '**/*.yml'
4550
- '**/*.json'
46-
- '**/*.toml'
47-
- '**/go.mod'
4851
- '**/go.sum'
49-
- '**/Dockerfile*'
50-
- '.gitignore'
51-
- '.gitattributes'
52-
- '.dockerignore'
5352
- '.tool-versions'
5453
- 'LICENSE'
5554
# Plain-text template for addlicense (no comment markers in it; keep its

‎docs/e2e.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,13 @@ needs an ARM64 host (a Copilot+ PC or the `windows-11-arm` CI runner).
4242
The `windows-11-arm` runner has no Windows Hypervisor Platform feature,
4343
so Hyper-V isolation is unavailable; process isolation needs only the Containers feature.
4444

45+
The `main` combos run with `VFOX_HOME` pointing inside a path containing a
46+
space (`C:\Users\John Doe\.vfox`), mirroring
47+
[issue #33](https://github.com/version-fox/vfox-flutter/issues/33). Only vfox
48+
`main` carries the fix for such paths
49+
([vfox#712](https://github.com/version-fox/vfox/pull/712)), so `latest`
50+
combinations still run with an unspaced home.
51+
4552
### x64
4653

4754
1. Execute in Windows PowerShell 5.1,

0 commit comments

Comments
 (0)