Skip to content

Commit f5ace30

Browse files
committed
Simplify E2E
1 parent 68be8d9 commit f5ace30

3 files changed

Lines changed: 3 additions & 9 deletions

File tree

‎.github/workflows/e2e.yml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ jobs:
2020
timeout-minutes: 60
2121
steps:
2222
- uses: actions/checkout@v7
23-
with:
24-
persist-credentials: false
2523
- run: docker build --pull -f tests/e2e/Dockerfile -t vfox-flutter-e2e .
2624
- run: docker run --rm -e VFOX_VERSION=latest vfox-flutter-e2e
2725
- run: docker run --rm -e VFOX_VERSION=main vfox-flutter-e2e
@@ -33,8 +31,6 @@ jobs:
3331
timeout-minutes: 90
3432
steps:
3533
- uses: actions/checkout@v7
36-
with:
37-
persist-credentials: false
3834
- run: docker build --pull -f tests/e2e/Dockerfile.windows -t vfox-flutter-e2e .
3935
- run: docker run --rm -e VFOX_VERSION=latest vfox-flutter-e2e
4036
- run: docker run --rm -e VFOX_VERSION=main vfox-flutter-e2e

‎docs/e2e.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ containerized end-to-end suite exercises the plugin against real vfox (`latest`
66

77
## Running on Ubuntu 26.04
88

9-
Assume that the rootful Docker Engine is already installed.
9+
Assume that Git and Docker Engine (in either rootful or rootless mode) are already installed.
1010

1111
Execute in Bash,
1212

‎tests/e2e/run.ps1‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ $PSNativeCommandUseErrorActionPreference = $true
44
$VfoxVersion = if ($env:VFOX_VERSION) { $env:VFOX_VERSION } else { 'latest' }
55

66
$RepoRoot = (Resolve-Path "$PSScriptRoot\..\..").Path
7-
$WorkDir = "$env:TEMP\vfox-flutter-e2e"
7+
$WorkDir = "$env:TEMP/vfox-flutter-e2e"
88
New-Item -ItemType Directory -Force -Path $WorkDir | Out-Null
99
$VfoxExe = "$WorkDir\vfox.exe"
1010
$PluginZip = "$WorkDir\flutter.zip"
@@ -24,11 +24,9 @@ function Install-VfoxMain {
2424
& curl.exe -fsSL -o $goMsi 'https://go.dev/dl/go1.27.1.windows-amd64.msi'
2525
Start-Process msiexec.exe -Wait -ArgumentList '/i', "`"$goMsi`"", '/quiet', '/norestart'
2626
Remove-Item $goMsi
27-
$env:PATH = "$WorkDir;" + [Environment]::GetEnvironmentVariable('Path', 'Machine')
2827
$src = "$WorkDir\vfox-src"
2928
git clone --depth 1 https://github.com/version-fox/vfox $src
30-
Push-Location $src
31-
try { go build -trimpath -o $VfoxExe . } finally { Pop-Location }
29+
go build -C $src -trimpath -o $VfoxExe .
3230
}
3331

3432
if ($VfoxVersion -eq 'main') { Install-VfoxMain } else { Install-VfoxRelease }

0 commit comments

Comments
 (0)