Repository navigation
test(e2e): run vfox main against a Windows home containing a space - #42
Merged
Merged
Conversation
linghengqian
force-pushed
the
add-main-br
branch
2 times, most recently
from
October 9, 2026 17:25
d894cbd to
46f1ec6
Compare
vfox main carries the fix for Windows homes containing a space (version-fox/vfox#712), so its combos now point VFOX_HOME at C:\Users\John Doe\.vfox, the layout from version-fox/vfox-flutter#33. Released builds still fail on such paths, so they keep the unspaced slot home. The plugin only double-quotes Windows paths when they contain whitespace: vfox main passes the command line to cmd.exe verbatim, so the quotes survive, while released builds still re-quote the line and mangle embedded double quotes. Also check the license headers of YAML, TOML, Dockerfiles and ignore files: SkyWalking Eyes already knows their comment style, so they no longer need to be excluded from paths-ignore. go.mod and .gitattributes get hand-written headers because the fixer knows no comment style for them, as does Dockerfile-runner (the fixer only matches the exact name `Dockerfile`). The two Windows Dockerfiles keep `# escape=` on line 1, so their headers sit right below it. go.sum stays ignored: the go tool parses every non-empty line as a hash record.
linghengqian
force-pushed
the
add-main-br
branch
from
October 9, 2026 17:59
46f1ec6 to
5e2cfda
Compare
linghengqian
marked this pull request as ready for review
October 9, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-EncodedCommandto fix paths with spaces vfox#712), so its combos now point VFOX_HOME at C:\Users\John Doe.vfox, the layout from Remove documentation regarding the lack of support for Windows 11 folder names containing spaces vfox#723. Released builds still fail on such paths, so they keep the unspaced slot home.