Repository navigation
test(e2e): share one tools stage across the Windows images and drop the MSIs - #40
Merged
Merged
Conversation
…he MSIs Build the compose runner and the per-combo image from one multi-stage Dockerfile, so pwsh, Git and Go install once per host and the suite's own build only copies the plugin in. Unpack pwsh and Go from their zips instead of msiexec, reuse the image Go for vfox@main instead of a second MSI install per combo, and run every Windows combo at once in CI.
… tools Replace the compose runner with tests/e2e/windows/run.ps1. It pulls the servercore base image in the background while it fetches pwsh, PortableGit and the pinned Go into a per-arch host cache, builds vfox@main once, and compiles the suite. The cache is bind-mounted read-only at C:\tools into every combo container, so the image no longer commits a layer of tens of thousands of tool files, which took 2-6 minutes on the hosted runners.
PowerShell splits a bare -test.v into -test and .v, so the suite exited with 'flag provided but not defined: -test'.
windows-11-arm spends about four minutes installing Go and building moby before the suite can pull anything. Keep the binaries in C:\vfox-docker\bin, restore that directory with actions/cache keyed on install-docker-arm64.ps1, and skip setup-go and the build on a hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.