Skip to content

Fix Inverted condition on isPaused method - #267

Merged
ppatierno merged 1 commit into
vert-x3:4.xfrom
dometec:fix_inverted_condition
Apr 21, 2026
Merged

Fix Inverted condition on isPaused method#267
ppatierno merged 1 commit into
vert-x3:4.xfrom
dometec:fix_inverted_condition

Conversation

@dometec

@dometec dometec commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

#261 (Pause/Resume read from Socket - branch 4.x) introduce a bug in

public synchronized boolean isPaused() {
return connOption.isAutoRead();

The condition must be negated.

@dometec
dometec force-pushed the fix_inverted_condition branch from 573bf0e to edaa79d Compare April 18, 2026 18:01
@dometec

dometec commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

Add recvByteBufAllocatorSize to MqttClientOptions and update converter.

@ppatierno

Copy link
Copy Markdown
Member

Add recvByteBufAllocatorSize to MqttClientOptions and update converter.

I think PRs should be focused on just one thing.

@dometec

dometec commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

Sure, but this is related to always to pause/resume features as described in smallrye/smallrye-reactive-messaging#3378

@ppatierno

Copy link
Copy Markdown
Member

How the code you changed around !connOption.isAutoRead(); is impacting or is impacted by the receiver buffer size. It's not clear from the PR. Also the link you are referring to in smallrye seems to be more about the receiver buffer size than what this PR seems to aim to fix from the title "FIx Inverted condition on isPaused method".

@dometec

dometec commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

clear, let me move the option in a new PR.

@dometec
dometec force-pushed the fix_inverted_condition branch from 04624b9 to edaa79d Compare April 20, 2026 16:12
@dometec dometec changed the title FIx Inverted condition on isPaused method Fix Inverted condition on isPaused method Apr 20, 2026
@ppatierno

Copy link
Copy Markdown
Member

Related to feature added in #261

Sorry to be pedantic but I guess the description doesn't explain the changes. I think you should mention that the #261 introduced a bug whre the isPaused is wrongly defined and this PR is addressing such a bug.

@dometec

dometec commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

No Paolo, things should be done properly because many people will read this in the future. Thanks for your patience. If you agree, we can delete all comments not related to the PR just to reduce the noise.

@ppatierno ppatierno added this to the 4.5.27 milestone Apr 21, 2026
@ppatierno
ppatierno merged commit 35981c1 into vert-x3:4.x Apr 21, 2026
7 checks passed
@dometec
dometec deleted the fix_inverted_condition branch April 27, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants