fix(feedback): prevent crash submitting feedback without a highlight - #5319
Merged
Jeremy Rose (jeremyrose-viam) merged 1 commit intoSep 17, 2026
Conversation
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Jeremy Rose (jeremyrose-viam)
requested a review
from Eliza Farley (elizafarley)
September 15, 2026 21:28
Eliza Farley (elizafarley)
approved these changes
Sep 16, 2026
Jeremy Rose (jeremyrose-viam)
merged commit Sep 17, 2026
6ee825c
into
viamrobotics:main
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
submitFeedback()inassets/js/feedback.jsassumed a page element was always highlighted before submit, sohighlightedInfo[0].textthrew aTypeErrorwhen a user typed feedback and clicked Submit without highlighting anything (highlighting is optional)."(no element selected)"when nothing was highlighted.Jira: DOCS-4968
Test plan