Skip to content
This repository was archived by the owner on Jun 21, 2024. It is now read-only.

Fix processing of tsx files by SWC - #19

Open
johnmarkredding wants to merge 3 commits into
vicb:masterfrom
johnmarkredding:create-store-rtk
Open

Fix processing of tsx files by SWC#19
johnmarkredding wants to merge 3 commits into
vicb:masterfrom
johnmarkredding:create-store-rtk

Conversation

@johnmarkredding

Copy link
Copy Markdown
Contributor

There was an issue with rollup not correctly bundling the imported @reduxjs/toolkit package.
The error was a bit confusing, and it was hard to find info regarding it on the forums.
Debugging led me to including .tsx files in the rollupSwc plugin in rollup.config.js.

Original error

[!] RollupError: src/sounding.tsx (35:8): Expected ';', '}' or <eof> (Note that you need plugins to import files that are not JavaScript)
src/sounding.tsx (35:8)

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @johnmarkredding - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Potential hard-coded secret found: keyPEM (link)
  • Potential hard-coded secret found: certificatePEM (link)
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🔴 Security: 2 blocking issues
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Comment thread rollup.config.js
Comment thread rollup.config.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant