After an empty page is returned, the script stops. (Undiscord 2.0, PRR-S1)

[Spiders-In-The-Crypt]

Undiscord Version

Undiscord 2.0 by PRR-S1

Browser

Firefox 149.0.2

Extension

TamperMonkey

Reproduction steps

Opened Discord in browser, started the script, set user, set server, set authentication token. Did not set channel since I want it to delete in all channels.

Script stops scrolling whenever an empty page is returned. Sometimes it gets a few pages done, sometimes only one. Sometimes it doesn't even get one since it returns an empty page right away. I pretty much have to manually click for every 25 messages worth of deletion.

Actual results

Script is basically manual, not automatic. No matter if Auto Scrolling setting is set to on or off.

Expected results

Should be automatic.

Bug affects

• DMs
• DMs (group)
• Channels
• Channel (NSFW)

Additional information & file uploads

[snip]

[Spiders-In-The-Crypt]

Just double checked - this also happens on the latest version of Chrome. So it is broken on both Firefox and Chrome.

[PRR-S1]

Archiving the project, thank you for informing me! (I have no plans of fixing it sorry)

[PRR-S1]

try @TheCellMaster script

[l-imei]

try this instead: https://github.com/gen3vra/deletediscordmessages

[TheCellMaster]

Hey! I've been working on a fork with fixes for this and many other issues. Still waiting for the PR to be reviewed by @victornpb, but in the meantime you can use it directly:

Install link (for Tampermonkey/Violentmonkey):

https://raw.githubusercontent.com/TheCellMaster/undiscord/master/deleteDiscordMessages.user.js

Just open the link and your userscript extension should prompt to install/update automatically.

What's fixed/added compared to upstream:

Fixed ETR counter actually decreasing as messages are deleted
Fixed Stop button not resetting back to Delete
Removed unnecessary 30s+ waits after completion
Fixed HTTP 403 infinite retry loop (skips messages instead)
Added thread auto-detection
Added "Include bot/application messages" toggle
Added empty page retries (configurable)
Implemented fixes from 14+ open community PRs (#741, #742, #743, #740, #739, #737, #729, #629, #610, #603, #643, #527, #519, #722)
XSS fix in log rendering + AbortSignal.timeout on all fetches
Rate limit caps to prevent runaway delays
My PR tracking all this: #796

Let me know if you run into any issues!****

[l-imei]

great, another unnecessary fork

[ametysti]

great, another unnecessary fork

Ego too high? 🙂

[l-imei]

Ego too high? 🙂

?

[rafa-br34]

I fixed mine by simply commenting out the following part:

	      else if (this.state._skippedMessages.length > 0) {
	        // There are stuff, but nothing to delete (example a page full of system messages)
	        // check next page until we see a page with nothing in it (end of results).
	        const oldOffset = this.state.offset;
	        this.state.offset += this.state._skippedMessages.length;
	        log.verb('There\'s nothing we can delete on this page, checking next page...');
	        log.verb(`Skipped ${this.state._skippedMessages.length} out of ${this.state._seachResponse.messages.length} in this page.`, `(Offset was ${oldOffset}, ajusted to ${this.state.offset})`);
	      }
	      else {
	        //log.verb('Ended because API returned an empty page.');
	        //log.verb('[End state]', this.state);
	        //if (isJob) break; // break without stopping if this is part of a job
	        //this.state.running = false;
	      }

and then added document.querySelector('#undiscord').style.display = ''; in the end as a hot-fix for #804
Also, this seems to be caused because Discord takes too long to index the messages, so you can try increasing the time between page queries.