Merge pull request #1 from vijaxx/add-unit-tests

Add unit tests for analytics_db and pincopy

Author: vijaxx

.github/workflows/ci.yml

@@ -18,7 +18,10 @@ jobs:
           cache: "pip"
 
       - name: Install dependencies
-        run: pip install -r requirements.txt
+        run: pip install -r requirements-dev.txt
 
       - name: Compile check
         run: python -m compileall -q .
+
+      - name: Run tests
+        run: python -m pytest tests/ -v

.gitignore

@@ -1,5 +1,6 @@
 __pycache__/
 *.pyc
+.pytest_cache/
 .DS_Store
 *.log
 out/

requirements-dev.txt

@@ -0,0 +1,2 @@
+-r requirements.txt
+pytest

tests/test_analytics_db.py

@@ -0,0 +1,50 @@
+import sqlite3
+import sys
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).resolve().parents[1]))
+
+import analytics_db as adb
+
+
+def test_init_db_creates_all_expected_tables(tmp_path):
+    db_path = str(tmp_path / "test.db")
+    adb.init_db(db_path)
+
+    conn = sqlite3.connect(db_path)
+    tables = {r[0] for r in conn.execute(
+        "SELECT name FROM sqlite_master WHERE type='table'")}
+    conn.close()
+
+    assert {"pins", "posts", "analytics", "sales"} <= tables
+
+
+def test_init_db_is_idempotent(tmp_path):
+    db_path = str(tmp_path / "test.db")
+    adb.init_db(db_path)
+    adb.init_db(db_path)  # must not raise on re-init
+
+    conn = adb.connect(db_path)
+    conn.execute("INSERT INTO pins (theme, idx) VALUES ('nature', 1)")
+    conn.commit()
+    row = conn.execute("SELECT theme, idx FROM pins").fetchone()
+    conn.close()
+
+    assert row["theme"] == "nature" and row["idx"] == 1
+
+
+def test_pins_table_rejects_duplicate_theme_idx(tmp_path):
+    db_path = str(tmp_path / "test.db")
+    adb.init_db(db_path)
+    conn = adb.connect(db_path)
+    conn.execute("INSERT INTO pins (theme, idx) VALUES ('nature', 1)")
+    conn.commit()
+    try:
+        conn.execute("INSERT INTO pins (theme, idx) VALUES ('nature', 1)")
+        conn.commit()
+        raised = False
+    except sqlite3.IntegrityError:
+        raised = True
+    finally:
+        conn.close()
+    assert raised, "UNIQUE(theme, idx) constraint should reject the duplicate"

tests/test_pincopy.py

@@ -0,0 +1,38 @@
+import sys
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).resolve().parents[1]))
+
+import pincopy
+
+
+def test_extract_json_parses_array_embedded_in_prose():
+    text = 'Sure, here you go:\n[{"a": 1}, {"a": 2}]\nHope that helps!'
+    assert pincopy.extract_json(text) == [{"a": 1}, {"a": 2}]
+
+
+def test_extract_json_returns_none_with_no_array():
+    assert pincopy.extract_json("no json here at all") is None
+
+
+def test_extract_json_returns_none_on_malformed_array():
+    assert pincopy.extract_json("[{broken json}]") is None
+
+
+def test_fallback_returns_five_variants():
+    variants = pincopy.fallback("Large Print Nature Word Search", 48)
+    assert len(variants) == 5
+    assert all(set(v.keys()) == {"title", "description"} for v in variants)
+
+
+def test_fallback_titles_fit_pinterest_length_limit():
+    variants = pincopy.fallback("Large Print Nature Word Search", 48)
+    for v in variants:
+        assert len(v["title"]) <= 100
+
+
+def test_fallback_strips_boilerplate_from_short_theme_name():
+    variants = pincopy.fallback("Large Print Nature Word Search", 48)
+    # "nature" (the actual theme) should show up; the generic wrapper words shouldn't
+    # dominate every title once stripped down to the short form.
+    assert any("nature" in v["title"].lower() for v in variants)