Add type hints to core modules - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.
Adds parameter/return type annotations to factory.py, pack.py, and pins.py -- the three modules the issue named. A
Palettetype alias makes the 4-tuple color scheme shape explicit instead of an anonymous tuple.Along the way, mypy caught two real (if minor) issues in pins.py that predate this PR:
Image.LANCZOSis the old Pillow constant spelling; switched toImage.Resampling.LANCZOS, the current one. The old one still works on the installed Pillow version, but the new one is what current Pillow actually documents.y) was implicitly narrowed tointby its first assignment, then had a float added to it a few lines later -- harmless at runtime (Python doesn't care), but needed an explicitfloatannotation to be honest about what the variable actually holds.Verified:
mypy --ignore-missing-importsclean on all three files, existing test suite passes unchanged, and I ranfactory.py --theme natureend-to-end (real pack PDF + 5 real pins + manifest, including the LANCZOS resize path) to confirm actual output is unaffected.