RHEL-185213: [Balloon] Remove dead ASSERT

[harshapa-rh]

KeWaitForSingleObject returns 4 possible statuses:
STATUS_SUCCESS - possible
STATUS_TIMEOUT - possible
STATUS_ALERTED - Alertable is set to FALSE so not possible
STATUS_USER_APC - Alertable is set to FALSE and the parameter is KernelMode instead of UserMode so again not possible

The ASSERT is defined in ntifs.h, balloon code does not redefine it. So in release builds it is harmless anyway. But in debug builds, NT_SUCCESS(STATUS_TIMEOUT) and NT_SUCCESS(STATUS_SUCCESS) both will be true. So ASSERT seems to be dead code here, we can remove it entirely.

Reference: KeWaitForSingleObject function (wdm.h) - Windows drivers

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of host acknowledgment events without triggering an unnecessary assertion.
  • Preserved existing timeout and status-reporting behavior.

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[YanVugenfirer]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3c8f2086-9784-4355-9cb7-9c7f25728994

📥 Commits

Reviewing files that changed from the base of the PR and between a66c7af and 3f639b9.

📒 Files selected for processing (1)

• Balloon/sys/balloon.c

💤 Files with no reviewable changes (1)

• Balloon/sys/balloon.c

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes the host acknowledgment success assertion in BalloonTellHost. Timeout detection and wait-result return behavior remain unchanged.

Changes

Balloon acknowledgment handling

Layer / File(s)	Summary
Wait result handling Balloon/sys/balloon.c	BalloonTellHost no longer asserts successful host acknowledgment after the wait. The function still detects timeout status and returns the wait result.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3f639

This PR removes a dead assertion without changing balloon runtime behavior, so no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: vrozenfe, ybendito, kostyanf14

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the balloon code change and the removal of the ineffective assertion.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[YanVugenfirer]

ok to test