Merge pull request #1271 from virtualmin/dev/add-http3-support #1446
virtualmin.dev+virtualmin-gpl.yml
on: push
build
/
CI code review
21s
build
/
Package and upload artifacts
1m 13s
Annotations
2 warnings
|
build / CI code review
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build / CI code review:
save_website.cgi#L112
HTTP/3 enable/disable handling can conflict with HTTP/2 handling when both form fields are
submitted: each block reads the current protocol list before saving its own change, so
changing both options in one submit can cause the later HTTP/3 save to overwrite the earlier
HTTP/2 save based on stale state.
Suggested fix:
Parse both http2 and http3 inputs into a single protocol list and call
save_domain_http_protocols once, or re-read the protocol list after the HTTP/2 save before
applying the HTTP/3 change.
|