Add deterministic Node Redis queue-race eval case - #286
Open
vishaltandale00 wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4f85030e42da2eed6a178e54994330af5062761e/ tree3a360d5440b2d73831123df48e24b3422676bb16with exact Darwin arm64, Node 22.23.2, npm 10.9.8, and integrity-checked production dependenciesPart of #278.
Verifier admission
npm run eval:admit:node-redispasses through the production grader.sha256:687161980572a3f6103471b06fe5a25641ce5e83c92b7f6ecc1f7fa1ebd86b09sha256:485a3139da3e8af40ec5ca8ec523be8dd5d4d3dddf6f077211aed091fd1ac953The candidate driver signs prototype-insensitive V8-serialized observations with an ephemeral Ed25519 key generated before candidate load. A separate evaluator process verifies those bytes and independently checks the full successful server transcript. The grader also requires the committed candidate regression to be red on the untouched source and green on the candidate.
Durable local adversarial assertions record reviewer, reviewed workspace digest, verdict, and unresolved findings. Both verdicts were admissible with zero unresolved findings. They remain non-certifying local review assertions pending PR review.
Verification
Passed on head
de6ee5c1116e4f7eca14c4c998a11c229228cb88:npm run buildnpx vitest run packages/eval-runner/test/node-redis-project-case.test.ts test/eval-service-simulated-user.test.mjs test/eval-app-integration.test.mjs— 3 files, 20 testsnpm run eval:admit:node-redisgit diff --checkRepository-wide unknowns
npm run checkwas run repeatedly but did not produce one aggregate green receipt on this host:relayer-app-serverenvironment tests intermittently timed out or reportedUnavailableunder aggregate load; every named failure passed when rerun aloneevidence-capture-integrityplus a too-small provider-video frameENOSPC; only this worktree's generated Cargo cache and evaluator-created temporary Redis workspaces were cleared, after which 4.0 GiB was available*.fixture.cjs, and focused/integration plus admission were rerun green afterwardAccordingly, the scoped Node Redis evidence is green, while the repository-wide aggregate check remains an explicit host/flakiness unknown rather than a claimed pass.
Upstream evidence