Skip to content

test: deepen provider authority scenarios (stack 1/12) - #349

Draft
vishaltandale00 wants to merge 1 commit into
mainfrom
codex/test-depth-01-provider-authority
Draft

test: deepen provider authority scenarios (stack 1/12)#349
vishaltandale00 wants to merge 1 commit into
mainfrom
codex/test-depth-01-provider-authority

Conversation

@vishaltandale00

Copy link
Copy Markdown
Owner

Stack

1 of 12. Base: main. This PR is the foundation of the test-depth reduction stack. Draft only; do not merge before the complete stack is presented.

Scope and checkpoints

Test-only change. Production seams observed: ProviderDefinitionService, ModelCatalogService, the Adapter registry, provider composition, and the real product app-server flow. No production behavior changes.

This preserves the PRD boundaries for provider authentication and discovery, capability admission, atomic definition/credential/runtime/catalog lifecycle, zero-eligible connected state, refresh authorization/cancellation/shutdown, static imports, and packaging.

Reduction

  • Provider portfolio registrations: 108 -> 62
  • Full Vitest registrations: 1,829 -> 1,783
  • Portfolio LOC: 2,989 -> 2,802

The replacements use scenario matrices and aggregate completion while retaining distinct failure and authority boundaries.

Verification plan

  • Run the seven-file focused provider portfolio.
  • Run npm run build.
  • Run npm run check; preserve any unrelated failure explicitly.
  • Require adversarial subsumption review of every retired test boundary.

Verification actually run

  • Focused provider portfolio: PASS, 7 files / 62 tests.
  • npm run build: PASS.
  • npm run check: repository gate remains RED only at test/provider-electron-evidence.test.mjs, timing out while waiting for same-turn retry submission; 147 Vitest files and 1,782 tests passed, 1 file/1 test failed, 1 skipped. The same unrelated timeout was reproduced before this final snapshot.
  • git diff --check: PASS.

Adversarial review

Reviewer /root/certify_pr1_provider; workspace diff SHA-256 f12b4bb6da2f7bb6e25ec5d4c5b87070104f044e638fcca98bdf182311f3bff2; reviewed the seven-file provider authority/catalog portfolio, exact 108->62 replacement manifest, fixture isolation, aggregate completion, stable labels, hook semantics, and mutation-visible authority/failure boundaries; verdict APPROVE with no unresolved subsumption findings; focused portfolio 62/62 passing and portfolio LOC 2,989->2,802.

Known gate

This draft does not claim a fully green repository check. The existing Electron evidence timeout remains visible for the stack review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant