test: consolidate harness migration matrices (stack 3/12) - #351
Draft
vishaltandale00 wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
3 of 12. Base:
codex/test-depth-02-model-selection-onboarding/ draft PR #350. Draft only; do not merge before the complete stack is presented.Scope
Test-only, limited to three pre-existing parameterized matrices: product Codex state migration (8 rows), deferred schema-v5 migration (2 rows), and checked-in Codex configurations (2 rows). No independent HarnessHost lifecycle test is folded into another test and no production code changes.
Reduction
Each prior
it.eachcallback remains once. Its original tuples execute sequentially with per-row cleanup, labeled failure causes, ordered aggregate results, and explicit row-count assertions (8/2/2) so tuple deletion fails.Verification actually run
npm run build: PASS.npm run check: repository gate remains RED only attest/provider-electron-evidence.test.mjs, timing out onsame-turn retry submission; 147 Vitest files and 1,752 tests passed, 1 file/1 test failed, 1 skipped.git diff --check: PASS.Adversarial review
Reviewer
/root/audit_provider_desktop; cached diff SHA-256d6ef90f77161d6ed518af9bad89566cdb348a0a41b47717deea06bb3558b0995; reviewed honest shared-body matrix compaction, frozen tuple inventory, per-row settlement/labels, cleanup, targetability, and mutation resistance; verdict APPROVE with no blocking findings. Nonblocking: individual rows lose-tselection, while all three matrices complete in milliseconds.Rejected alternative
A broader 111->55 callback-wrapper rewrite was discarded before commit after adversarial rejection as count hiding and a likely HTTP timeout flake. This PR intentionally claims only the compaction that shares an existing parameterized body.